Re: [igt-dev] [PATCH i-g-t v2 0/1] tests/prime_vgem: Fix broken handling of interprocess pipes

["Ser, Simon" <simon.ser@intel.com>]

On Thu, 2019-07-11 at 10:39 +0200, Janusz Krzysztofik wrote:
> If a child process dies for any reason while basic-fence-read or
> basic-fence-mmap subtest is run, the subtest may hang indefinitely on
> read() from a pipe which is supposed to be written to by that child
> (can
> be interrupted though).  Fix it by first closing unused pipe ends on
> both
> parent and child side before using the pipe, as recommended by
> pipe(2)
> manual page.
> 
> Please note that due to the IGT library way of handling signals, now
> the
> subtests may fail with error code 141 (128 + SIGPIPE) and no usual
> DEBUG
> message block on stderr nor FAIL message line on stdout, however some
> meaningful error messages will still be printed on stderr by the
> failing
> child processes.
> 
> v2: resend with Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
>     added

You generally don't need to resend a patch just to add a R-b tag.

Do you have IGT commit rights?

> Janusz Krzysztofik (1):
>   tests/prime_vgem: Fix broken handling of interprocess pipes
> 
>  tests/prime_vgem.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev