Re: [igt-dev] [PATCH i-g-t 1/3] lib/igt_sysfs: Generic verification of writable sysfs attributes

Dixit, Ashutosh
2022-12-15T18:27:12Z

On Thu, 15 Dec 2022 03:49:30 -0800, Tauro, Riana wrote:
>
> On 12/15/2022 8:01 AM, Ashutosh Dixit wrote:
> > +/* Sweep the range of values for an attribute to identify matching reads/writes */
> > +static int rw_attr_sweep(igt_sysfs_rw_attr_t *rw)
> > +{
> > + uint64_t get, set = rw->start;
> > + int num_points = 0;
> > + bool ret;
> > +
> Hi Ashutosh
>
> Thanks for the clarification regarding the clamp max on the previous rev.
> done sweeping igt_debug can be retained outside the while since there is no
> break/return anywhere else.
>
> Though not necessary since it behaves the same.
>
> Looks good to me
> Reviewed-by: Riana Tauro <riana.tauro@intel.com>

Thanks Riana, I made the above change and merged :)