From: Antonio Argenziano via igt-dev <igt-dev@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v5] tests/i915/gem_exec_schedule.c: Switch to gem_sync and gem_read
Date: Fri, 15 Feb 2019 14:56:59 -0800 [thread overview]
Message-ID: <71b337d7-9b87-8e31-526f-1b8379d377c0@intel.com> (raw)
In-Reply-To: <155026185352.18261.8067419542114316140@skylake-alporthouse-com>
On 15/02/19 12:17, Chris Wilson wrote:
> Quoting Antonio Argenziano (2019-02-15 15:42:02)
>> use IOCTLs gem_read for reading and, gem_sync to wait on a batch, this
>> will help testing platforms that might not expose gtt mapping.
>>
>> v2:
>> - use a local helper for reading from BOs. (Chris)
>> - Always sync before reading. (Chris)
>>
>> v3:
>> - Better helper naming. (Chris)
>> - Start read from actual offset. (Chris)
>>
>> v4:
>> - Always use byte size in helper. (Chris)
>>
>> v5:
>> - Fix byte<->count conversion. (Chris)
>>
>> Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
>>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>
> Seems safe now!
Thanks, pushed.
Antonio
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> -Chris
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2019-02-15 22:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 15:42 [igt-dev] [PATCH i-g-t v5] tests/i915/gem_exec_schedule.c: Switch to gem_sync and gem_read Antonio Argenziano via igt-dev
2019-02-15 17:04 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/i915/gem_exec_schedule.c: Switch to gem_sync and gem_read (rev5) Patchwork
2019-02-15 20:13 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-02-15 20:17 ` [igt-dev] [PATCH i-g-t v5] tests/i915/gem_exec_schedule.c: Switch to gem_sync and gem_read Chris Wilson
2019-02-15 22:56 ` Antonio Argenziano via igt-dev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71b337d7-9b87-8e31-526f-1b8379d377c0@intel.com \
--to=igt-dev@lists.freedesktop.org \
--cc=antonio.argenziano@intel.com \
--cc=chris@chris-wilson.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox