From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Antonio Argenziano <antonio.argenziano@intel.com>,
igt-dev@lists.freedesktop.org
Cc: Matthew Auld <matthew.auld@intel.com>
Subject: Re: [igt-dev] [RFC] tests/i915/gem_exec_fence: Pre-fault objects with dependencies
Date: Thu, 14 Mar 2019 16:56:29 -0700 [thread overview]
Message-ID: <71cb7b5d-b456-d4e1-4275-ee766104883c@intel.com> (raw)
In-Reply-To: <155260616014.30576.3110980035147255449@skylake-alporthouse-com>
On 3/14/19 4:29 PM, Chris Wilson wrote:
> Quoting Antonio Argenziano (2019-03-14 23:22:32)
>> In the fault manager code we wait on an active object to complete before
>> servicing the fault. This meant that the object 'out' used in the test
>> could not be read until it became inactive which could not happen since
>> it is kept busy from the store queued behind the spinner (at least). The
>> bug became evident only after using the mmap_offset patches since we
>> were not faulting before.
>
> out is using mmap_wc, it doesn't block inside the fault handler today.
> And it better had not start blocking in the future. Now for the opposite
> problem of removing the gratuitous blocking in the gtt fault handler,
> which may require some reminders to userspace that they needed to
> control sync themselves.
> -Chris
>
The current patches for mmap_offset do wait on all types of mapping, so
I guess we need to change that.
@Matt: I saw that there were lots of comments on that series so this
issue might have already been pointed out, but if it hasn't please add
it to the list ;)
Thanks,
Daniele
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-03-14 23:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 23:22 [igt-dev] [RFC] tests/i915/gem_exec_fence: Pre-fault objects with dependencies Antonio Argenziano
2019-03-14 23:29 ` Chris Wilson
2019-03-14 23:56 ` Daniele Ceraolo Spurio [this message]
2019-03-15 0:07 ` Chris Wilson
2019-03-14 23:54 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-15 12:11 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71cb7b5d-b456-d4e1-4275-ee766104883c@intel.com \
--to=daniele.ceraolospurio@intel.com \
--cc=antonio.argenziano@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox