Re: [PATCH i-g-t 3/7] tools/vmtb: Align driver/device layer with current xe SR-IOV interfaces

["Bernatowicz, Marcin" <marcin.bernatowicz@linux.intel.com>]

LGTM,

Reviewed-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>

On 9/28/2026 9:25 AM, Adam Miszczak wrote:
> Move VF VRAM quota provisioning from the obsolete debugfs lmem_quota
> attribute to the sysfs SRIOV admin tree
> (/sys/bus/pci/drivers/xe/[BDF]/sriov_admin/vf[N]/profile/vram_quota)
> and update the driver abstraction and provisioning helpers.
>
> Fix physical Device bind()/unbind() calls that still passed a PCI BDF
> to DriverInterface, breaking unload_drivers() with a TypeError.
>
> Add DeviceInterface.reset() that triggers an FLR via
> /sys/bus/pci/devices/[BDF]/reset - PF FLR on the host for physical
> devices and VF FLR in the guest for virtual devices.
>
> Signed-off-by: Adam Miszczak <adam.miszczak@linux.intel.com>
> ---
>   tools/vmtb/bench/drivers/driver_interface.py  |  8 ++--
>   tools/vmtb/bench/drivers/xe.py                | 39 ++++++++++---------
>   tools/vmtb/bench/machines/device_interface.py |  7 ++++
>   tools/vmtb/bench/machines/physical/device.py  | 12 ++++--
>   tools/vmtb/bench/machines/virtual/device.py   |  4 ++
>   5 files changed, 44 insertions(+), 26 deletions(-)
>
> diff --git a/tools/vmtb/bench/drivers/driver_interface.py b/tools/vmtb/bench/drivers/driver_interface.py
> index 0b0bd5abb..9d1e5ab00 100644
> --- a/tools/vmtb/bench/drivers/driver_interface.py
> +++ b/tools/vmtb/bench/drivers/driver_interface.py
> @@ -201,19 +201,19 @@ class PfDriverInterface(DriverInterface, abc.ABC):
>   
>       # VF provisioning
>       @abc.abstractmethod
> -    def get_ggtt_quota(self, vf_num: int, gt_num: int) -> int:
> +    def get_vram_quota(self, vf_num: int) -> int:
>           raise NotImplementedError
>   
>       @abc.abstractmethod
> -    def set_ggtt_quota(self, vf_num: int, gt_num: int, val: int) -> None:
> +    def set_vram_quota(self, vf_num: int, val: int) -> None:
>           raise NotImplementedError
>   
>       @abc.abstractmethod
> -    def get_lmem_quota(self, vf_num: int, gt_num: int) -> int:
> +    def get_ggtt_quota(self, vf_num: int, gt_num: int) -> int:
>           raise NotImplementedError
>   
>       @abc.abstractmethod
> -    def set_lmem_quota(self, vf_num: int, gt_num: int, val: int) -> None:
> +    def set_ggtt_quota(self, vf_num: int, gt_num: int, val: int) -> None:
>           raise NotImplementedError
>   
>       @abc.abstractmethod
> diff --git a/tools/vmtb/bench/drivers/xe.py b/tools/vmtb/bench/drivers/xe.py
> index 26e4e0a08..479c1dd87 100644
> --- a/tools/vmtb/bench/drivers/xe.py
> +++ b/tools/vmtb/bench/drivers/xe.py
> @@ -140,7 +140,27 @@ class XeDriver(PfDriverInterface):
>           path = self.__helper_create_debugfs_path(0, gt_num, '', 'sample_period_ms')
>           self.write_debugfs(path, str(val))
>   
> -    # VF and PF provisioning parameters
> +    # VF provisioning parameters
> +    # Sysfs location: [SRIOV sysfs base path]/sriov_admin/[vfN]/profile
> +    # @vf_num: VF number (1-based) or 0 for PF
> +    def get_vram_quota(self, vf_num: int) -> int:
> +        if vf_num == 0:
> +            logger.warning("PF vram_quota not available")
> +            return 0
> +
> +        sriov_admin_path = self.__helper_create_sriov_admin_path(vf_num, 'vram_quota')
> +        return int(self.read_sysfs(self.sysfs_device_path / sriov_admin_path)) if self.has_lmem() else 0
> +
> +    def set_vram_quota(self, vf_num: int, val: int) -> None:
> +        if vf_num == 0:
> +            logger.warning("PF vram_quota not available")
> +            return
> +
> +        sriov_admin_path = self.__helper_create_sriov_admin_path(vf_num, 'vram_quota')
> +        if self.has_lmem():
> +            self.write_sysfs(self.sysfs_device_path / sriov_admin_path, str(val))
> +
> +    # VF provisioning parameters (debugfs)
>       # Debugfs location: [SRIOV debugfs base path]/gtM/[pf|vfN]
>       # @vf_num: VF number (1-based) or 0 for PF
>       def get_ggtt_quota(self, vf_num: int, gt_num: int) -> int:
> @@ -159,23 +179,6 @@ class XeDriver(PfDriverInterface):
>           path = self.__helper_create_debugfs_path(vf_num, gt_num, '', 'ggtt_quota')
>           self.write_debugfs(path, str(val))
>   
> -    def get_lmem_quota(self, vf_num: int, gt_num: int) -> int:
> -        if vf_num == 0:
> -            logger.warning("PF lmem_quota not available")
> -            return 0
> -
> -        path = self.__helper_create_debugfs_path(vf_num, gt_num, '', 'lmem_quota')
> -        return int(self.read_debugfs(path)) if self.has_lmem() else 0
> -
> -    def set_lmem_quota(self, vf_num: int, gt_num: int, val: int) -> None:
> -        if vf_num == 0:
> -            logger.warning("PF lmem_quota not available")
> -            return
> -
> -        path = self.__helper_create_debugfs_path(vf_num, gt_num, '', 'lmem_quota')
> -        if self.has_lmem():
> -            self.write_debugfs(path, str(val))
> -
>       def get_contexts_quota(self, vf_num: int, gt_num: int) -> int:
>           if vf_num == 0:
>               logger.warning("PF contexts_quota not available")
> diff --git a/tools/vmtb/bench/machines/device_interface.py b/tools/vmtb/bench/machines/device_interface.py
> index 0eff493f0..76b47de03 100644
> --- a/tools/vmtb/bench/machines/device_interface.py
> +++ b/tools/vmtb/bench/machines/device_interface.py
> @@ -10,8 +10,15 @@ class DeviceInterface(abc.ABC):
>       """
>       @abc.abstractmethod
>       def bind_driver(self) -> None:
> +        """Bind driver to device."""
>           raise NotImplementedError
>   
>       @abc.abstractmethod
>       def unbind_driver(self) -> None:
> +        """Unbind driver from device."""
> +        raise NotImplementedError
> +
> +    @abc.abstractmethod
> +    def reset(self) -> None:
> +        """Reset device (trigger FLR)."""
>           raise NotImplementedError
> diff --git a/tools/vmtb/bench/machines/physical/device.py b/tools/vmtb/bench/machines/physical/device.py
> index 6c0dc4ff9..b4eebc245 100644
> --- a/tools/vmtb/bench/machines/physical/device.py
> +++ b/tools/vmtb/bench/machines/physical/device.py
> @@ -125,10 +125,14 @@ class Device(DeviceInterface):
>           return ret
>   
>       def bind_driver(self) -> None:
> -        self.driver.bind(self.pci_info.bdf)
> +        self.driver.bind()
>   
>       def unbind_driver(self) -> None:
> -        self.driver.unbind(self.pci_info.bdf)
> +        self.driver.unbind()
> +
> +    def reset(self) -> None:
> +        logger.debug("[%s] Trigger reset (PF FLR)", self.pci_info.bdf)
> +        self.driver.flr()
>   
>       def override_vf_driver(self, vf_num: int) -> str:
>           """Set VFIO as VF driver."""
> @@ -224,8 +228,8 @@ class Device(DeviceInterface):
>               self.driver.set_pf_doorbells_spare(gt_num, resources_config.pfDoorbells)
>           else:
>               if not self.is_gt_media_type(gt_num):
> +                self.driver.set_vram_quota(fn_num, resources_config.vfLmem)
>                   self.driver.set_ggtt_quota(fn_num, gt_num, resources_config.vfGgtt)
> -                self.driver.set_lmem_quota(fn_num, gt_num, resources_config.vfLmem)
>               self.driver.set_contexts_quota(fn_num, gt_num, resources_config.vfContexts)
>               self.driver.set_doorbells_quota(fn_num, gt_num, resources_config.vfDoorbells)
>   
> @@ -246,8 +250,8 @@ class Device(DeviceInterface):
>                   self.driver.set_contexts_quota(vf_num, gt_num, 0)
>                   self.driver.set_doorbells_quota(vf_num, gt_num, 0)
>                   if not self.is_gt_media_type(gt_num):
> +                    self.driver.set_vram_quota(vf_num, 0)
>                       self.driver.set_ggtt_quota(vf_num, gt_num, 0)
> -                    self.driver.set_lmem_quota(vf_num, gt_num, 0)
>   
>       def reset_provisioning(self, num_vfs: int) -> None:
>           """Clear provisioning config for a given number of VFs and restore auto provisioning mode."""
> diff --git a/tools/vmtb/bench/machines/virtual/device.py b/tools/vmtb/bench/machines/virtual/device.py
> index c838db59d..b36dbba58 100644
> --- a/tools/vmtb/bench/machines/virtual/device.py
> +++ b/tools/vmtb/bench/machines/virtual/device.py
> @@ -68,6 +68,10 @@ class VirtualDevice(DeviceInterface):
>                        self.vm.get_drm_driver_name(), self.pci_info.bdf)
>           self.driver.unbind()
>   
> +    def reset(self) -> None:
> +        logger.debug("[%s] Trigger reset (VF FLR)", self.pci_info.bdf)
> +        self.driver.flr() # VF FLR from guest's sysfs
> +
>       @property
>       def lmem_size(self) -> typing.Optional[int]:
>           if self._lmem_size is None: