From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: References: <20200304092901.2347-1-tvrtko.ursulin@linux.intel.com> From: Brian Welty Message-ID: <730444dd-9f81-55c5-e201-96540d76e436@intel.com> Date: Wed, 4 Mar 2020 09:34:56 -0800 MIME-Version: 1.0 In-Reply-To: <20200304092901.2347-1-tvrtko.ursulin@linux.intel.com> Content-Language: en-US Subject: Re: [igt-dev] [PATCH i-g-t] tests/i915/query: Do not assert engine info rsvd being zero List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Tvrtko Ursulin , igt-dev@lists.freedesktop.org Cc: Intel-gfx@lists.freedesktop.org, Tvrtko Ursulin List-ID: On 3/4/2020 1:29 AM, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > These are not input fields and i915 currently leaves them untouched. > > In the spirit of trusting the query as the authoritative source of > information, stop asserting these output only reserved fields are zero. > > This should prevent the test from auto-failing if we extend the data in > the future. > > Signed-off-by: Tvrtko Ursulin > Cc: Brian Welty Reviewed-by: Brian Welty > --- > tests/i915/i915_query.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/tests/i915/i915_query.c b/tests/i915/i915_query.c > index 71807425fbc4..e7c6fc91e32b 100644 > --- a/tests/i915/i915_query.c > +++ b/tests/i915/i915_query.c > @@ -690,11 +690,6 @@ static void engines(int fd) > engine->flags, > engine->capabilities); > > - /* MBZ fields. */ > - igt_assert_eq(engine->rsvd0, 0); > - igt_assert_eq(engine->rsvd1[0], 0); > - igt_assert_eq(engine->rsvd1[1], 0); > - > switch (engine->engine.engine_class) { > case I915_ENGINE_CLASS_RENDER: > /* Will be tested later. */ > _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev