Re: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Really do not skip on 4k displays.

[Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>]

On Friday, October 19, 2018 5:50:01 AM PDT Maarten Lankhorst wrote:

The test sets DONT_ASSERT_FEATURE_STATUS, why does it skip?

> The previous fixes to kms_frontbuffer_tracking fixed the sharedfb tests,
> but the stridechange test still creates its own fb. Use a smaller fb in
Please provide some context to what the max allowed stride is.

> order to test a stride change, without ending up with an excessive stride.
> 
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
>  tests/kms_frontbuffer_tracking.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
> index bf4a68ff2bde..a4f0d9f72aab 100644
> --- a/tests/kms_frontbuffer_tracking.c
> +++ b/tests/kms_frontbuffer_tracking.c
> @@ -2923,7 +2923,7 @@ static void stridechange_subtest(const struct test_mode *t)
>  
>  	old_fb = params->primary.fb;
>  
> -	create_fb(t->format, params->primary.fb->width + 512, params->primary.fb->height,
> +	create_fb(t->format, params->primary.fb->width + 64, params->primary.fb->height,

I think we can make this a bit more generic. How about defining the min of the max stride that fbc
tolerates across all platforms and using that? 

-DK

>  		  opt.tiling, t->plane, &new_fb);
>  	fill_fb(&new_fb, COLOR_PRIM_BG);
>  
> 




_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev