Re: [igt-dev] [PATCH i-g-t 1/3] tests/kms_plane_scaling: Prep work

[Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>]

On 15.2.2023 18.59, Swati Sharma wrote:
> struct can be reused to add more test cases.
> 
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
>   tests/kms_plane_scaling.c | 18 ++++++++++--------
>   1 file changed, 10 insertions(+), 8 deletions(-)
> 
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 4a04f42a0..382d199e0 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -42,6 +42,15 @@ typedef struct {
>   	bool extended;
>   } data_t;
>   
> +struct invalid_paramtests {
> +	const char *testname;
> +	uint32_t planesize[2];
> +	struct {
> +		enum igt_atomic_plane_properties prop;
> +		uint32_t value;
> +	} params[8];
> +};
> +
>   const struct {
>   	const char * const describe;
>   	const char * const name;
> @@ -827,14 +836,7 @@ static void invalid_parameter_tests(data_t *d)
>   	igt_plane_t *plane;
>   	int rval;
>   
> -	const struct {
> -		const char *testname;
> -		uint32_t planesize[2];
> -		struct {
> -			enum igt_atomic_plane_properties prop;
> -			uint32_t value;
> -		} params[8];
> -	} paramtests[] = {
> +	static const struct invalid_paramtests paramtests[2] = {

"static const struct invalid_paramtests paramtests[]" would be better 
here, ie. not declaring here how long is the list of tests

>   		{
>   			.testname = "less-than-1-height-src",
>   			.planesize = {256, 8},