From: Jani Nikula <jani.nikula@intel.com>
To: Melissa Wen <mwen@igalia.com>,
Petri Latvala <adrinael@adrinael.net>,
Arkadiusz Hiler <arek@hiler.eu>,
Kamil Konieczny <kamil.konieczny@linux.intel.com>,
Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>,
Bhanuprakash Modem <bhanuprakash.modem@gmail.com>,
Ashutosh Dixit <ashutosh.dixit@intel.com>,
Karthik B S <karthik.b.s@intel.com>
Cc: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>,
Alex Hung <alex.hung@amd.com>,
Swati Sharma <swati2.sharma@intel.com>,
John Harrison <John.Harrison@Igalia.com>,
Rodrigo Siqueira <siqueira@igalia.com>,
Simon Ser <contact@emersion.fr>, Xaver Hugl <xaver.hugl@kde.org>,
Harry Wentland <harry.wentland@amd.com>,
Uma Shankar <uma.shankar@intel.com>,
igt-dev@lists.freedesktop.org, kernel-dev@igalia.com
Subject: Re: [PATCH i-g-t v4 8/8] lib/igt_kms: add macros to iterate color pipelines and colorops
Date: Thu, 03 Sep 2026 13:46:40 +0300 [thread overview]
Message-ID: <735141716afc883efc30e245414243905aa768cc@intel.com> (raw)
In-Reply-To: <e5b8ae16-8e8c-4c78-a92b-96223a386e6e@igalia.com>
On Wed, 02 Sep 2026, Melissa Wen <mwen@igalia.com> wrote:
> I just sent a v5 with different changes :)
> https://lore.kernel.org/igt-dev/20260902180016.303482-1-mwen@igalia.com/
>
> I tried to avoid the loop variable, but the issue is color_pipelines[] is an
> array of pointers, not an array of structs as the other cases you mentioned.
> So &(plane)->color_pipelines[0] is an igt_colorop_t** and the pointer walk
> means a double pointer iterator, and even if I do it, the two macros become
> inconsistent so I couldn't combine them anymore.
>
> What I did was using igt_unique() to guard the macro iterator in any
> expansion
> context, as in for_each_format_and_modifier and related macros.
>
> Regarding the igt_colorop_next() comments, I started to store the next
> pointer in the igt colorop struct as this is immutable, and it makes
> most of problems disappear.
>
> Does it sound sensible?
Yes, thanks for doing this. I had one nitpick, but the overall approach
seems fine.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2026-09-03 10:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 15:07 [PATCH i-g-t v4 0/8] tests/kms_colorop: don't request colorop updates indefinitely and other improvements Melissa Wen
2026-08-17 15:07 ` [PATCH i-g-t v4 1/8] lib/igt_kms: clear colorop-changed flag after commit Melissa Wen
2026-08-17 15:07 ` [PATCH i-g-t v4 2/8] tests/kms_colorop_helper: only check if a given enum value exists Melissa Wen
2026-08-17 15:07 ` [PATCH i-g-t v4 3/8] tests/kms_properties: don't check colorop if no plane color pipeline prop Melissa Wen
2026-08-17 15:07 ` [PATCH i-g-t v4 4/8] tests/kms_properties: give non-primary planes their own fb Melissa Wen
2026-08-17 15:07 ` [PATCH i-g-t v4 5/8] lib/igt_kms: extend igt_plane_set_color_pipeline to accept Bypass Melissa Wen
2026-08-17 15:07 ` [PATCH i-g-t v4 6/8] tests/kms_properties: check colorop properties on active color pipelines Melissa Wen
2026-08-17 15:07 ` [PATCH i-g-t v4 7/8] tests/kms_color_pipeline: skip if not an Intel device Melissa Wen
2026-08-17 15:07 ` [PATCH i-g-t v4 8/8] lib/igt_kms: add macros to iterate color pipelines and colorops Melissa Wen
2026-08-17 15:57 ` Jani Nikula
2026-08-18 17:05 ` Melissa Wen
2026-09-02 18:11 ` Melissa Wen
2026-09-03 10:46 ` Jani Nikula [this message]
2026-08-17 21:28 ` ✓ Xe.CI.BAT: success for tests/kms_colorop: don't request colorop updates indefinitely and other improvements Patchwork
2026-08-17 21:28 ` ✓ i915.CI.BAT: " Patchwork
2026-08-18 0:11 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-08-18 10:32 ` ✗ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=735141716afc883efc30e245414243905aa768cc@intel.com \
--to=jani.nikula@intel.com \
--cc=John.Harrison@Igalia.com \
--cc=adrinael@adrinael.net \
--cc=alex.hung@amd.com \
--cc=arek@hiler.eu \
--cc=ashutosh.dixit@intel.com \
--cc=bhanuprakash.modem@gmail.com \
--cc=chaitanya.kumar.borah@intel.com \
--cc=contact@emersion.fr \
--cc=harry.wentland@amd.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
--cc=kamil.konieczny@linux.intel.com \
--cc=karthik.b.s@intel.com \
--cc=kernel-dev@igalia.com \
--cc=mwen@igalia.com \
--cc=siqueira@igalia.com \
--cc=swati2.sharma@intel.com \
--cc=uma.shankar@intel.com \
--cc=xaver.hugl@kde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox