Re: [PATCH i-g-t] tests/kms_vrr: Set VRR_ENABLED property as false for non-VRR panel as well

["Hogander, Jouni" <jouni.hogander@intel.com>]

On Fri, 2024-11-15 at 11:36 +0530, Sharma, Swati2 wrote:
> Hi Jouni,
> 
> Can we add Closes tag?

I couldn't find related ticket in gitlab.

> 
> Rest LGTM
> Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

Thank you Swati for checking my patch. This is now pushed to master.

BR,

Jouni Högander

> 
> On 14-11-2024 04:44 pm, Jouni Högander wrote:
> > Currently we are facing problems with PSR testcases after running
> > negative-basic subtest. These are because VRR_ENABLED property is
> > left
> > enabled by negative-basic subtest and having VRR enabled disables
> > PSR
> > currently. Fix this by setting the property as false for non-VRR
> > panel as
> > well.
> > 
> > Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> > ---
> >   tests/kms_vrr.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c
> > index d0db954fa..830fd8ba8 100644
> > --- a/tests/kms_vrr.c
> > +++ b/tests/kms_vrr.c
> > @@ -862,8 +862,7 @@ test_cmrr(data_t *data, enum pipe pipe,
> > igt_output_t *output, uint32_t flags)
> >   
> >   static void test_cleanup(data_t *data, enum pipe pipe,
> > igt_output_t *output)
> >   {
> > -       if (vrr_capable(output))
> > -               igt_pipe_set_prop_value(&data->display, pipe,
> > IGT_CRTC_VRR_ENABLED, false);
> > +       igt_pipe_set_prop_value(&data->display, pipe,
> > IGT_CRTC_VRR_ENABLED, false);
> >   
> >         igt_plane_set_fb(data->primary, NULL);
> >         igt_output_set_pipe(output, PIPE_NONE);