Re: [igt-dev] [PATCH i-g-t] lib: Include the size in the error message for mlock

[Antonio Argenziano <antonio.argenziano@intel.com>]

On 22/01/19 10:17, Chris Wilson wrote:
> Knowing how much we tried to allocate would be useful if one should need
> to debug why it failed.
> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=109439
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

LGTM.

Reviewed-by: Antonio Argenziano <antonio.argenziano@intel.com>

> ---
>   lib/igt_aux.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/igt_aux.c b/lib/igt_aux.c
> index 1250d5c5f..2e2d552b5 100644
> --- a/lib/igt_aux.c
> +++ b/lib/igt_aux.c
> @@ -1080,14 +1080,14 @@ void igt_lock_mem(size_t size)
>   
>   	locked_mem = malloc(locked_size);
>   	igt_require_f(locked_mem,
> -		      "Could not allocate enough memory to lock.\n");
> +		      "Could not malloc %zdMiB for locking.\n", size);
>   
>   	/* write into each page to ensure it is allocated */
>   	for (i = 0; i < locked_size; i += pagesize)
>   		locked_mem[i] = i;
>   
>   	ret = mlock(locked_mem, locked_size);
> -	igt_assert_f(ret == 0, "Could not lock memory into RAM.\n");
> +	igt_assert_f(ret == 0, "Could not mlock %zdMiB.\n", size);
>   }
>   
>   /**
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev