From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5AEB510E393 for ; Wed, 4 Oct 2023 16:43:52 +0000 (UTC) Message-ID: <73b5370c-a61b-46e7-8041-2809ad8c3f50@linux.intel.com> Date: Wed, 4 Oct 2023 18:41:50 +0200 MIME-Version: 1.0 Content-Language: en-US To: Juha-Pekka Heikkila , igt-dev@lists.freedesktop.org References: <20231004134722.319334-1-juhapekka.heikkila@gmail.com> From: Maarten Lankhorst In-Reply-To: <20231004134722.319334-1-juhapekka.heikkila@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [igt-dev] [PATCH i-g-t] lib/igt_fb: on Xe driver take into account adlp with no extended block copy List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Hey, Patch looks good, but right below HAS_FLATCCS is used instead. Could you fix that too for consistency? With that amended, Reviewed-by: Maarten Lankhorst Den 2023-10-04 kl. 15:47, skrev Juha-Pekka Heikkila: > With Xe add check to not use extended block copy if it is not available. > > Signed-off-by: Juha-Pekka Heikkila > --- > lib/igt_fb.c | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/lib/igt_fb.c b/lib/igt_fb.c > index f0c0681ab..54a66eb6a 100644 > --- a/lib/igt_fb.c > +++ b/lib/igt_fb.c > @@ -2920,17 +2920,19 @@ static void blitcopy(const struct igt_fb *dst_fb, > blt_set_copy_object(&blt.src, src); > blt_set_copy_object(&blt.dst, dst); > > - blt_set_object_ext(&ext.src, > - blt_compression_format(&blt, src_fb), > - src_fb->width, src_fb->height, > - SURFACE_TYPE_2D); > + if (blt_uses_extended_block_copy(src_fb->fd)) { > + blt_set_object_ext(&ext.src, > + blt_compression_format(&blt, src_fb), > + src_fb->width, src_fb->height, > + SURFACE_TYPE_2D); > > - blt_set_object_ext(&ext.dst, > - blt_compression_format(&blt, dst_fb), > - dst_fb->width, dst_fb->height, > - SURFACE_TYPE_2D); > + blt_set_object_ext(&ext.dst, > + blt_compression_format(&blt, dst_fb), > + dst_fb->width, dst_fb->height, > + SURFACE_TYPE_2D); > > - pext = &ext; > + pext = &ext; > + } > > blt_set_batch(&blt.bb, xe_bb, bb_size, mem_region); >