Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Karthik B S <karthik.b.s@intel.com>
To: Jeevan B <jeevan.b@intel.com>, <igt-dev@lists.freedesktop.org>
Cc: <kunal1.joshi@intel.com>
Subject: Re: [PATCH i-g-t 2/2] Revert "tests/kms_display_modes: Skip test if joiner display is connected"
Date: Thu, 17 Apr 2025 11:11:47 +0530	[thread overview]
Message-ID: <740538e0-c4f9-45e9-953a-319326bc11ed@intel.com> (raw)
In-Reply-To: <20250403104149.2033579-3-jeevan.b@intel.com>


On 4/3/2025 4:11 PM, Jeevan B wrote:
> bigjoiner realted checks should be handled in igt_check_bigjoiner_support
> which is now added so removing the checks which is no more valid.

Nit: Although the commit message conveys the required info, please make 
it more readable.

With this,

Reviewed-by: Karthik B S <karthik.b.s@intel.com>

>
> This reverts commit 5f7cde6a98783c97649bdb3879bc016b3bf38297
>
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> ---
>   tests/kms_display_modes.c | 9 ---------
>   1 file changed, 9 deletions(-)
>
> diff --git a/tests/kms_display_modes.c b/tests/kms_display_modes.c
> index 588820170..d53b83a86 100644
> --- a/tests/kms_display_modes.c
> +++ b/tests/kms_display_modes.c
> @@ -184,11 +184,6 @@ static void run_extendedmode_test(data_t *data) {
>   	for_each_pipe(display, pipe1) {
>   		for_each_valid_output_on_pipe(display, pipe1, output1) {
>   
> -			if (is_joiner_mode(data->drm_fd, output1)) {
> -				igt_info("Skipping joiner output %s", output1->name);
> -				continue;
> -			}
> -
>   			for_each_pipe(display, pipe2) {
>   				if (pipe1 == pipe2)
>   					continue;
> @@ -238,10 +233,6 @@ igt_main
>   		igt_display_require_output(&data.display);
>   
>   		for_each_connected_output(&data.display, output) {
> -			if (is_joiner_mode(data.drm_fd, output)) {
> -				igt_info("Skipping joiner output %s", output->name);
> -				continue;
> -			}
>   			data.mst_output[count++] = output;
>   			if (output_is_dp_mst(&data, output, dp_mst_outputs))
>   				dp_mst_outputs++;

  reply	other threads:[~2025-04-17  5:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-03 10:41 [PATCH i-g-t 0/2] Fix display_mode test for joiner output Jeevan B
2025-04-03 10:41 ` [PATCH i-g-t 1/2] lib/igt_kms: Prevent bigjoiner assignment if next pipe is already in use Jeevan B
2025-04-17  5:40   ` Karthik B S
2025-04-03 10:41 ` [PATCH i-g-t 2/2] Revert "tests/kms_display_modes: Skip test if joiner display is connected" Jeevan B
2025-04-17  5:41   ` Karthik B S [this message]
2025-04-03 14:57 ` ✓ i915.CI.BAT: success for Fix display_mode test for joiner output Patchwork
2025-04-03 15:05 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-04-03 17:39 ` ✓ i915.CI.Full: success " Patchwork
2025-04-03 18:46 ` ✗ Xe.CI.Full: failure " Patchwork
2025-04-03 20:49 ` ✓ i915.CI.BAT: success for Fix display_mode test for joiner output (rev2) Patchwork
2025-04-03 22:01 ` ✓ Xe.CI.BAT: " Patchwork
2025-04-04  0:17 ` ✗ i915.CI.Full: failure " Patchwork
2025-04-04  5:51 ` ✓ Xe.CI.Full: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=740538e0-c4f9-45e9-953a-319326bc11ed@intel.com \
    --to=karthik.b.s@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jeevan.b@intel.com \
    --cc=kunal1.joshi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox