Re: [igt-dev] [i-g-t 4/5] tests/kms_force_connector_basic: Add XE support

["Modem, Bhanuprakash" <bhanuprakash.modem@intel.com>]

Hi Zbigniew,

On Fri-24-03-2023 12:36 am, Zbigniew Kempczyński wrote:
> On Mon, Mar 20, 2023 at 03:30:16PM +0530, Bhanuprakash Modem wrote:
>> Add XE driver support for kms tests.
>>
>> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>> ---
>>   tests/kms_force_connector_basic.c | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/kms_force_connector_basic.c b/tests/kms_force_connector_basic.c
>> index 4ff1efe3b..6a13fe4ed 100644
>> --- a/tests/kms_force_connector_basic.c
>> +++ b/tests/kms_force_connector_basic.c
>> @@ -53,7 +53,9 @@ static void reset_connectors(void)
>>   		drmModeFreeConnector(connector);
>>   	}
>>   
>> -	igt_set_module_param_int(drm_fd, "load_detect_test", 0);
>> +	/* FIXME: load_detect_test is not found in XE. */
>> +	if (is_i915_device(drm_fd))
>> +		igt_set_module_param_int(drm_fd, "load_detect_test", 0);
> 
> What's the plan of addressing 'load_detect_test' param? If there will be
> none I think "FIXME" should be get rid of here.

Thanks for the review, Fixed in next rev.

- Bhanu

> 
> --
> Zbigniew
> 
>>   
>>   	close(drm_fd);
>>   }
>> -- 
>> 2.40.0
>>