Re: [igt-dev] [PATCH i-g-t 2/2] lib/igt_fb: on xe driver switch from rendercopy to blitcopy

["Joshi, Kunal1" <kunal1.joshi@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1147 bytes --]


On 7/20/2023 3:32 PM, Zbigniew Kempczyński wrote:
> On Tue, Jul 18, 2023 at 05:44:43PM +0530, Kunal Joshi wrote:
>> on xe driver use blitcopy for everything where otherwise would
>> use rendercopy.
>>
>> Signed-off-by: Juha-Pekka Heikkila<juhapekka.heikkila@gmail.com>
>> ---
>>   lib/igt_fb.c | 8 +++-----
>>   1 file changed, 3 insertions(+), 5 deletions(-)
>>
>> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
>> index 6ce4b735a..f4bc800fe 100644
>> --- a/lib/igt_fb.c
>> +++ b/lib/igt_fb.c
>> @@ -2529,7 +2529,7 @@ static bool use_enginecopy(const struct igt_fb *fb)
>>   	if (!is_intel_device(fb->fd))
>>   		return false;
>>   
>> -	if (!is_xe_device(fb->fd) && blitter_ok(fb))
>> +	if (blitter_ok(fb))
>>   		return false;
> I stared to this and for me it looks we disable rendercopy at all
> for i915 as well for xe even if rendercopy is same for i915 and xe
> (intel-bb should handle this).
>
> --
> Zbigniew
>
Hello Zbigniew,

Blitter is preferred over render copy for perf/power and render copy is  
preferred for feature.
JP's changes are considering that fact. With this info does this patch 
look good?

Thanks and Regards
Kunal Joshi


[-- Attachment #2: Type: text/html, Size: 2046 bytes --]