From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-SN1-obe.outbound.protection.outlook.com (mail-eopbgr700057.outbound.protection.outlook.com [40.107.70.57]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4CFA16ECE9 for ; Thu, 31 Jan 2019 14:39:01 +0000 (UTC) From: "Kazlauskas, Nicholas" Date: Thu, 31 Jan 2019 14:38:59 +0000 Message-ID: <74fc3b5f-14d6-bfe6-7f1d-92bdc1401c6e@amd.com> References: <20190131085802.9703-1-maarten.lankhorst@linux.intel.com> <20190131102628.GJ4038@platvala-desk.ger.corp.intel.com> In-Reply-To: Content-Language: en-US Content-ID: <265DE6C8E108FD4F81C24BFDADEFDFF6@namprd12.prod.outlook.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t] lib/igt_kms: Clear all non-atomic properties in legacy/universal commit correctly. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Maarten Lankhorst , "igt-dev@lists.freedesktop.org" , Petri Latvala List-ID: T24gMS8zMS8xOSA3OjA1IEFNLCBNYWFydGVuIExhbmtob3JzdCB3cm90ZToNCj4gT3AgMzEtMDEt MjAxOSBvbSAxMToyNiBzY2hyZWVmIFBldHJpIExhdHZhbGE6DQo+PiBPbiBUaHUsIEphbiAzMSwg MjAxOSBhdCAwOTo1ODowMkFNICswMTAwLCBNYWFydGVuIExhbmtob3JzdCB3cm90ZToNCj4+PiBX ZSB1c2VkIHRvIGFkZCB0aGVtIGFsbCAxIGJ5IDEsIGJ1dCB3ZSByZWFsbHkgb25seSBjYXJlIGFi b3V0IG5vdA0KPj4+IGhhbmRsaW5nIGEgZmV3Lg0KPj4+DQo+Pj4gT25seSBza2lwIHVuc2V0dGlu ZyBhbGwgYXRvbWljIHByb3BlcnRpZXMsIGluc3RlYWQgb2YgaGFuZGxpbmcgaXQNCj4+PiB0aHJv dWdoIGEgd2hpdGVsaXN0Lg0KPj4+DQo+Pj4gVGhpcyBmaXhlcyBrbXNfYnVzeSwgd2hpY2ggd2Fz IHVwZGF0aW5nIHRoZSBWUlIgaGludCwgZXZlbiB0aG91Z2gNCj4+PiB3ZSBhbHJlYWR5IHVuc2V0 IGl0IGluIHRoZSBsZWdhY3kgcGF0aC4NCj4+Pg0KPj4+IENjOiBOaWNob2xhcyBLYXpsYXVza2Fz IDxua2F6bGF1c0BhbWQuY29tPg0KPj4+IENjOiBIYXJyeSBXZW50bGFuZCA8aGFycnkud2VudGxh bmRAYW1kLmNvbT4NCj4+PiBDYzogTGVvIExpIDxzdW5wZW5nLmxpQGFtZC5jb20+DQo+Pj4gQnVn emlsbGE6IGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTQ5 MA0KPj4+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3Jz dEBsaW51eC5pbnRlbC5jb20+DQoNClJldmlld2VkLWJ5OiBOaWNob2xhcyBLYXpsYXVza2FzIDxu aWNob2xhcy5rYXpsYXVza2FzQGFtZC5jb20+DQoNClRoaXMgaXMgYSBtdWNoIG1vcmUgZWxlZ2Fu dCBzb2x1dGlvbiB0byBqdXN0IGNsZWFyaW5nIFZSUl9FTkFCTEVEIGJ5IA0KaXRzZWxmIGxpa2Ug SSB3YXMgZG9pbmcgaW4gbXkgb3RoZXIgcGF0Y2guIEFsc28gaGVscHMgZ3VhcmQgYWdhaW5zdCAN CmZvcmdldHRpbmcgdG8gY2xlYXIgbmV3IHByb3BlcnRpZXMgaW4gdGhlIGZ1dHVyZSAobGlrZSBt eSBvcmlnaW5hbCBwYXRjaCANCmRpZCkuDQoNCkknbGwgdXBkYXRlIG15ICJsaWIvaWd0X2ttczog RG9uJ3QgcmVzZXQgVlJSX0VOQUJMRUQgb24gZXZlcnkgY29tbWl0IiANCmJhc2VkIG9uIHRoaXMg Y29tbWl0LiBUaGFua3MhDQoNCj4+PiAtLS0NCj4+PiAgIGxpYi9pZ3Rfa21zLmMgfCA3ICsrKy0t LS0NCj4+PiAgIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0p DQo+Pj4NCj4+PiBkaWZmIC0tZ2l0IGEvbGliL2lndF9rbXMuYyBiL2xpYi9pZ3Rfa21zLmMNCj4+ PiBpbmRleCA1OGYzMjkxMWQ5OTkuLjFmOThiMjZmY2Q3OSAxMDA2NDQNCj4+PiAtLS0gYS9saWIv aWd0X2ttcy5jDQo+Pj4gKysrIGIvbGliL2lndF9rbXMuYw0KPj4+IEBAIC0zMjk4LDEwICszMjk4 LDkgQEAgZGlzcGxheV9jb21taXRfY2hhbmdlZChpZ3RfZGlzcGxheV90ICpkaXNwbGF5LCBlbnVt IGlndF9jb21taXRfc3R5bGUgcykNCj4+PiAgIAkJCXBpcGVfb2JqLT52YWx1ZXNbSUdUX0NSVENf T1VUX0ZFTkNFX1BUUl0gPSAwOw0KPj4+ICAgCQkJcGlwZV9vYmotPmNoYW5nZWQgPSAwOw0KPj4+ ICAgCQl9IGVsc2Ugew0KPj4+IC0JCQlpZ3RfcGlwZV9vYmpfY2xlYXJfcHJvcF9jaGFuZ2VkKHBp cGVfb2JqLCBJR1RfQ1JUQ19CQUNLR1JPVU5EKTsNCj4+PiAtCQkJaWd0X3BpcGVfb2JqX2NsZWFy X3Byb3BfY2hhbmdlZChwaXBlX29iaiwgSUdUX0NSVENfQ1RNKTsNCj4+PiAtCQkJaWd0X3BpcGVf b2JqX2NsZWFyX3Byb3BfY2hhbmdlZChwaXBlX29iaiwgSUdUX0NSVENfREVHQU1NQV9MVVQpOw0K Pj4+IC0JCQlpZ3RfcGlwZV9vYmpfY2xlYXJfcHJvcF9jaGFuZ2VkKHBpcGVfb2JqLCBJR1RfQ1JU Q19HQU1NQV9MVVQpOw0KPj4+ICsJCQlmb3IgKGkgPSAwOyBpIDwgSUdUX05VTV9DUlRDX1BST1BT OyBpKyspDQo+Pj4gKwkJCQlpZiAoIWlzX2F0b21pY19wcm9wKGkpKQ0KPj4+ICsJCQkJCWlndF9w aXBlX29ial9jbGVhcl9wcm9wX2NoYW5nZWQocGlwZV9vYmosIGkpOw0KPj4NCj4+IERvZXMgSUdU X0NSVENfVlJSX0VOQUJMRUQgbmVlZCB0byBiZSBhZGRlZCB0byBpc19hdG9taWNfcHJvcD8NCj4g DQo+IFRoZSBsZWdhY3kgcGF0aDoNCj4gLSBQZXJmb3JtcyBkcm1Nb2RlU2V0Q3J0YyBvbiB0aGUg cHJpbWFyeSBwbGFuZSB0byB0cmlnZ2VyIGEgbW9kZXNldCBhbmQgY29ubmVjdG9yIGFzc2lnbm1l bnRzDQo+IC0gVXNlcyBkcm1Nb2RlU2V0Q3Vyc29yL2RybU1vZGVNb3ZlQ3Vyc29yIHRvIG1vdmUg dGhlIGN1cnNvciBwbGFuZQ0KPiAtIFVzZXMgZHJtTW9kZVNldFBsYW5lIG9uIG90aGVyIHBsYW5l cy4NCj4gLSBVc2VzIGRybU1vZGVDb25uZWN0b3JTZXRQcm9wZXJ0eSB0byBzZXQgY29ubmVjdG9y IHByb3BlcnRpZXMuDQo+IC0gQ2FsbHMgZHJtTW9kZU9iamVjdFNldFByb3BlcnR5IHRvIHVwZGF0 ZSBhbnkgbm9uLWF0b21pYyBjcnRjIHByb3BlcnRpZXMuIFByb2JhYmx5IGdhbW1hL2V0YyBhcyB3 ZWxsLg0KPiBQcmltYXJ5IGFuZCBjdXJzb3IgcHJvcGVydGllcyBhcmUgbW9zdGx5IGlnbm9yZWQs IGV4Y2VwdCB3aXRoIHdoYXQgY2FuIGJlIHNldCB0aHJvdWdoIHNldGN1cnNvci9zZXRjcnRjLg0K PiANCj4gVGhlIHVuaXZlcnNhbCBwYXRoOg0KPiAtIFVzZXMgU2V0UGxhbmUgb24gYWxsIHBsYW5l cy4NCj4gLSBDYWxscyBkcm1Nb2RlT2JqZWN0U2V0UHJvcGVydHkgZm9yIGFsbCBub3QgaWdub3Jl ZCBwcm9wZXJ0aWVzIG9uIGVhY2ggcGxhbmUvY29ubmVjdG9yL2NydGMuDQo+IC0gQ2FuJ3QgZG8g bW9kZXNldHMuDQo+IA0KPiBUaGUgYXRvbWljIHBhdGg6DQo+IC0gRG9lcyBhIHNpbmdsZSBhdG9t aWMgY29tbWl0LCB3aXRoIGFsbCBjaGFuZ2VkIHByb3BlcnRpZXMgYW5kIHRoZWlyIG5ldyB2YWx1 ZXMuIEFsbCBvZiB0aGUgYWJvdmUgYW5kIG1vcmUgKGluL291dCBmZW5jZSBoYW5kbGluZykuLg0K PiANCj4gRXZlbiBpZiBpdCdzIHN0cmljdGx5IHNwZWFraW5nIGFuIGF0b21pYyBwcm9wZXJ0eSwg dGhlIGZhY3Qgd2UgY2xlYXIgaXQgaW4gaWd0X3BpcGVfcmVmcmVzaCgpDQo+IG1lYW5zIHdlIGhh dmUgdG8gbWFrZSBzdXJlIHRoYXQgdGVzdHMga2VlcCBydW5uaW5nLCBhbmQgd2UgaGF2ZSB0byBj bGVhciB0aGUgZmxhZyBpbiBpZ3RfZGlzcGxheV9jb21taXQoKQ0KPiBiZWNhdXNlIG90aGVyd2lz ZSBldmVuIG1vcmUgdGhpbmdzIGJyZWFrLiA6KQ0KPiANCj4gUHJvYmFibHkgYmVzdCB0byBvbmx5 IGtlZXAgdGhpbmdzIHdlIGFic29sdXRlbHkgY2FuJ3QgcmVhc29uYWJseSBhbm90aGVyIHdheSB0 aGFuIGF0b21pYyBpbiBpc19hdG9taWMuDQo+IA0KPj4gLi4uDQo+Pg0KPj4gTm8sIHRoYXQncyBu b3QgYSAiaXMgdGhpcyBhbiBhdG9taWMtb25seSBwcm9wZXJ0eSIsIGlzIGl0Pw0KDQpJdCdzIGEg cHJvcGVydHkgdGhhdCdzIG9ubHkgZXhwb3NlZCBvbiBhdG9taWMgZHJpdmVycyBidXQgaXNuJ3Qg bWFya2VkIA0KYXMgYXRvbWljIG9ubHkgc28gdGhhdCBsZWdhY3kgdXNlcnNwYWNlIGNvdWxkIHN0 aWxsIHVzZSBpdC4gSXQgc2hvdWxkbid0IA0KYmUgaW4gdGhlIGlzX2F0b21pY19wcm9wIGxpc3Qg YXQgbGVhc3QuDQoNCj4+DQo+Pg0KPj4gQW55d2F5LCB0aGUgZWZmZWN0IG1hdGNoZXMgdGhlIHNl Y29uZCBjaHVuayBvZiBOaWNob2xhcydzIHBhdGNoLg0KPj4NCj4+DQo+PiBSZXZpZXdlZC1ieTog UGV0cmkgTGF0dmFsYSA8cGV0cmkubGF0dmFsYUBpbnRlbC5jb20+DQo+Pg0KPj4gVGhlcmUncyBz b21lIHF1ZXVlIGluIHNoYXJkcyBzbyBzdGFuZCBieSBhIGNvdXBsZSBvZiBob3VycyBmb3IgdGhl aXIgcmVzdWx0cyBiZWZvcmUgbWVyZ2luZy4NCj4+DQo+Pg0KPj4NCj4+PiAgIA0KPj4+ICAgCQkJ aWYgKHMgIT0gQ09NTUlUX1VOSVZFUlNBTCkgew0KPj4+ICAgCQkJCWlndF9waXBlX29ial9jbGVh cl9wcm9wX2NoYW5nZWQocGlwZV9vYmosIElHVF9DUlRDX01PREVfSUQpOw0KPj4+IC0tIA0KPj4+ IDIuMjAuMQ0KPj4+DQo+Pj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18NCj4+PiBpZ3QtZGV2IG1haWxpbmcgbGlzdA0KPj4+IGlndC1kZXZAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnDQo+Pj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pZ3QtZGV2DQo+IA0KPiANCg0KTmljaG9sYXMgS2F6bGF1c2thcw0KX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxp c3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2Cg==