From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org,
Petri Latvala <petri.latvala@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t v2] i915/gem_engine_topology: Generate engine names based on class
Date: Wed, 22 Jan 2020 15:16:05 +0000 [thread overview]
Message-ID: <754810cf-420a-4920-dae3-8bcbf2e267a9@linux.intel.com> (raw)
In-Reply-To: <dcadd92b-5f5b-ac99-d6c4-ed9beb19f6ca@linux.intel.com>
On 22/01/2020 14:53, Tvrtko Ursulin wrote:
>
> On 22/01/2020 14:46, Chris Wilson wrote:
>> Quoting Tvrtko Ursulin (2020-01-22 14:40:28)
>>> static void init_engine(struct intel_execution_engine2 *e2,
>>> int class, int instance, uint64_t flags)
>>> {
>>> - const struct intel_execution_engine2 *__e2;
>>> - static const char *unknown_name = "unknown",
>>> - *virtual_name = "virtual";
>>> + int ret;
>>> e2->class = class;
>>> e2->instance = instance;
>>> - e2->flags = flags;
>>> /* engine is a virtual engine */
>>> if (class == I915_ENGINE_CLASS_INVALID &&
>>> instance == I915_ENGINE_CLASS_INVALID_VIRTUAL) {
>>
>> Can this ever match? instance is 65534 and INVALID_VIRTUAL is -2.
>> int class/instance should be u16?
>
> Yeah, no it can't ever match. I'll have a look how easy to change it all
> to struct i915_engine_class_instance.
Too much churn. I did simple uint16_t here and in struct
intel_execution_engine2 as a follow up patch to this one.
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-01-22 15:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 10:10 [igt-dev] [PATCH i-g-t] i915/gem_engine_topology: Generate engine names based on class Tvrtko Ursulin
2020-01-22 10:15 ` Tvrtko Ursulin
2020-01-22 10:33 ` Petri Latvala
2020-01-22 14:40 ` [igt-dev] [PATCH i-g-t v2] " Tvrtko Ursulin
2020-01-22 14:46 ` Chris Wilson
2020-01-22 14:53 ` Tvrtko Ursulin
2020-01-22 15:16 ` Tvrtko Ursulin [this message]
2020-01-22 16:00 ` [igt-dev] ✗ Fi.CI.BAT: failure for i915/gem_engine_topology: Generate engine names based on class (rev2) Patchwork
2020-01-23 13:50 ` [igt-dev] ✗ GitLab.Pipeline: warning for i915/gem_engine_topology: Generate engine names based on class Patchwork
2020-01-23 13:51 ` [igt-dev] ✗ GitLab.Pipeline: warning for i915/gem_engine_topology: Generate engine names based on class (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=754810cf-420a-4920-dae3-8bcbf2e267a9@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
--cc=tvrtko.ursulin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox