From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: Swati Sharma <swati2.sharma@intel.com>, igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH] tests/kms_rotation_crc: enable bad-pixel-format subtest for gen11+
Date: Mon, 20 May 2019 14:04:38 +0300 [thread overview]
Message-ID: <762fdb9a-d9f8-727d-d6eb-7267120550fd@gmail.com> (raw)
In-Reply-To: <1558345682-10423-1-git-send-email-swati2.sharma@intel.com>
Look ok to me.
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
On 20.5.2019 12.48, Swati Sharma wrote:
> Currently, subtest bad-pixel-format is getting skipped for gen11.
> To enable this for gen11+ platforms, added override_fmt - which could
> be any gen11+ format not allowing 90/270 degree rotation like C8,
> Y210, Y212, Y216, etc.
>
> DRM_FORMAT_C8 fmt needs to be enabled for IGT, so this can't be used
> yet. So, I have used DRM_FORMAT_Y212 which is enabled in IGT.
>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
> tests/kms_rotation_crc.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> index fc995d0..fe40481 100644
> --- a/tests/kms_rotation_crc.c
> +++ b/tests/kms_rotation_crc.c
> @@ -805,14 +805,13 @@ igt_main
> data.pos_y = 0;
>
> igt_subtest_f("bad-pixel-format") {
> - /*
> - * gen11 enables RGB565 rotation for 90/270 degrees.
> - * DRM_FORMAT_C8 fmt need to be enabled for IGT if want to run
> - * this test on gen11 and later.
> - */
> - igt_require(gen >= 9 && gen < 11);
> + /* gen11 enables RGB565 rotation for 90/270 degrees.
> + * so apart from this, any other gen11+ pixel format
> + * can be used which doesn't support 90/270 degree
> + * rotation */
> + igt_require(gen >= 9);
> data.rotation = IGT_ROTATION_90;
> - data.override_fmt = DRM_FORMAT_RGB565;
> + data.override_fmt = gen < 11 ? DRM_FORMAT_RGB565 : DRM_FORMAT_Y212;
> test_plane_rotation(&data, DRM_PLANE_TYPE_PRIMARY, true);
> }
> data.override_fmt = 0;
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-05-20 11:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 9:48 [igt-dev] [PATCH] tests/kms_rotation_crc: enable bad-pixel-format subtest for gen11+ Swati Sharma
2019-05-20 10:49 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2019-05-20 10:59 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2019-05-20 11:04 ` Juha-Pekka Heikkila [this message]
2019-06-07 10:11 ` [igt-dev] [PATCH] " Kahola, Mika
2019-05-20 13:42 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=762fdb9a-d9f8-727d-d6eb-7267120550fd@gmail.com \
--to=juhapekka.heikkila@gmail.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=swati2.sharma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox