From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3E45310E181 for ; Tue, 12 Dec 2023 09:31:36 +0000 (UTC) Message-ID: <77191af7-2f04-49fc-b317-ccb6a15f5e5c@intel.com> Date: Tue, 12 Dec 2023 09:31:31 +0000 MIME-Version: 1.0 Subject: Re: [PATCH i-g-t v5 5/6] tests/intel/gem_ccs: Add compression support for Lunarlake Content-Language: en-GB To: Akshata Jahagirdar References: From: Matthew Auld In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org, ayaz.siddiqui@intel.com Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 12/12/2023 17:39, Akshata Jahagirdar wrote: > Update the ccs_ratio call to get value according to platform. > > Signed-off-by: Akshata Jahagirdar > --- > tests/intel/gem_ccs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/intel/gem_ccs.c b/tests/intel/gem_ccs.c > index 0a691778d..5a17be4cb 100644 > --- a/tests/intel/gem_ccs.c > +++ b/tests/intel/gem_ccs.c > @@ -99,7 +99,7 @@ static void surf_copy(int i915, > struct blt_block_copy_data_ext ext = {}; > struct blt_ctrl_surf_copy_data surf = {}; > uint32_t bb1, bb2, ccs, ccs2, *ccsmap, *ccsmap2; > - uint64_t bb_size, ccssize = mid->size / CCS_RATIO; > + uint64_t bb_size, ccssize = mid->size / (CCS_RATIO(i915)); This seems misplaced, should this rather be squashed into one of the previous patches? CCS_RATIO now takes an argument, but that was done earlier in the series. > uint32_t *ccscopy; > uint8_t uc_mocs = intel_get_uc_mocs_index(i915); > int result;