Re: [igt-dev] [PATCH i-g-t] xe_create: create-big-vram subtest

["Bernatowicz, Marcin" <marcin.bernatowicz@linux.intel.com>]

On 11/21/2023 4:42 PM, Matthew Auld wrote:
> On Tue, 21 Nov 2023 at 13:50, Marcin Bernatowicz
> <marcin.bernatowicz@intel.com> wrote:
>>
>> Validates the creation of significant Buffer Objects (BO) within VRAM,
>> accounting for 75% of the CPU-visible VRAM size.
>> The size of the created BO can be adjusted using command line parameters,
>> with '-S' representing BO size in MB,
>> and '-p' representing BO size as a percentage of the VRAM size.
>>
>> v2: rebased, updated to uAPI changes (DRM_XE_VM_CREATE_FLAG_ASYNC_DEFAULT),
>>      after review corrections: 1024UL -> 1024ULL,
>>      int -> unsigned int (Kamil)
>>
>> Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@intel.com>
>> ---
>>   tests/intel/xe_create.c | 80 ++++++++++++++++++++++++++++++++++++++++-
>>   1 file changed, 79 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/intel/xe_create.c b/tests/intel/xe_create.c
>> index f4633cfb3..3ff9bb750 100644
>> --- a/tests/intel/xe_create.c
>> +++ b/tests/intel/xe_create.c
>> @@ -18,6 +18,14 @@
>>
>>   #define PAGE_SIZE 0x1000
>>
>> +static struct param {
>> +       unsigned int size_MB;
>> +       unsigned int vram_percent;
>> +} params = {
>> +       .size_MB = 0,
>> +       .vram_percent = 75,
>> +};
>> +
>>   static int __create_bo(int fd, uint32_t vm, uint64_t size, uint32_t flags,
>>                         uint32_t *handlep)
>>   {
>> @@ -214,7 +222,73 @@ static void create_massive_size(int fd)
>>          }
>>   }
>>
>> -igt_main
>> +/**
>> + * SUBTEST: create-big-vram
>> + * Functionality: BO creation
>> + * Test category: functionality test
>> + * Description: Validates the creation of substantial BO within VRAM
>> + *              (constituting 75% of the CPU-visible VRAM).
>> + */
>> +static void create_big_vram(int fd)
>> +{
>> +       uint64_t bo_size, size, vram_size, alignment;
>> +       uint32_t bo_handle;
>> +       char *bo_ptr = NULL;
>> +       uint64_t vm = 0;
>> +       int gt;
>> +
>> +       igt_require(xe_has_vram(fd));
>> +       alignment = xe_get_default_alignment(fd);
>> +       vm = xe_vm_create(fd, DRM_XE_VM_CREATE_FLAG_ASYNC_DEFAULT, 0);
>> +
>> +       xe_for_each_gt(fd, gt) {
>> +               vram_size = xe_visible_vram_size(fd, gt);
>> +               bo_size = params.size_MB ? params.size_MB * 1024ULL * 1024ULL
>> +                                        : ALIGN(vram_size * params.vram_percent / 100, alignment);
>> +               igt_debug("gt%u bo_size=%lu visible_vram_size=%lu\n", gt, bo_size, vram_size);
>> +
>> +               igt_assert_eq(0, __create_bo(fd, vm, bo_size, vram_memory(fd, gt), &bo_handle));
> 
> We should also ask the KMD to allocate the memory within the CPU
> visible portion of VRAM (if applicable), otherwise we will likely
> trigger SIGBUS below on small-bar systems. See visible_vram_memory().

True, updated and send v3.

Thanks for review,
marcin
> 
>> +               bo_ptr = xe_bo_map(fd, bo_handle, bo_size);
>> +               size = bo_size - 1;
>> +               while (size > SZ_64K) {
>> +                       igt_assert_eq(0, READ_ONCE(bo_ptr[size]));
>> +                       WRITE_ONCE(bo_ptr[size], 'A');
>> +                       igt_assert_eq('A', READ_ONCE(bo_ptr[size]));
>> +                       size >>= 1;
>> +               }
>> +
>> +               igt_assert_eq(0, bo_ptr[0]);
>> +               munmap(bo_ptr, bo_size);
>> +               gem_close(fd, bo_handle);
>> +       }
>> +
>> +       xe_vm_destroy(fd, vm);
>> +}
>> +
>> +static int opt_handler(int opt, int opt_index, void *data)
>> +{
>> +       switch (opt) {
>> +       case 'S':
>> +               params.size_MB = atoi(optarg);
>> +               igt_debug("Size MB: %d\n", params.size_MB);
>> +               break;
>> +       case 'p':
>> +               params.vram_percent = atoi(optarg);
>> +               igt_debug("Percent of VRAM: %d\n", params.vram_percent);
>> +               break;
>> +       default:
>> +               return IGT_OPT_HANDLER_ERROR;
>> +       }
>> +
>> +       return IGT_OPT_HANDLER_SUCCESS;
>> +}
>> +
>> +const char *help_str =
>> +       "  -S\tBO size in MB\n"
>> +       "  -p\tPercent of VRAM for BO (default 75% of visible VRAM size)\n"
>> +       ;
>> +
>> +igt_main_args("S:p:", NULL, help_str, opt_handler, NULL)
>>   {
>>          int xe;
>>
>> @@ -254,6 +328,10 @@ igt_main
>>          }
>>
>>
>> +       igt_subtest("create-big-vram") {
>> +               create_big_vram(xe);
>> +       }
>> +
>>          igt_fixture
>>                  drm_close_driver(xe);
>>   }
>> --
>> 2.31.1
>>