public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Naladala, Ramanaidu" <Ramanaidu.naladala@intel.com>
To: Jeevan B <jeevan.b@intel.com>, <igt-dev@lists.freedesktop.org>
Cc: <pranay.samala@intel.com>
Subject: Re: [PATCH i-g-t v3 2/4] tests/kms_vrr: Avoid unnecessary PSR disable
Date: Thu, 16 Apr 2026 13:58:46 +0530	[thread overview]
Message-ID: <7763bb8e-d5de-4149-b2ef-699fdde7cf47@intel.com> (raw)
In-Reply-To: <20260416035333.69004-3-jeevan.b@intel.com>

Hi Jeevan,

On 4/16/2026 9:23 AM, Jeevan B wrote:
> Use output instead of NULL in PSR helpers so PSR is disabled only
> when supported by the sink, avoiding unnecessary global checks and
> ensuring correct behavior on multi-eDP setups.

Update the rev info

with above changes looks good to me.

>
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> Reviewed-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
> ---
>   tests/kms_vrr.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c
> index ec0692b2f..30bda3244 100644
> --- a/tests/kms_vrr.c
> +++ b/tests/kms_vrr.c
> @@ -912,9 +912,10 @@ test_lobf(data_t *data, igt_crtc_t *crtc, igt_output_t *output,
>   			igt_skip("%s: Aux-less ALPM not enabled, LOBF not supported.\n",
>   				 igt_output_name(output));
>   
> -		if (psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_1, NULL) ||
> -		    psr_sink_support(data->drm_fd, data->debugfs_fd, PR_MODE, NULL))
> -			psr_disable(data->drm_fd, data->debugfs_fd, NULL);
> +		if (psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_1, output) ||
> +		    psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_2, output) ||
> +		    psr_sink_support(data->drm_fd, data->debugfs_fd, PR_MODE, output))
> +			psr_disable(data->drm_fd, data->debugfs_fd, output);
>   	}
>   
>   	igt_info("LOBF test execution on %s, PIPE %s with VRR range: (%u-%u) Hz\n",

  reply	other threads:[~2026-04-16  8:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-16  3:53 [PATCH i-g-t v3 0/4] Fix PSR handling for multi-eDP systems Jeevan B
2026-04-16  3:53 ` [PATCH i-g-t v3 1/4] tests/intel/kms_fbc_dirty_rect: Use per-output PSR check before disabling Jeevan B
2026-04-16  3:53 ` [PATCH i-g-t v3 2/4] tests/kms_vrr: Avoid unnecessary PSR disable Jeevan B
2026-04-16  8:28   ` Naladala, Ramanaidu [this message]
2026-04-16  3:53 ` [PATCH i-g-t v3 3/4] tests/intel/kms_psr_stress_test: Select PSR-capable output Jeevan B
2026-04-16  3:53 ` [PATCH i-g-t v3 4/4] tests/intel/kms_pm_dc: Scope PSR handling to output Jeevan B
2026-04-20  5:40   ` Samala, Pranay
2026-04-16  5:09 ` ✗ i915.CI.BAT: failure for Fix PSR handling for multi-eDP systems (rev4) Patchwork
2026-04-20  9:53   ` B, Jeevan
2026-04-16  5:48 ` ✓ Xe.CI.BAT: success " Patchwork
2026-04-16  8:51 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7763bb8e-d5de-4149-b2ef-699fdde7cf47@intel.com \
    --to=ramanaidu.naladala@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jeevan.b@intel.com \
    --cc=pranay.samala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox