From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5CA7D89263 for ; Mon, 3 Jun 2019 14:34:48 +0000 (UTC) From: "Ser, Simon" Date: Mon, 3 Jun 2019 14:34:46 +0000 Message-ID: <77e2174039370820e4953ae7a509f6140629618d.camel@intel.com> References: <20190531112200.22403-1-simon.ser@intel.com> <20190531112200.22403-3-simon.ser@intel.com> In-Reply-To: Content-Language: en-US Content-ID: <62A24F17A78A464EB1A6076F58D5EB37@intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 2/5] lib/igt_eld: consolidate ELD parsing List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "igt-dev@lists.freedesktop.org" , "martin.peres@linux.intel.com" Cc: "Peres, Martin" List-ID: T24gTW9uLCAyMDE5LTA2LTAzIGF0IDE1OjQyICswMzAwLCBNYXJ0aW4gUGVyZXMgd3JvdGU6DQo+ IE9uIDMxLzA1LzIwMTkgMTQ6MjEsIFNpbW9uIFNlciB3cm90ZToNCj4gPiBNYWtlIHRoZSBFTEQg ZW51bWVyYXRpb24gbW9yZSByb2J1c3QsIGFuZCBpbXBsZW1lbnQgcHJvcGVyIHBhcnNpbmcgZm9y IEVMRA0KPiA+IGZpZWxkcy4gVGhpcyB3aWxsIGJlY29tZSB1c2VmdWwgd2hlbiBvdGhlciBFTEQg ZmllbGRzIChmb3JtYXRzLCBzYW1wbGUgcmF0ZXMsDQo+ID4gc2FtcGxlIHNpemVzKSB3aWxsIGJl IHBhcnNlZCBhbmQgY2hlY2tlZC4NCj4gPiANCj4gPiBTaWduZWQtb2ZmLWJ5OiBTaW1vbiBTZXIg PHNpbW9uLnNlckBpbnRlbC5jb20+DQo+ID4gLS0tDQo+ID4gIGxpYi9pZ3RfZWxkLmMgfCA5NCAr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0NCj4gPiAg bGliL2lndF9lbGQuaCB8ICA1ICsrKw0KPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDYzIGluc2VydGlv bnMoKyksIDM2IGRlbGV0aW9ucygtKQ0KPiA+IA0KPiA+IGRpZmYgLS1naXQgYS9saWIvaWd0X2Vs ZC5jIGIvbGliL2lndF9lbGQuYw0KPiA+IGluZGV4IDhlMGRjYzMwNmU4NS4uYTE5ODAwMWE1NmQ3 IDEwMDY0NA0KPiA+IC0tLSBhL2xpYi9pZ3RfZWxkLmMNCj4gPiArKysgYi9saWIvaWd0X2VsZC5j DQo+ID4gQEAgLTMwLDggKzMwLDEyIEBADQo+ID4gICNpbmNsdWRlIDxzdGRpby5oPg0KPiA+ICAj aW5jbHVkZSA8c3RyaW5nLmg+DQo+ID4gIA0KPiA+ICsjaW5jbHVkZSAiaWd0X2NvcmUuaCINCj4g PiAgI2luY2x1ZGUgImlndF9lbGQuaCINCj4gPiAgDQo+ID4gKyNkZWZpbmUgRUxEX1BSRUZJWCAi ZWxkIyINCj4gPiArI2RlZmluZSBFTERfREVMSU0gIiBcdCINCj4gPiArDQo+ID4gIC8qKg0KPiA+ ICAgKiBFRElELUxpa2UgRGF0YSAoRUxEKSBpcyBtZXRhZGF0YSBwYXJzZWQgYW5kIGV4cG9zZWQg YnkgQUxTQSBmb3IgSERNSSBhbmQNCj4gPiAgICogRGlzcGxheVBvcnQgY29ubmVjdG9ycyBzdXBw b3J0aW5nIGF1ZGlvLiBUaGlzIGluY2x1ZGVzIHRoZSBtb25pdG9yIG5hbWUgYW5kDQo+ID4gQEAg LTM5LDM5ICs0Myw0OSBAQA0KPiA+ICAgKiBvbikuDQo+ID4gICAqLw0KPiA+ICANCj4gPiAtLyoq IGVsZF9lbnRyeV9pc19pZ3Q6IGNoZWNrcyB3aGV0aGVyIGFuIEVMRCBlbnRyeSBpcyBtYXBwZWQg dG8gdGhlIElHVCBFRElEICovDQo+IA0KPiBQb3N0aW5nIGFuIGV4YW1wbGUgb2YgZWxkIGhlcmUg d291bGQgYmUgaGVscGZ1bDoNCj4gDQo+ICQgY2F0IC9wcm9jL2Fzb3VuZC9jYXJkMC9lbGQjMC4y DQo+IG1vbml0b3JfcHJlc2VudCAgICAgICAgIDENCj4gZWxkX3ZhbGlkICAgICAgICAgICAgICAg MQ0KPiBtb25pdG9yX25hbWUgICAgICAgICAgICBVMjg3OUc2DQo+IA0KPiBjb25uZWN0aW9uX3R5 cGUgICAgICAgICBEaXNwbGF5UG9ydA0KPiBlbGRfdmVyc2lvbiAgICAgICAgICAgICBbMHgyXSBD RUEtODYxRCBvciBiZWxvdw0KPiBlZGlkX3ZlcnNpb24gICAgICAgICAgICBbMHgzXSBDRUEtODYx LUIsIEMgb3IgRA0KPiBtYW51ZmFjdHVyZV9pZCAgICAgICAgICAweGUzMDUNCj4gcHJvZHVjdF9p ZCAgICAgICAgICAgICAgMHgyODc5DQo+IHBvcnRfaWQgICAgICAgICAgICAgICAgIDB4ODAwDQo+ IHN1cHBvcnRfaGRjcCAgICAgICAgICAgIDANCj4gc3VwcG9ydF9haSAgICAgICAgICAgICAgMA0K PiBhdWRpb19zeW5jX2RlbGF5ICAgICAgICAwDQo+IHNwZWFrZXJzICAgICAgICAgICAgICAgIFsw eDFdIEZML0ZSDQo+IHNhZF9jb3VudCAgICAgICAgICAgICAgIDENCj4gc2FkMF9jb2RpbmdfdHlw ZSAgICAgICAgWzB4MV0gTFBDTQ0KPiBzYWQwX2NoYW5uZWxzICAgICAgICAgICAyDQo+IHNhZDBf cmF0ZXMgICAgICAgICAgICAgIFsweGUwXSAzMjAwMCA0NDEwMCA0ODAwMA0KPiBzYWQwX2JpdHMg ICAgICAgICAgICAgICBbMHhlMDAwMF0gMTYgMjAgMjQNCj4gDQo+ID4gLXN0YXRpYyBib29sIGVs ZF9lbnRyeV9pc19pZ3QoY29uc3QgY2hhciAqcGF0aCkNCj4gPiArc3RhdGljIGJvb2wgZWxkX3Bh cnNlX2VudHJ5KGNvbnN0IGNoYXIgKnBhdGgsIHN0cnVjdCBlbGRfZW50cnkgKmVsZCkNCj4gPiAg ew0KPiA+IC0JRklMRSAqaW47DQo+ID4gKwlGSUxFICpmOw0KPiA+ICAJY2hhciBidWZbMTAyNF07 DQo+ID4gLQl1aW50OF90IGVsZF92YWxpZCA9IDA7DQo+ID4gLQl1aW50OF90IG1vbl92YWxpZCA9 IDA7DQo+ID4gLQ0KPiA+IC0JaW4gPSBmb3BlbihwYXRoLCAiciIpOw0KPiA+IC0JaWYgKCFpbikN Cj4gPiAtCQlyZXR1cm4gZmFsc2U7DQo+ID4gKwljaGFyICprZXksICp2YWx1ZTsNCj4gPiArCXNp emVfdCBsZW47DQo+ID4gKwlib29sIG1vbml0b3JfcHJlc2VudDsNCj4gPiAgDQo+ID4gLQltZW1z ZXQoYnVmLCAwLCAxMDI0KTsNCj4gPiArCW1lbXNldChlbGQsIDAsIHNpemVvZigqZWxkKSk7DQo+ ID4gIA0KPiA+IC0Jd2hpbGUgKChmZ2V0cyhidWYsIDEwMjQsIGluKSkgIT0gTlVMTCkgew0KPiA+ IC0JCWNoYXIgKmxpbmUgPSBidWY7DQo+ID4gKwlmID0gZm9wZW4ocGF0aCwgInIiKTsNCj4gPiAr CWlmICghZikgew0KPiA+ICsJCWlndF9kZWJ1ZygiRmFpbGVkIHRvIG9wZW4gRUxEIGZpbGU6ICVz XG4iLCBwYXRoKTsNCj4gPiArCQlyZXR1cm4gZmFsc2U7DQo+ID4gKwl9DQo+ID4gIA0KPiA+IC0J CWlmICghc3RybmNhc2VjbXAobGluZSwgImVsZF92YWxpZCIsIDkpICYmDQo+ID4gLQkJCQlzdHJz dHIobGluZSwgIjEiKSkgew0KPiA+IC0JCQllbGRfdmFsaWQrKzsNCj4gPiAtCQl9DQo+IA0KPiBH b29kIHJpZGRhbmNlISBJZ25vcmUgbXkgY29tbWVudCBmcm9tIHBhdGNoIDEhDQo+IA0KPiA+ICsJ d2hpbGUgKChmZ2V0cyhidWYsIHNpemVvZihidWYpLCBmKSkgIT0gTlVMTCkgew0KPiA+ICsJCWxl biA9IHN0cmxlbihidWYpOw0KPiA+ICsJCWlmIChidWZbbGVuIC0gMV0gPT0gJ1xuJykNCj4gPiAr CQkJYnVmW2xlbiAtIDFdID0gJ1wwJzsNCj4gPiArDQo+ID4gKwkJa2V5ID0gc3RydG9rKGJ1Ziwg RUxEX0RFTElNKTsNCj4gPiArCQl2YWx1ZSA9IHN0cnRvayhOVUxMLCAiIik7DQo+IA0KPiBIbW0s IEkgaGFkIGZvcmdvdHRlbiB0aGF0IHN0cm9rIHdhcyBzdGF0ZWZ1bCB3aGVuIHN0ciA9PSBOVUxM IQ0KPiANCj4gPiArCQkvKiBTa2lwIHdoaXRlc3BhY2UgYXQgdGhlIGJlZ2lubmluZyAqLw0KPiA+ ICsJCXZhbHVlICs9IHN0cnNwbih2YWx1ZSwgRUxEX0RFTElNKTsNCj4gDQo+IFRoYW5rcyBmb3Ig dGVhY2hpbmcgbWUgYSBuZXcgZnVuY3Rpb24gOikgVGhpcyBpcyBxdWl0ZSBwcmFjdGljYWwhDQo+ IA0KPiBBZnRlciBkb2luZyBtb3JlIHB5dGhvbiB3b3JrLCBnb2luZyBiYWNrIHRvIHBhcnNpbmcg d2l0aCBDIGlzIGEgbGl0dGxlDQo+IHJvdWdoIDpEIE5vdCBhcyBiYWQgYXMgQVNNIHRob3VnaCEN Cg0KRWhlaCwgSSBjYW4gaW1hZ2luZSB0aGF0IDpQDQoNCj4gPiArDQo+ID4gKwkJaWYgKHN0cmNt cChrZXksICJtb25pdG9yX3ByZXNlbnQiKSA9PSAwKQ0KPiA+ICsJCQltb25pdG9yX3ByZXNlbnQg PSBzdHJjbXAodmFsdWUsICIxIikgPT0gMDsNCj4gPiArCQllbHNlIGlmIChzdHJjbXAoa2V5LCAi ZWxkX3ZhbGlkIikgPT0gMCkNCj4gPiArCQkJZWxkLT52YWxpZCA9IHN0cmNtcCh2YWx1ZSwgIjEi KSA9PSAwOw0KPiA+ICsJCWVsc2UgaWYgKHN0cmNtcChrZXksICJtb25pdG9yX25hbWUiKSA9PSAw KQ0KPiA+ICsJCQlzbnByaW50ZihlbGQtPm1vbml0b3JfbmFtZSwgc2l6ZW9mKGVsZC0+bW9uaXRv cl9uYW1lKSwNCj4gPiArCQkJCSAiJXMiLCB2YWx1ZSk7DQo+ID4gKwl9DQo+ID4gIA0KPiA+IC0J CWlmICghc3RybmNhc2VjbXAobGluZSwgIm1vbml0b3JfbmFtZSIsIDEyKSAmJg0KPiA+IC0JCQkJ c3Ryc3RyKGxpbmUsICJJR1QiKSkgew0KPiA+IC0JCQltb25fdmFsaWQrKzsNCj4gPiAtCQl9DQo+ ID4gKwlpZiAoZmVycm9yKGYpICE9IDApIHsNCj4gPiArCQlpZ3RfZGVidWcoIkZhaWxlZCB0byBy ZWFkIEVMRCBmaWxlOiAlZFxuIiwgZmVycm9yKGYpKTsNCj4gPiArCQlyZXR1cm4gZmFsc2U7DQo+ ID4gIAl9DQo+ID4gIA0KPiA+IC0JZmNsb3NlKGluKTsNCj4gPiAtCWlmIChtb25fdmFsaWQgJiYg ZWxkX3ZhbGlkKQ0KPiA+IC0JCXJldHVybiB0cnVlOw0KPiA+ICsJZmNsb3NlKGYpOw0KPiA+ICAN Cj4gPiAtCXJldHVybiBmYWxzZTsNCj4gPiArCXJldHVybiBtb25pdG9yX3ByZXNlbnQ7DQo+ID4g IH0NCj4gPiAgDQo+ID4gIC8qKiBlbGRfaGFzX2lndDogY2hlY2sgd2hldGhlciBBTFNBIGhhcyBk ZXRlY3RlZCB0aGUgYXVkaW8tY2FwYWJsZSBJR1QgRURJRCBieQ0KPiA+IEBAIC03OSwyNyArOTMs MzUgQEAgc3RhdGljIGJvb2wgZWxkX2VudHJ5X2lzX2lndChjb25zdCBjaGFyICpwYXRoKQ0KPiA+ ICBib29sIGVsZF9oYXNfaWd0KHZvaWQpDQo+ID4gIHsNCj4gPiAgCURJUiAqZGlyOw0KPiA+IC0J c3RydWN0IGRpcmVudCAqc25kX2hkYTsNCj4gPiArCXN0cnVjdCBkaXJlbnQgKmRpcmVudDsNCj4g PiAgCWludCBpOw0KPiA+ICsJY2hhciBjYXJkWzY0XTsNCj4gPiArCWNoYXIgcGF0aFtQQVRIX01B WF07DQo+ID4gKwlzdHJ1Y3QgZWxkX2VudHJ5IGVsZDsNCj4gPiAgDQo+ID4gIAlmb3IgKGkgPSAw OyBpIDwgODsgaSsrKSB7DQo+ID4gLQkJY2hhciBjYXJkc1sxMjhdOw0KPiA+IC0NCj4gPiAtCQlz bnByaW50ZihjYXJkcywgc2l6ZW9mKGNhcmRzKSwgIi9wcm9jL2Fzb3VuZC9jYXJkJWQiLCBpKTsN Cj4gPiAtCQlkaXIgPSBvcGVuZGlyKGNhcmRzKTsNCj4gPiArCQlzbnByaW50ZihjYXJkLCBzaXpl b2YoY2FyZCksICIvcHJvYy9hc291bmQvY2FyZCVkIiwgaSk7DQo+ID4gKwkJZGlyID0gb3BlbmRp cihjYXJkKTsNCj4gPiAgCQlpZiAoIWRpcikNCj4gPiAgCQkJY29udGludWU7DQo+ID4gIA0KPiA+ IC0JCXdoaWxlICgoc25kX2hkYSA9IHJlYWRkaXIoZGlyKSkpIHsNCj4gPiAtCQkJY2hhciBmcGF0 aFtQQVRIX01BWF07DQo+ID4gKwkJd2hpbGUgKChkaXJlbnQgPSByZWFkZGlyKGRpcikpKSB7DQo+ ID4gKwkJCWlmIChzdHJuY21wKGRpcmVudC0+ZF9uYW1lLCBFTERfUFJFRklYLA0KPiA+ICsJCQkJ ICAgIHN0cmxlbihFTERfUFJFRklYKSkgIT0gMCkNCj4gPiArCQkJCWNvbnRpbnVlOw0KPiA+ICsN Cj4gPiArCQkJc25wcmludGYocGF0aCwgc2l6ZW9mKHBhdGgpLCAiJXMvJXMiLCBjYXJkLA0KPiA+ ICsJCQkJIGRpcmVudC0+ZF9uYW1lKTsNCj4gPiArCQkJaWYgKCFlbGRfcGFyc2VfZW50cnkocGF0 aCwgJmVsZCkpIHsNCj4gPiArCQkJCWNvbnRpbnVlOw0KPiA+ICsJCQl9DQo+ID4gIA0KPiA+IC0J CQlpZiAoKnNuZF9oZGEtPmRfbmFtZSA9PSAnLicgfHwNCj4gPiAtCQkJICAgIHN0cnN0cihzbmRf aGRhLT5kX25hbWUsICJlbGQiKSA9PSAwKQ0KPiA+ICsJCQlpZiAoIWVsZC52YWxpZCkgew0KPiA+ ICsJCQkJaWd0X2RlYnVnKCJTa2lwcGluZyBpbnZhbGlkIEVMRDogJXNcbiIsIHBhdGgpOw0KPiAN Cj4gVGhlIG1lc3NhZ2UgaXMgYSBsaXR0bGUgY29uZnVzaW5nLiBIb3cgYWJvdXQgIlNraXBwaW5n IG5vbi1FTEQgZmlsZToNCj4gJXNcbiIgaW5zdGVhZD8NCg0KU28sIHRoaXMgaXMgbm90IGV4YWN0 bHkgYSBub24tRUxEIGZpbGU6IHRoaXMgaGFwcGVucyB3aGVuIHRoZSBFRElEDQppc24ndCB2YWxp ZCAoZS5nLiBpZiBzb21lIGZpZWxkIGlzIG1hbGZvcm1lZCkuDQoNCklzIGl0IG9rYXkgaWYgSSBj aGFuZ2UgaXQgdG86ICJTa2lwcGluZyBFTEQgZW50cnkgd2l0aCBpbnZhbGlkPTEiPw0KDQo+IEFu eXdheSwgSSBsaWtlIHdoZXJlIHRoaXMgaXMgZ29pbmchDQo+IA0KPiBSZXZpZXdlZC1ieTogTWFy dGluIFBlcmVzIDxtYXJ0aW4ucGVyZXNAbGludXguaW50ZWwuY29tPg0KPiANCj4gPiAgCQkJCWNv bnRpbnVlOw0KPiA+ICsJCQl9DQo+ID4gIA0KPiA+IC0JCQlzbnByaW50ZihmcGF0aCwgc2l6ZW9m KGZwYXRoKSwgIiVzLyVzIiwgY2FyZHMsDQo+ID4gLQkJCQkgc25kX2hkYS0+ZF9uYW1lKTsNCj4g PiAtCQkJaWYgKGVsZF9lbnRyeV9pc19pZ3QoZnBhdGgpKSB7DQo+ID4gKwkJCWlmIChzdHJjbXAo ZWxkLm1vbml0b3JfbmFtZSwgIklHVCIpID09IDApIHsNCj4gPiAgCQkJCWNsb3NlZGlyKGRpcik7 DQo+ID4gIAkJCQlyZXR1cm4gdHJ1ZTsNCj4gPiAgCQkJfQ0KPiA+IGRpZmYgLS1naXQgYS9saWIv aWd0X2VsZC5oIGIvbGliL2lndF9lbGQuaA0KPiA+IGluZGV4IDI3Zjg3NmQ5ZjYzMS4uMjFmZTM1 MzdhY2Y5IDEwMDY0NA0KPiA+IC0tLSBhL2xpYi9pZ3RfZWxkLmgNCj4gPiArKysgYi9saWIvaWd0 X2VsZC5oDQo+ID4gQEAgLTMwLDYgKzMwLDExIEBADQo+ID4gIA0KPiA+ICAjaW5jbHVkZSA8c3Rk Ym9vbC5oPg0KPiA+ICANCj4gPiArc3RydWN0IGVsZF9lbnRyeSB7DQo+ID4gKwlib29sIHZhbGlk Ow0KPiA+ICsJY2hhciBtb25pdG9yX25hbWVbMTZdOw0KPiA+ICt9Ow0KPiA+ICsNCj4gPiAgYm9v bCBlbGRfaGFzX2lndCh2b2lkKTsNCj4gPiAgDQo+ID4gICNlbmRpZg0KPiA+IA0KX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxp c3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2