Re: [igt-dev] [PATCH i-g-t 2/7] lib/params: start renaming functions igt_params_*

[Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>]

On 5.5.2020 17.04, Arkadiusz Hiler wrote:
> On Tue, Apr 28, 2020 at 11:22:50PM +0300, Juha-Pekka Heikkila wrote:
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>> Reviewed-by: Petri Latvala <petri.latvala@intel.com>
>> ---
>>   lib/drmtest.c                         |  2 +-
>>   lib/i915/gem_submission.c             |  2 +-
>>   lib/igt_aux.c                         |  3 +--
>>   lib/igt_gt.c                          |  2 +-
>>   lib/igt_params.c                      | 12 +++++-------
>>   lib/igt_params.h                      |  5 ++---
>>   tests/i915/gem_ctx_exec.c             |  2 +-
>>   tests/i915/gem_ctx_persistence.c      |  9 ++++-----
>>   tests/i915/gem_mmap_gtt.c             |  2 +-
>>   tests/i915/gem_reset_stats.c          |  6 ++----
>>   tests/i915/sysfs_heartbeat_interval.c |  3 ++-
>>   tests/i915/sysfs_preempt_timeout.c    |  3 ++-
>>   tests/i915/sysfs_timeslice_duration.c |  3 ++-
>>   13 files changed, 25 insertions(+), 29 deletions(-)
>>
>> diff --git a/lib/drmtest.c b/lib/drmtest.c
>> index 1fc39925..17067843 100644
>> --- a/lib/drmtest.c
>> +++ b/lib/drmtest.c
>> @@ -393,7 +393,7 @@ static void __cancel_work_at_exit(int fd)
>>   {
>>   	igt_terminate_spins(); /* for older kernels */
>>   
>> -	igt_sysfs_set_parameter(fd, "reset", "%x", -1u /* any method */);
>> +	igt_params_set(fd, "reset", "%x", -1u /* any method */);
> 
> With #define MODULE_PARAM_DIR "/sys/module/i915/parameters/"
> and the debugfs interface everything here is i915-specific.
> 
> i915_param_ prefix would be better as it both suggests that we are
> dealing with i915 module parameters instead of some elusive IGT
> framework params and doesn't create illusion that this is
> driver-agnostic.

This is intermediate step, admittedly could be squashed but I didn't see 
reason for hiding building of parameters. Anyway on final setup there's 
not supposing to be anything limiting igt_params to i915. That said I 
have not had possibility to try this on amdgpu or something but still..

/Juha-Pekka
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev