From: "Reddy Guddati, Santhosh" <santhosh.reddy.guddati@intel.com>
To: Vinod Govindapillai <vinod.govindapillai@intel.com>,
<igt-dev@lists.freedesktop.org>
Cc: <swati2.sharma@intel.com>
Subject: Re: [PATCH i-g-t v4 09/12] tests/intel/kms_fbcon_fbt: find and store the crtc index
Date: Fri, 10 Jul 2026 11:14:25 +0530 [thread overview]
Message-ID: <78c472df-9b17-4ffa-b829-bf87a8258f2e@intel.com> (raw)
In-Reply-To: <20260601204407.39934-10-vinod.govindapillai@intel.com>
On 02-06-2026 02:14, Vinod Govindapillai wrote:
> As we need to find the fbc status from crtc debugfs entry, find
> and keep the crtc index from the crtc_id and use it wherever
> required.
>
> Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
Reviewed-by: Santhosh Reddy Guddati <santhosh.reddy.guddati@intel.com>
> ---
> tests/intel/kms_fbcon_fbt.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/intel/kms_fbcon_fbt.c b/tests/intel/kms_fbcon_fbt.c
> index 5863c9e68..96136f8ff 100644
> --- a/tests/intel/kms_fbcon_fbt.c
> +++ b/tests/intel/kms_fbcon_fbt.c
> @@ -68,7 +68,7 @@ IGT_TEST_DESCRIPTION("Test the relationship between fbcon and the frontbuffer "
> #define MAX_CONNECTORS 32
>
> struct drm_info {
> - int fd, debugfs_fd, crtc_id, devid;
> + int fd, debugfs_fd, crtc_id, crtc_index, devid;
> struct igt_fb fb;
> drmModeResPtr res;
> drmModeConnectorPtr connectors[MAX_CONNECTORS];
> @@ -149,10 +149,9 @@ static bool fbc_check_cursor_blinking(struct drm_info *drm)
> igt_pipe_crc_t *pipe_crc;
> igt_crc_t crc[2];
> bool ret;
> - int i, crtc_index;
> + int i;
>
> - crtc_index = kmstest_get_crtc_index_from_id(drm->fd, drm->crtc_id);
> - pipe_crc = igt_pipe_crc_new(drm->fd, crtc_index, IGT_PIPE_CRC_SOURCE_AUTO);
> + pipe_crc = igt_pipe_crc_new(drm->fd, drm->crtc_index, IGT_PIPE_CRC_SOURCE_AUTO);
>
> igt_pipe_crc_start(pipe_crc);
> igt_pipe_crc_drain(pipe_crc);
> @@ -222,6 +221,7 @@ static void set_mode_for_one_screen(struct drm_info *drm,
> "No connector available\n");
>
> drm->crtc_id = kmstest_find_crtc_for_connector(drm->fd, drm->res, c, 0);
> + drm->crtc_index = kmstest_get_crtc_index_from_id(drm->fd, drm->crtc_id);
>
> buffer_id = igt_create_fb(drm->fd, mode->hdisplay, mode->vdisplay,
> DRM_FORMAT_XRGB8888,
next prev parent reply other threads:[~2026-07-10 5:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 20:43 [PATCH i-g-t v4 00/12] updates to fbc tests Vinod Govindapillai
2026-06-01 20:43 ` [PATCH i-g-t v4 01/12] lib/i915/fbc: extract intel_fbc_get_fbc_status() Vinod Govindapillai
2026-07-10 4:50 ` Reddy Guddati, Santhosh
2026-06-01 20:43 ` [PATCH i-g-t v4 02/12] tests/intel/kms_frontbuffer_tracking: use intel_fbc_get_status() Vinod Govindapillai
2026-07-10 5:11 ` Reddy Guddati, Santhosh
2026-06-01 20:43 ` [PATCH i-g-t v4 03/12] tests/intel/kms_frontbuffer_tracking: update the outdated fbc status reasons Vinod Govindapillai
2026-07-10 5:16 ` Reddy Guddati, Santhosh
2026-06-01 20:43 ` [PATCH i-g-t v4 04/12] tests/intel/kms_frontbuffer_tracking: consolidate fbc tests skip checks Vinod Govindapillai
2026-07-16 7:37 ` Reddy Guddati, Santhosh
2026-06-01 20:44 ` [PATCH i-g-t v4 05/12] tests/intel/kms_frontbuffer_tracking: use a bigger buffer for fbc status Vinod Govindapillai
2026-06-01 20:44 ` [PATCH i-g-t v4 06/12] tests/intel/kms_fbcon_fbt: " Vinod Govindapillai
2026-06-01 20:44 ` [PATCH i-g-t v4 07/12] tests/intel/kms_fbcon_fbt: update the outdated fbc skip reasons Vinod Govindapillai
2026-07-10 5:21 ` Reddy Guddati, Santhosh
2026-06-01 20:44 ` [PATCH i-g-t v4 08/12] tests/intel/kms_fbcon_fbt: refactor the code to get the right fbc status Vinod Govindapillai
2026-07-10 5:43 ` Reddy Guddati, Santhosh
2026-06-01 20:44 ` [PATCH i-g-t v4 09/12] tests/intel/kms_fbcon_fbt: find and store the crtc index Vinod Govindapillai
2026-07-10 5:44 ` Reddy Guddati, Santhosh [this message]
2026-06-01 20:44 ` [PATCH i-g-t v4 10/12] tests/intel/kms_fbcon_fbt: find the correct fbc status of a pipe Vinod Govindapillai
2026-07-16 7:41 ` Reddy Guddati, Santhosh
2026-06-01 20:44 ` [PATCH i-g-t v4 11/12] tests/intel/kms_fbcon_fbt: use common routine to skip tests on fbc status Vinod Govindapillai
2026-07-16 7:46 ` Reddy Guddati, Santhosh
2026-06-01 20:44 ` [PATCH i-g-t v4 12/12] tests/intel/fbc: detatiled debug info for unsupported plane size for fbc Vinod Govindapillai
2026-07-10 5:06 ` Reddy Guddati, Santhosh
2026-06-02 0:06 ` ✓ i915.CI.BAT: success for updates to fbc tests (rev4) Patchwork
2026-06-02 0:08 ` ✓ Xe.CI.BAT: " Patchwork
2026-06-02 9:29 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-06-02 10:41 ` ✗ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78c472df-9b17-4ffa-b829-bf87a8258f2e@intel.com \
--to=santhosh.reddy.guddati@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=swati2.sharma@intel.com \
--cc=vinod.govindapillai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox