public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Sharma, Swati2" <swati2.sharma@intel.com>
To: Naladala Ramanaidu <ramanaidu.naladala@intel.com>,
	<igt-dev@lists.freedesktop.org>
Cc: <karthik.b.s@intel.com>,
	Juha-Pekka Heikkila <juha-pekka.heikkila@intel.com>
Subject: Re: [PATCH i-g-t v1] tests/kms_plane_scaling: Use selective modes for scaling checks
Date: Fri, 20 Mar 2026 13:56:32 +0530	[thread overview]
Message-ID: <78ded675-1ca4-4767-9f8b-07f406a88dbe@intel.com> (raw)
In-Reply-To: <20260316185218.700329-1-ramanaidu.naladala@intel.com>

Hi Ramanaidu,

On 17-03-2026 12:22 am, Naladala Ramanaidu wrote:
> Update the scaling test to try only three representative modes:
> the first, one from the middle, and the last. This decreases test
> runtime while maintaining adequate coverage.
>
> Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
> ---
>   tests/kms_plane_scaling.c | 10 ++++++++--
>   1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index ab619fb2b..33546d5bf 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -584,9 +584,15 @@ check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
>   	int commit_ret;
>   	int w, h;
>   	int width, height;
> +	uint32_t mod_count = output->config.connector->count_modes;
> +	uint32_t index[3] = {0, mod_count/2, mod_count - 1};
>   
> -	for_each_connector_mode(output) {

This change was introduced in

commit 27926dd5792a225f28eaf938134505fd44ba8872
Author: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
Date:   Thu Jul 18 19:35:45 2024 +0530

     tests/kms_plane_scaling: Find display mode fitting in BW for rotations

where we were lowering modes to address BW issues, but here adhoc we are

choosing 3 modes..doesn't look right. May be we can skip 2 modes and 
check instead

of choosing first, mid and last.

++JP

> -		mode = &output->config.connector->modes[j__];
> +	for (int j = 0; j < 3; j++) {
> +
> +		if ((mod_count <= 2) && (j > 1))
> +			break;
> +
> +		mode = &output->config.connector->modes[index[j]];
>   		igt_output_override_mode(output, mode);
>   		igt_debug("Trying mode %dx%d\n",
>   			  mode->hdisplay, mode->vdisplay);

      parent reply	other threads:[~2026-03-20  8:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-16 18:52 [PATCH i-g-t v1] tests/kms_plane_scaling: Use selective modes for scaling checks Naladala Ramanaidu
2026-03-17  3:47 ` S, Sowmiya
2026-03-17 13:26 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-03-17 14:50 ` ✓ i915.CI.BAT: " Patchwork
2026-03-18 16:13 ` ✓ i915.CI.Full: " Patchwork
2026-03-18 21:41 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-03-20  8:26 ` Sharma, Swati2 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78ded675-1ca4-4767-9f8b-07f406a88dbe@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=juha-pekka.heikkila@intel.com \
    --cc=karthik.b.s@intel.com \
    --cc=ramanaidu.naladala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox