From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Petri Latvala <petri.latvala@intel.com>, igt-dev@lists.freedesktop.org
Cc: Martin Liska <mliska@suse.cz>
Subject: Re: [igt-dev] [PATCH i-g-t] lib/fb: Fix rgb24 to nv12 conversion
Date: Wed, 9 Jan 2019 13:40:08 +0100 [thread overview]
Message-ID: <78e9048f-f138-1bc1-3235-d881eaafe682@linux.intel.com> (raw)
In-Reply-To: <20190109122829.713-1-petri.latvala@intel.com>
Op 09-01-2019 om 13:28 schreef Petri Latvala:
> A typo fix in 1x2 pixel block conversion code, revealed by GCC 9
>
> Fixes: 1c7ef3890045 ("lib: Use igt_matrix for ycbcr<->rgb conversion")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109257
> Reported-by: Martin Liska <mliska@suse.cz>
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
> lib/igt_fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index 8244e517..5cd1829a 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -1779,7 +1779,7 @@ static void convert_rgb24_to_nv12(struct fb_convert *cvt)
> struct igt_vec4 yuv[2];
>
> read_rgb(&rgb[0], &rgb24[j * 8 + 0]);
> - read_rgb(&rgb[2], &rgb24[j * 8 + 0 + rgb24_stride]);
> + read_rgb(&rgb[1], &rgb24[j * 8 + 0 + rgb24_stride]);
>
> yuv[0] = igt_matrix_transform(&m, &rgb[0]);
> yuv[1] = igt_matrix_transform(&m, &rgb[1]);
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-01-09 12:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 12:28 [igt-dev] [PATCH i-g-t] lib/fb: Fix rgb24 to nv12 conversion Petri Latvala
2019-01-09 12:40 ` Maarten Lankhorst [this message]
2019-01-09 13:12 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-01-09 15:49 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78e9048f-f138-1bc1-3235-d881eaafe682@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=mliska@suse.cz \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox