Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: Simon Ser <contact@emersion.fr>
Cc: "James Jones" <jajones@nvidia.com>,
	igt-dev@lists.freedesktop.org,
	"Austin Shafer" <ashafer@nvidia.com>,
	"Bas Nieuwenhuizen" <bas@basnieuwenhuizen.nl>,
	"Christian König" <christian.koenig@amd.com>,
	"Faith Ekstrand" <faith.ekstrand@collabora.com>
Subject: Re: [igt-dev] [PATCH v2] tests/syncobj_eventfd: new test
Date: Wed, 12 Jul 2023 14:38:29 +0300	[thread overview]
Message-ID: <7901c51b-0049-406c-afdc-cc368698572e@intel.com> (raw)
In-Reply-To: <eUc6v9Nr-nnUwveiM4oZOwXG9QRfrSwIshIMsS8edwtDGNVj1vpMaSxtNOl7wRZbsx-EB-ti-4PBIvJvZx9-rJv78bo_GnEDnnKyZtHEhHo=@emersion.fr>

On 12/07/2023 10:45, Simon Ser wrote:
> On Wednesday, July 12th, 2023 at 09:37, Lionel Landwerlin <lionel.g.landwerlin@intel.com> wrote:
>
>> These tests look correct to me.
> Thanks for having a look!
>
>> Are you not planning on testing/supporting
>> DRM_SYNCOBJ_WAIT_FLAGS_WAIT_FOR_SUBMIT and DRM_SYNCOBJ_WAIT_FLAGS_WAIT_ALL ?
> DRM_SYNCOBJ_WAIT_FLAGS_WAIT_FOR_SUBMIT is implied: the IOCTL will never
> fail because a fence hasn't materialized. There is no use-case for this
> flag: if user-space wants this behavior they can try to extract a
> sync_file (which will fail if it hasn't materialized yet) and then poll
> that sync_file.
>
> DRM_SYNCOBJ_WAIT_FLAGS_WAIT_ALL doesn't make sense for this IOCTL
> because only a single syncobj is passed in.
>
> Simon

Thanks for clarifying.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>

  reply	other threads:[~2023-07-12 11:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-12  7:17 [igt-dev] [PATCH v2] tests/syncobj_eventfd: new test Simon Ser
2023-07-12  7:37 ` Lionel Landwerlin
2023-07-12  7:45   ` Simon Ser
2023-07-12 11:38     ` Lionel Landwerlin [this message]
2023-07-12  8:03 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/syncobj_eventfd: new test (rev2) Patchwork
2023-07-12  8:40 ` [igt-dev] ○ CI.xeBAT: info " Patchwork
2023-07-12  9:11 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
2023-07-12 11:48 ` [igt-dev] [PATCH v2] tests/syncobj_eventfd: new test Christian König
2023-07-14 10:14   ` vitaly prosyak
2023-07-14 10:51     ` Simon Ser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7901c51b-0049-406c-afdc-cc368698572e@intel.com \
    --to=lionel.g.landwerlin@intel.com \
    --cc=ashafer@nvidia.com \
    --cc=bas@basnieuwenhuizen.nl \
    --cc=christian.koenig@amd.com \
    --cc=contact@emersion.fr \
    --cc=faith.ekstrand@collabora.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jajones@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox