Re: [PATCH i-g-t 1/2] lib/intel_blt: Add functions which extract and check object ccs data

[Karolina Stolarek <karolina.stolarek@intel.com>]

On 10.04.2024 10:33, Zbigniew Kempczyński wrote:
> On Fri, Mar 29, 2024 at 02:31:36PM +0100, Karolina Stolarek wrote:
>>> +
>>> +	blt_ctrl_surf_copy_init(fd, &surf);
>>> +
>>> +	ccscopy = (uint32_t *)malloc(ccssize);
>>> +	igt_assert(ccscopy);
>>> +
>>> +	if (surf.driver == INTEL_DRIVER_XE) {
>>> +		uint16_t cpu_caching = __xe_default_cpu_caching(fd, sysmem, 0);
>>
>> sysmem is undefined here, I'd move the definition from below to here (i.e.,
>> to the line before cpu_caching).
> 
> Eh, well spotted. I've added xe path first and most variables were
> defined on the function beginning. When I've extended and added
> i915 path I've missed that.

No worries, that's what review is for :)

>> Apart from that, the patch looks good (+ one nit below). I haven't test it
>> on my machine, but I trust you played with your changes to verify their
>> correctness :)
> 
> I've tested it on xe/xe2 machines and I didn't notice any issues.

Awesome, thanks. Once you fix the spotted issues, feel free to add my 
r-b to both patches:

Reviewed-by: Karolina Stolarek <karolina.stolarek@intel.com>

Many thanks,
Karolina