Re: [PATCH i-g-t v2 1/1] tests/kms_async_flips: Fix PSR2 selective fetch check for cursor tests

["Reddy Guddati, Santhosh" <santhosh.reddy.guddati@intel.com>]

Hi Jeevan,

On 11-02-2026 09:10, B, Jeevan wrote:
>> -----Original Message-----
>> From: Reddy Guddati, Santhosh <santhosh.reddy.guddati@intel.com>
>> Sent: Tuesday, February 3, 2026 2:13 PM
>> To: igt-dev@lists.freedesktop.org
>> Cc: B S, Karthik <karthik.b.s@intel.com>; B, Jeevan <jeevan.b@intel.com>;
>> Sharma, Swati2 <swati2.sharma@intel.com>; Manna, Animesh
>> <animesh.manna@intel.com>; Reddy Guddati, Santhosh
>> <santhosh.reddy.guddati@intel.com>
>> Subject: [PATCH i-g-t v2 1/1] tests/kms_async_flips: Fix PSR2 selective fetch
>> check for cursor tests
>>
>> The async flip cursor tests are expected to skip on PSR panels and execute on
>> non-PSR panels.The change allows the test to check per sink PSR capabilities
>> and verifies async flip behaviour accordingly.
>>
>> v2: Use psr_sink_support for the panels capabilities to identify psr2_sf and
>> skip the tests accordingly and revert lib changes. (Jeevan)
>>
>> Signed-off-by: Santhosh Reddy Guddati <santhosh.reddy.guddati@intel.com>
>> ---
>>   tests/kms_async_flips.c | 30 +++++++++---------------------
>>   1 file changed, 9 insertions(+), 21 deletions(-)
>>
>> diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c index
>> 993ad3753..f7f70dd5b 100644
>> --- a/tests/kms_async_flips.c
>> +++ b/tests/kms_async_flips.c
>> @@ -616,7 +616,7 @@ static void test_timestamp(data_t *data)  static void
>> test_cursor(data_t *data)  {
>>   	int flags = DRM_MODE_PAGE_FLIP_ASYNC |
>> DRM_MODE_PAGE_FLIP_EVENT;
>> -	int ret;
>> +	int ret, debugfs_fd;
>>   	uint64_t width, height;
>>   	struct igt_fb cursor_fb;
>>   	struct drm_mode_cursor cur;
>> @@ -628,9 +628,14 @@ static void test_cursor(data_t *data)
>>   	 * necessary, causing the async flip to fail because async flip is not
>>   	 * supported in cursor plane.
>>   	 */
>> -	igt_skip_on_f(i915_psr2_selective_fetch_check(data->drm_fd, NULL),
>> -		      "PSR2 sel fetch causes cursor to be added to primary plane
>> " \
>> -		      "pages flips and async flip is not supported in cursor\n");
>> +	if (is_intel_device(data->drm_fd)) {
>> +		debugfs_fd = igt_debugfs_dir(data->drm_fd);
>> +		igt_skip_on_f(psr_sink_support(data->drm_fd, debugfs_fd,
>> +					       PSR_MODE_2_SEL_FETCH, data-
>>> output),
>> +			      "PSR2 sel fetch causes cursor to be added to
>> primary plane "
>> +			      "pages flips and async flip is not supported in
>> cursor\n");
> 
> Small suggestion with the print message can we make it " PSR2 selective fetch adds cursor to primary plane flips, breaking async flip support"
> I'm ok with current version also. With this Patch LGTM.
> 
>   Reviewed-by: Jeevan B <jeevan.b@intel.com>

Thank you, I will update the print message during merge.

Regards,
santhosh

> 
>> +		close(debugfs_fd);
>> +	}
>>
>>   	do_or_die(drmGetCap(data->drm_fd, DRM_CAP_CURSOR_WIDTH,
>> &width));
>>   	do_or_die(drmGetCap(data->drm_fd, DRM_CAP_CURSOR_WIDTH,
>> &height)); @@ -1163,15 +1168,6 @@ int igt_main()
>>   	igt_describe("Verify that the DRM_IOCTL_MODE_CURSOR passes after
>> async flip");
>>   	igt_subtest_with_dynamic("test-cursor") {
>>   		test_init_ops(&data);
>> -		/*
>> -		 * Intel's PSR2 selective fetch adds other planes to state when
>> -		 * necessary, causing the async flip to fail because async flip is
>> not
>> -		 * supported in cursor plane.
>> -		 */
>> -		igt_skip_on_f(i915_psr2_selective_fetch_check(data.drm_fd,
>> NULL),
>> -			      "PSR2 sel fetch causes cursor to be added to
>> primary plane "
>> -			      "pages flips and async flip is not supported in
>> cursor\n");
>> -
>>   		run_test(&data, test_cursor);
>>   	}
>>
>> @@ -1179,14 +1175,6 @@ int igt_main()
>>   		     "async flip with atomic commit");
>>   	igt_subtest_with_dynamic("test-cursor-atomic") {
>>   		test_init_ops(&data);
>> -		/*
>> -		 * Intel's PSR2 selective fetch adds other planes to state when
>> -		 * necessary, causing the async flip to fail because async flip is
>> not
>> -		 * supported in cursor plane.
>> -		 */
>> -		igt_skip_on_f(i915_psr2_selective_fetch_check(data.drm_fd,
>> NULL),
>> -			      "PSR2 sel fetch causes cursor to be added to
>> primary plane "
>> -			      "pages flips and async flip is not supported in
>> cursor\n");
>>   		data.atomic_path = true;
>>   		run_test(&data, test_cursor);
>>   	}
>> --
>> 2.34.1
>