Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
	"Naladala, Ramanaidu" <ramanaidu.naladala@intel.com>
Cc: "Manna, Animesh" <animesh.manna@intel.com>,
	"B, Jeevan" <jeevan.b@intel.com>
Subject: Re: [PATCH i-g-t v1] lib/igt_psr: Fix PSR active check for DisplayPort connectors
Date: Fri, 21 Mar 2025 13:00:14 +0000	[thread overview]
Message-ID: <7a7f35b2c8f545bf4f89bc4f1c240e14e029a971.camel@intel.com> (raw)
In-Reply-To: <20250320215642.3175042-1-ramanaidu.naladala@intel.com>

On Fri, 2025-03-21 at 03:26 +0530, Naladala Ramanaidu wrote:
> Update PSR active check logic to correctly identify active
> state for Panel Replay on DisplayPort connectors.
> 
> Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com>

Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
> ---
>  lib/igt_psr.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/igt_psr.c b/lib/igt_psr.c
> index 83c21e6ba..e7b630096 100644
> --- a/lib/igt_psr.c
> +++ b/lib/igt_psr.c
> @@ -122,7 +122,9 @@ static bool psr_active_check(int debugfs_fd, enum
> psr_mode mode, igt_output_t *o
>  
>  	igt_skip_on(strstr(buf, "PSR sink not reliable: yes"));
>  
> -	active = strstr(buf, state);
> +	active = strstr(buf, state) ||
> +		 ((c->connector_type ==
> DRM_MODE_CONNECTOR_DisplayPort) &&
> +		  strstr(buf, "SU_STANDBY"));
>  
>  	if (active && output && sink_status_checks()) {
>  		active = psr_active_sink_check(debugfs_fd, output);


  parent reply	other threads:[~2025-03-21 13:02 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-20 21:56 [PATCH i-g-t v1] lib/igt_psr: Fix PSR active check for DisplayPort connectors Naladala Ramanaidu
2025-03-21  1:26 ` ✗ Xe.CI.BAT: failure for " Patchwork
2025-03-21  1:48 ` ✗ i915.CI.BAT: " Patchwork
2025-03-21  3:12 ` ✗ Xe.CI.Full: " Patchwork
2025-03-21  5:43 ` [PATCH v2] " Naladala Ramanaidu
2025-03-25 19:00   ` [PATCH i-g-t v3] " Naladala Ramanaidu
2025-03-26 13:26     ` [PATCH i-g-t v4] " Naladala Ramanaidu
2025-03-21  6:42 ` ✓ Xe.CI.BAT: success for lib/igt_psr: Fix PSR active check for DisplayPort connectors (rev2) Patchwork
2025-03-21  7:02 ` ✓ i915.CI.BAT: " Patchwork
2025-03-21  7:24 ` ✗ Xe.CI.Full: failure " Patchwork
2025-03-21  9:02 ` ✗ i915.CI.Full: " Patchwork
2025-03-21 13:00 ` Hogander, Jouni [this message]
2025-03-26  3:28 ` ✗ Xe.CI.BAT: failure for lib/igt_psr: Fix PSR active check for DisplayPort connectors (rev3) Patchwork
2025-03-26  3:43 ` ✗ i915.CI.BAT: " Patchwork
2025-03-26 15:45 ` ✓ Xe.CI.BAT: success for lib/igt_psr: Fix PSR active check for DisplayPort connectors (rev4) Patchwork
2025-03-26 15:58 ` ✗ i915.CI.BAT: failure " Patchwork
2025-03-26 21:13 ` ✗ Xe.CI.Full: failure for lib/igt_psr: Fix PSR active check for DisplayPort connectors (rev3) Patchwork
2025-03-27  4:08 ` ✗ Xe.CI.Full: failure for lib/igt_psr: Fix PSR active check for DisplayPort connectors (rev4) Patchwork
2025-03-27 11:06 ` Patchwork
2025-03-28  5:50 ` ✓ Xe.CI.BAT: success for lib/igt_psr: Fix PSR active check for DisplayPort connectors (rev5) Patchwork
2025-03-28  6:12 ` ✓ i915.CI.BAT: " Patchwork
2025-03-28 17:26 ` ✗ Xe.CI.Full: failure " Patchwork
2025-04-01 12:45 ` ✓ Xe.CI.BAT: success for lib/igt_psr: Fix PSR active check for DisplayPort connectors (rev6) Patchwork
2025-04-01 13:05 ` ✓ i915.CI.BAT: " Patchwork
2025-04-01 15:32 ` ✗ Xe.CI.Full: failure " Patchwork
2025-04-01 16:35 ` ✗ i915.CI.Full: " Patchwork
2025-04-03 12:22 ` ✓ i915.CI.Full: success " Patchwork
2025-04-06 12:34 ` ✗ Xe.CI.Full: failure for lib/igt_psr: Fix PSR active check for DisplayPort connectors (rev3) Patchwork
2025-04-06 13:24 ` ✗ Xe.CI.Full: failure for lib/igt_psr: Fix PSR active check for DisplayPort connectors (rev4) Patchwork
2025-04-06 17:51 ` ✗ Xe.CI.Full: failure for lib/igt_psr: Fix PSR active check for DisplayPort connectors (rev5) Patchwork
2025-04-06 22:34 ` ✗ Xe.CI.Full: failure for lib/igt_psr: Fix PSR active check for DisplayPort connectors (rev6) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a7f35b2c8f545bf4f89bc4f1c240e14e029a971.camel@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=animesh.manna@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jeevan.b@intel.com \
    --cc=ramanaidu.naladala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox