From: Erik Kurzinger <ekurzinger@nvidia.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH] syncobj_timeline: don't expect EINVAL for WAIT_UNSUBMITTED | WAIT_AVAILABLE
Date: Wed, 16 Aug 2023 09:17:56 -0700 [thread overview]
Message-ID: <7a8c0a3f-df18-ba3f-9c92-d341f2cb5a7d@nvidia.com> (raw)
The syncobj_timeline test expects waiting for an unsubmitted fence with
the WAIT_AVAILABLE flag set to fail with EINVAL. While this matches the
behavior of current kernels, that behavior is incorrect and will be
fixed by
https://lists.freedesktop.org/archives/dri-devel/2023-August/418710.html
With that fix, the WAIT_AVAILABLE flag will have the intended semantics
of waiting for an unsubmitted fence to be submitted instead of failing.
Note that this will cause the test to fail with kernels that lack the
fix, but such failures will reflect a genuine defect.
Signed-off-by: Erik Kurzinger <ekurzinger@nvidia.com>
---
tests/syncobj_timeline.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/syncobj_timeline.c b/tests/syncobj_timeline.c
index b4e1d093a..0422bca51 100644
--- a/tests/syncobj_timeline.c
+++ b/tests/syncobj_timeline.c
@@ -1782,7 +1782,7 @@ igt_main
WAIT_SIGNALED)) != 1)
continue;
- if ((flags & WAIT_UNSUBMITTED) && !(flags & WAIT_FOR_SUBMIT))
+ if ((flags & WAIT_UNSUBMITTED) && !((flags & WAIT_FOR_SUBMIT) || (flags & WAIT_AVAILABLE)))
err = -EINVAL;
else if (!(flags & WAIT_SIGNALED) && !((flags & WAIT_SUBMITTED) && (flags & WAIT_AVAILABLE)))
err = -ETIME;
@@ -1851,7 +1851,7 @@ igt_main
continue;
err = 0;
- if ((flags & WAIT_UNSUBMITTED) && !(flags & WAIT_FOR_SUBMIT)) {
+ if ((flags & WAIT_UNSUBMITTED) && !((flags & WAIT_FOR_SUBMIT) || (flags & WAIT_AVAILABLE))) {
err = -EINVAL;
} else if (flags & WAIT_ALL) {
if (flags & (WAIT_UNSUBMITTED | WAIT_SUBMITTED))
--
2.41.0
next reply other threads:[~2023-08-16 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 16:17 Erik Kurzinger [this message]
2023-08-16 18:23 ` [igt-dev] ✗ Fi.CI.BUILD: failure for syncobj_timeline: don't expect EINVAL for WAIT_UNSUBMITTED | WAIT_AVAILABLE Patchwork
2023-08-16 18:27 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
2023-08-21 10:26 ` [igt-dev] [PATCH] " Zbigniew Kempczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a8c0a3f-df18-ba3f-9c92-d341f2cb5a7d@nvidia.com \
--to=ekurzinger@nvidia.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox