Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nirmoy Das <nirmoy.das@intel.com>
To: Andrzej Hajda <andrzej.hajda@intel.com>, <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_balancer: skip noheartbeat test with GuC
Date: Mon, 29 May 2023 18:14:22 +0200	[thread overview]
Message-ID: <7ad9db60-99f4-f1ff-777a-d744c27a59ab@intel.com> (raw)
In-Reply-To: <20230529122104.391866-1-andrzej.hajda@intel.com>


On 5/29/2023 2:21 PM, Andrzej Hajda wrote:
> GuC does not support fully updating of persisting contexts, especially
> heartbeat related parameters.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3952
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
> Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>

> ---
> Hi,
>
> This is another case where GuC does not support runtime disabling
> heartbeat. I hope the last one.
>
> Regards
> Andrzej
> ---
>   tests/i915/gem_exec_balancer.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/tests/i915/gem_exec_balancer.c b/tests/i915/gem_exec_balancer.c
> index 3ab0903ac89..004ba9a14fe 100644
> --- a/tests/i915/gem_exec_balancer.c
> +++ b/tests/i915/gem_exec_balancer.c
> @@ -2938,6 +2938,8 @@ static void noheartbeat(int i915)
>   {
>   	const struct intel_execution_engine2 *e;
>   
> +	igt_require(!gem_using_guc_submission(i915));
> +
>   	/*
>   	 * Check that non-persistent contexts are also cleaned up if we
>   	 * close the context while they are active, but the engine's

  reply	other threads:[~2023-05-29 16:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-29 12:21 [igt-dev] [PATCH i-g-t] i915/gem_exec_balancer: skip noheartbeat test with GuC Andrzej Hajda
2023-05-29 16:14 ` Nirmoy Das [this message]
2023-05-30 14:00 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-05-31  5:21 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ad9db60-99f4-f1ff-777a-d744c27a59ab@intel.com \
    --to=nirmoy.das@intel.com \
    --cc=andrzej.hajda@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox