From: "Naladala, Ramanaidu" <ramanaidu.naladala@intel.com>
To: Bhanuprakash Modem <bhanuprakash.modem@intel.com>,
<igt-dev@lists.freedesktop.org>
Subject: Re: [i-g-t 2/2] Revert "lib/igt_psr: Fix PR state check for DisplayPort connectors"
Date: Wed, 11 Sep 2024 13:42:38 +0530 [thread overview]
Message-ID: <7b01eba3-5f55-40f7-8fa0-248a0e3085f4@intel.com> (raw)
In-Reply-To: <20240911075745.635978-2-bhanuprakash.modem@intel.com>
Acked-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
On 9/11/2024 1:27 PM, Bhanuprakash Modem wrote:
> Causing regression in CI BAT.
>
> This reverts commit 196c2cc9c945a66bb542fdefcf491ea62c1f885e.
>
> Issue: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2748
> Cc: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
> lib/igt_psr.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/lib/igt_psr.c b/lib/igt_psr.c
> index 4e44f44e6..e3e7577eb 100644
> --- a/lib/igt_psr.c
> +++ b/lib/igt_psr.c
> @@ -79,9 +79,8 @@ static bool psr_active_check(int debugfs_fd, enum psr_mode mode, igt_output_t *o
> c = output->config.connector;
> }
>
> - if (c->connector_type == DRM_MODE_CONNECTOR_DisplayPort)
> - state = "SRDENT_ON";
> - else if (mode == PR_MODE || mode == PR_MODE_SEL_FETCH)
> + if ((mode == PR_MODE || mode == PR_MODE_SEL_FETCH) &&
> + c && c->connector_type == DRM_MODE_CONNECTOR_eDP)
> state = "SLEEP";
> else if (mode == PSR_MODE_1 || mode == PR_MODE || mode == PR_MODE_SEL_FETCH)
> state = "SRDENT";
next prev parent reply other threads:[~2024-09-11 8:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 7:57 [i-g-t 1/2] Revert "lib/igt_psr: Remove SRD status change check for DP2.1 Panel Replay" Bhanuprakash Modem
2024-09-11 7:57 ` [i-g-t 2/2] Revert "lib/igt_psr: Fix PR state check for DisplayPort connectors" Bhanuprakash Modem
2024-09-11 8:12 ` Naladala, Ramanaidu [this message]
2024-09-11 8:14 ` [i-g-t 1/2] Revert "lib/igt_psr: Remove SRD status change check for DP2.1 Panel Replay" Naladala, Ramanaidu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b01eba3-5f55-40f7-8fa0-248a0e3085f4@intel.com \
--to=ramanaidu.naladala@intel.com \
--cc=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox