public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Summers, Stuart" <stuart.summers@intel.com>
To: "intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk>
Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_concurrent_blit: Do not try to idle while submitting in parallel
Date: Tue, 20 Aug 2019 00:50:29 +0000	[thread overview]
Message-ID: <7b246c2433d0d34f6def02fcd0c9d686d8b19e4e.camel@intel.com> (raw)
In-Reply-To: <20190818094900.8937-1-chris@chris-wilson.co.uk>


[-- Attachment #1.1: Type: text/plain, Size: 5002 bytes --]

On Sun, 2019-08-18 at 10:49 +0100, Chris Wilson wrote:
> If we try to idle while another thread is submitting, we will be
> forced
> to wait until that other thread is finished -- effectively
> serialising
> the parallel workloads, defeating said purpose.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Stuart Summers <stuart.summers@intel.com>

> ---
>  tests/i915/gem_concurrent_all.c | 17 -----------------
>  1 file changed, 17 deletions(-)
> 
> diff --git a/tests/i915/gem_concurrent_all.c
> b/tests/i915/gem_concurrent_all.c
> index 3ddaab820..266995d14 100644
> --- a/tests/i915/gem_concurrent_all.c
> +++ b/tests/i915/gem_concurrent_all.c
> @@ -968,8 +968,6 @@ static void do_basic0(struct buffers *buffers,
>  		      do_copy do_copy_func,
>  		      do_hang do_hang_func)
>  {
> -	gem_quiescent_gpu(fd);
> -
>  	buffers->mode->set_bo(buffers, buffers->src[0], 0xdeadbeef);
>  	for (int i = 0; i < buffers->count; i++) {
>  		igt_hang_t hang = do_hang_func();
> @@ -985,8 +983,6 @@ static void do_basic1(struct buffers *buffers,
>  		      do_copy do_copy_func,
>  		      do_hang do_hang_func)
>  {
> -	gem_quiescent_gpu(fd);
> -
>  	for (int i = 0; i < buffers->count; i++) {
>  		igt_hang_t hang = do_hang_func();
>  
> @@ -1007,8 +1003,6 @@ static void do_basicN(struct buffers *buffers,
>  {
>  	igt_hang_t hang;
>  
> -	gem_quiescent_gpu(fd);
> -
>  	for (int i = 0; i < buffers->count; i++) {
>  		buffers->mode->set_bo(buffers, buffers->src[i], i);
>  		buffers->mode->set_bo(buffers, buffers->dst[i], ~i);
> @@ -1034,7 +1028,6 @@ static void do_overwrite_source(struct buffers
> *buffers,
>  	igt_hang_t hang;
>  	int i;
>  
> -	gem_quiescent_gpu(fd);
>  	for (i = 0; i < buffers->count; i++) {
>  		buffers->mode->set_bo(buffers, buffers->src[i], i);
>  		buffers->mode->set_bo(buffers, buffers->dst[i], ~i);
> @@ -1058,7 +1051,6 @@ static void do_overwrite_source_read(struct
> buffers *buffers,
>  	igt_hang_t hang;
>  	int i;
>  
> -	gem_quiescent_gpu(fd);
>  	for (i = 0; i < half; i++) {
>  		buffers->mode->set_bo(buffers, buffers->src[i], i);
>  		buffers->mode->set_bo(buffers, buffers->dst[i], ~i);
> @@ -1102,7 +1094,6 @@ static void do_overwrite_source__rev(struct
> buffers *buffers,
>  	igt_hang_t hang;
>  	int i;
>  
> -	gem_quiescent_gpu(fd);
>  	for (i = 0; i < buffers->count; i++) {
>  		buffers->mode->set_bo(buffers, buffers->src[i], i);
>  		buffers->mode->set_bo(buffers, buffers->dst[i], ~i);
> @@ -1123,7 +1114,6 @@ static void do_overwrite_source__one(struct
> buffers *buffers,
>  {
>  	igt_hang_t hang;
>  
> -	gem_quiescent_gpu(fd);
>  	buffers->mode->set_bo(buffers, buffers->src[0], 0);
>  	buffers->mode->set_bo(buffers, buffers->dst[0], ~0);
>  	do_copy_func(buffers, buffers->dst[0], buffers->src[0]);
> @@ -1142,7 +1132,6 @@ static void do_intermix(struct buffers
> *buffers,
>  	igt_hang_t hang;
>  	int i;
>  
> -	gem_quiescent_gpu(fd);
>  	for (i = 0; i < buffers->count; i++) {
>  		buffers->mode->set_bo(buffers, buffers->src[i],
> 0xdeadbeef^~i);
>  		buffers->mode->set_bo(buffers, buffers->dst[i], i);
> @@ -1196,7 +1185,6 @@ static void do_early_read(struct buffers
> *buffers,
>  	igt_hang_t hang;
>  	int i;
>  
> -	gem_quiescent_gpu(fd);
>  	for (i = buffers->count; i--; )
>  		buffers->mode->set_bo(buffers, buffers->src[i],
> 0xdeadbeef);
>  	for (i = 0; i < buffers->count; i++)
> @@ -1214,7 +1202,6 @@ static void do_read_read_bcs(struct buffers
> *buffers,
>  	igt_hang_t hang;
>  	int i;
>  
> -	gem_quiescent_gpu(fd);
>  	for (i = buffers->count; i--; )
>  		buffers->mode->set_bo(buffers, buffers->src[i],
> 0xdeadbeef ^ i);
>  	for (i = 0; i < buffers->count; i++) {
> @@ -1235,7 +1222,6 @@ static void do_write_read_bcs(struct buffers
> *buffers,
>  	igt_hang_t hang;
>  	int i;
>  
> -	gem_quiescent_gpu(fd);
>  	for (i = buffers->count; i--; )
>  		buffers->mode->set_bo(buffers, buffers->src[i],
> 0xdeadbeef ^ i);
>  	for (i = 0; i < buffers->count; i++) {
> @@ -1255,7 +1241,6 @@ static void do_read_read_rcs(struct buffers
> *buffers,
>  	igt_hang_t hang;
>  	int i;
>  
> -	gem_quiescent_gpu(fd);
>  	for (i = buffers->count; i--; )
>  		buffers->mode->set_bo(buffers, buffers->src[i],
> 0xdeadbeef ^ i);
>  	for (i = 0; i < buffers->count; i++) {
> @@ -1276,7 +1261,6 @@ static void do_write_read_rcs(struct buffers
> *buffers,
>  	igt_hang_t hang;
>  	int i;
>  
> -	gem_quiescent_gpu(fd);
>  	for (i = buffers->count; i--; )
>  		buffers->mode->set_bo(buffers, buffers->src[i],
> 0xdeadbeef ^ i);
>  	for (i = 0; i < buffers->count; i++) {
> @@ -1296,7 +1280,6 @@ static void do_gpu_read_after_write(struct
> buffers *buffers,
>  	igt_hang_t hang;
>  	int i;
>  
> -	gem_quiescent_gpu(fd);
>  	for (i = buffers->count; i--; )
>  		buffers->mode->set_bo(buffers, buffers->src[i],
> 0xabcdabcd);
>  	for (i = 0; i < buffers->count; i++)

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3270 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

      parent reply	other threads:[~2019-08-20  0:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-18  9:49 [igt-dev] [PATCH i-g-t] i915/gem_concurrent_blit: Do not try to idle while submitting in parallel Chris Wilson
2019-08-18 10:52 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-08-18 14:49 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-08-20  0:50 ` Summers, Stuart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b246c2433d0d34f6def02fcd0c9d686d8b19e4e.camel@intel.com \
    --to=stuart.summers@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox