Re: [igt-dev] [PATCH i-g-t 1/2] tests/kms_available_modes_crc limit tested fb formats

["Juha-Pekka Heikkilä" <juhapekka.heikkila@gmail.com>]

Maarten Lankhorst kirjoitti 21.3.2019 klo 16.18:
> Op 19-03-2019 om 11:57 schreef Juha-Pekka Heikkila:
>> This test is causing too much useless noise. Limit tested
>> fb formats to DRM_FORMAT_C8 and DRM_FORMAT_XBGR2101010 for now.
>> These two formats are currently not tested otherwise thus
>> they're left here for now. DRM_FORMAT_XBGR2101010 need to be
>> included into IGT supported formats and DRM_FORMAT_C8 test need
>> to be moved elsewhere, maybe into kms_plane.
>>
>> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>> ---
>>   tests/kms_available_modes_crc.c | 289 ++++++++++++++++------------------------
>>   1 file changed, 116 insertions(+), 173 deletions(-)
>>
> I liked the fact we were testing the same white point everywhere, but I suppose
> 
> that's what kms_plane already does, and it makes sense to get rid of this. :)
> 
> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com
> 

Hei, thanks for the review :)

I was also pondering about future of this test as kms_plane does test 
everything in more comprehensive ways.

I was thinking once DRM_FORMAT_XBGR2101010 is made as IGT supported 
format I'd maybe rename this test to someting about C8 and keep this 
test. This is due to recently I saw there is some idea to have 
completely separate plane test 'just for comparison' as kms_plane didn't 
catch those errors where plane alpha was left at unexpected value. While 
kms_plane was saying all is ok this test was nagging all the time.

I'll push this patch tomorrow so this test stop nagging for now, I hope.

/Juha-Pekka
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev