Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Gil Dekel <gildekel@google.com>, igt-dev@lists.freedesktop.org
Cc: Gil Dekel <gildekel@google.com>,
	Swati Sharma <swati2.sharma@intel.com>,
	Karthik B S <karthik.b.s@intel.com>,
	Mark Yacoub <markyacoub@google.com>,
	kunal1.joshi@intel.com
Subject: Re: [PATCH i-g-t 0/3] lib/igt_hdr: Find HDR in DisplayID EDIDs
Date: Mon, 16 Nov 2026 11:40:12 +0200	[thread overview]
Message-ID: <7d0886fd698760ab0b2163f6853b64f76199d4ee@intel.com> (raw)
In-Reply-To: <20261114222911.1405626-1-gildekel@google.com>

On Sat, 14 Nov 2026, Gil Dekel <gildekel@google.com> wrote:
> igt_is_panel_hdr() only looks in CTA-861 extensions. eDP panels that
> describe HDR inside a DisplayID extension are therefore treated as SDR,
> and kms_hdr runs invalid-hdr on them, which then fails. Patch 1 splits
> the EDID parser out so it can be tested on the host, bounds it by the
> blob size, and adds lib/tests/igt_hdr. Patch 2 also walks the CTA data
> blocks inside DisplayID extensions. Patch 3 makes invalid-hdr read only
> the kernel log written by its own commit.

I suggested using libdisplay-info in IGT in April [1]. Has anything
happened in that front?

The more EDID parsing gets added to IGT, the harder it will be to
migrate, and the cost of maintaining the local parser increases.

BR,
Jani.


[1] https://lore.kernel.org/r/57222f9789fda352ed26606c1f80e35fcdeb3d37@intel.com


>
> Cc: Swati Sharma <swati2.sharma@intel.com>
> Cc: Karthik B S <karthik.b.s@intel.com>
> Cc: Mark Yacoub <markyacoub@google.com>
>
> Gil Dekel (3):
>   lib/igt_hdr: Add a testable igt_is_edid_hdr()
>   lib/igt_hdr: Parse DisplayID CTA data blocks
>   tests/kms_hdr: Use /dev/kmsg in invalid-hdr
>
>  lib/igt_hdr.c         | 147 ++++++++++++++++++++++++++++++++----------
>  lib/igt_hdr.h         |   1 +
>  lib/tests/igt_hdr.c   | 136 ++++++++++++++++++++++++++++++++++++++
>  lib/tests/meson.build |   1 +
>  tests/kms_hdr.c       |  49 +++++++++++++-
>  5 files changed, 300 insertions(+), 34 deletions(-)
>  create mode 100644 lib/tests/igt_hdr.c

-- 
Jani Nikula, Intel

  parent reply	other threads:[~2026-11-16  9:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-14 22:29 [PATCH i-g-t 0/3] lib/igt_hdr: Find HDR in DisplayID EDIDs Gil Dekel
2026-11-14 22:29 ` [PATCH i-g-t 1/3] lib/igt_hdr: Add a testable igt_is_edid_hdr() Gil Dekel
2026-11-14 22:29 ` [PATCH i-g-t 2/3] lib/igt_hdr: Parse DisplayID CTA data blocks Gil Dekel
2026-11-14 22:29 ` [PATCH i-g-t 3/3] tests/kms_hdr: Use /dev/kmsg in invalid-hdr Gil Dekel
2026-11-15  0:19 ` [PATCH i-g-t v2 0/3] lib/igt_hdr: Find HDR in DisplayID EDIDs Gil Dekel
2026-11-15  0:19   ` [PATCH i-g-t v2 1/3] lib/igt_hdr: Add a testable igt_is_edid_hdr() Gil Dekel
2026-11-15  0:19   ` [PATCH i-g-t v2 2/3] lib/igt_hdr: Parse DisplayID CTA data blocks Gil Dekel
2026-11-15  0:19   ` [PATCH i-g-t v2 3/3] tests/kms_hdr: Use /dev/kmsg in invalid-hdr Gil Dekel
2026-11-16  7:51 ` ✓ Xe.CI.BAT: success for lib/igt_hdr: Find HDR in DisplayID EDIDs Patchwork
2026-11-16  8:07 ` ✓ i915.CI.BAT: " Patchwork
2026-11-16  9:07 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-11-16  9:40 ` Jani Nikula [this message]
2026-11-17  3:13   ` [PATCH i-g-t 0/3] " Gil Dekel
2026-11-16 11:26 ` ✗ i915.CI.Full: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d0886fd698760ab0b2163f6853b64f76199d4ee@intel.com \
    --to=jani.nikula@intel.com \
    --cc=gildekel@google.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=karthik.b.s@intel.com \
    --cc=kunal1.joshi@intel.com \
    --cc=markyacoub@google.com \
    --cc=swati2.sharma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox