Re: [PATCH v4 10/10] tests/intel/xe_err_injection: add CRI GPU requirement check

["Purkait, Soham" <soham.purkait@intel.com>]

Hi Ravi,

On 03-09-2026 13:03, Ravi Kishore Koppuravuri wrote:
> Add support to verify the CRI GPU and skips test gracefully
> on non-cri platforms
>
> Cc: Purkait Soham <soham.purkait@intel.com>
> Cc: Riana Tauro <riana.tauro@intel.com>
> Cc: Gupta Anshuman <anshuman.gupta@intel.com>
> Cc: Jadav Raag <raag.jadav@intel.com>
> Cc: Nilawar Badal <badal.nilawar@intel.com>
> Cc: Koujalagi Mallesh <mallesh.koujalagi@intel.com>
> Cc: Harish Chegondi <harish.chegondi@intel.com>
> Signed-off-by: Ravi Kishore Koppuravuri <ravi.kishore.koppuravuri@intel.com>
> ---
>   tests/intel/xe_err_injection.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
>
> diff --git a/tests/intel/xe_err_injection.c b/tests/intel/xe_err_injection.c
> index cdf15f70b..5492c0b9a 100644
> --- a/tests/intel/xe_err_injection.c
> +++ b/tests/intel/xe_err_injection.c
> @@ -20,6 +20,7 @@
>   
>   #include "igt.h"
>   #include "lib/igt_drm_netlink.h"
> +#include "lib/intel_chipset.h"
>   #include "lib/intel_reg.h"
>   #include "lib/intel_compute.h"
>   
> @@ -569,6 +570,14 @@ static void test_l2_bank_single_corr_err_injection(struct xe_mmio *mmio, int fd)
>   	CLEANUP_ON_ERROR(ctx, fw_handle);
>   }
>   
> +static void igt_require_cri(int fd)

igt_require_cri() is a static local helper, so please drop the igt_ 
prefix and use a plain local name.

Thanks,
Soham
> +{
> +	uint16_t dev_id = xe_dev_id(fd);
> +
> +	igt_require_f(IS_CRESCENTISLAND(dev_id),
> +		      "This test requires CRI GPU, but found device ID 0x%04x\n", dev_id);
> +}
> +
>   static void inject_error(const char *injection, struct xe_mmio *mmio, int fd)
>   {
>   	igt_info("Starting Error Injection test: %s\n", injection);
> @@ -600,6 +609,11 @@ int igt_main()
>   	igt_fixture() {
>   		fd = drm_open_driver(DRIVER_XE);
>   		igt_require(igt_debugfs_exists(fd, "forcewake_all", O_RDONLY));
> +		igt_require_cri(fd);
> +		/*
> +		 * TODO: Add firmware query for error injection support.
> +		 * Should check: EOM (End of Manufacturing) status and error injection jumper state.
> +		 */
>   		xe_mmio_access_init(fd, &mmio);
>   		igt_require(xe_mmio_is_initialized(&mmio));
>   	}