From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id E0AB810E664 for ; Thu, 3 Aug 2023 21:11:38 +0000 (UTC) Message-ID: <7f16bc86-d81d-5065-3a23-afdc5e49b214@intel.com> Date: Thu, 3 Aug 2023 23:11:19 +0200 MIME-Version: 1.0 Content-Language: en-US To: =?UTF-8?Q?Zbigniew_Kempczy=c5=84ski?= , igt-dev@lists.freedesktop.org References: <20230803074902.172493-1-zbigniew.kempczynski@intel.com> <20230803074902.172493-2-zbigniew.kempczynski@intel.com> From: "Manszewski, Christoph" In-Reply-To: <20230803074902.172493-2-zbigniew.kempczynski@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [igt-dev] [PATCH i-g-t 1/2] lib/media_fill: Use RENDER engine flag to work on Xe List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Hi Zbigniew, On 3.08.2023 09:49, Zbigniew Kempczyński wrote: > Due to explicit requirement of running on valid hw engine on xe > change I915_EXEC_DEFAULT to I915_EXEC_RENDER. This change doesn't > break i915 media pipeline allowing to create and assign valid xe > engine to execute media fill test. > > Signed-off-by: Zbigniew Kempczyński > Cc: Christoph Manszewski > --- > lib/media_fill.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/media_fill.c b/lib/media_fill.c > index e80dae1505..2520995d97 100644 > --- a/lib/media_fill.c > +++ b/lib/media_fill.c > @@ -281,7 +281,7 @@ __gen9_media_fillfunc(int i915, > intel_bb_ptr_align(ibb, 32); > > intel_bb_exec(ibb, intel_bb_offset(ibb), > - I915_EXEC_DEFAULT | I915_EXEC_NO_RELOC, true); > + I915_EXEC_RENDER | I915_EXEC_NO_RELOC, true); As discussed offline - since we are the ones doing the i915 to xe engine type conversion, we could as well translate 'I915_EXEC_DEFAULT' to 'DRM_XE_ENGINE_CLASS_RENDER'. But I think it's a minor thing, besides I already reviewed a similar change in gpgpu_fill so: Reviewed-by: Christoph Manszewski Christoph > > intel_bb_destroy(ibb); > }