From: "Ser, Simon" <simon.ser@intel.com>
To: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
"Argenziano, Antonio" <antonio.argenziano@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] lib/igt.h: Guard igt_alsa.h in HAVE_CHAMELIUM guard
Date: Tue, 21 May 2019 07:10:20 +0000 [thread overview]
Message-ID: <7fada86f183e8ca15d70e2fe4a0d9af6424c75b6.camel@intel.com> (raw)
In-Reply-To: <20190520183907.8643-1-antonio.argenziano@intel.com>
On Mon, 2019-05-20 at 11:39 -0700, Antonio Argenziano wrote:
> The alsa library is only guaranteed to exists is the HAVE_CHAMELIUM flag
> is set.
>
> Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
> Cc: Simon Ser <simon.ser@intel.com>
Thanks for the fix!
Reviewed-by: Simon Ser <simon.ser@intel.com>
and pushed.
> ---
> lib/igt.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/igt.h b/lib/igt.h
> index 5852d557..2ae43c30 100644
> --- a/lib/igt.h
> +++ b/lib/igt.h
> @@ -35,13 +35,13 @@
> #include "igt_dummyload.h"
> #include "igt_fb.h"
> #include "igt_frame.h"
> -#include "igt_alsa.h"
> #include "igt_audio.h"
> #include "igt_gt.h"
> #include "igt_kms.h"
> #include "igt_pm.h"
> #include "igt_stats.h"
> #ifdef HAVE_CHAMELIUM
> +#include "igt_alsa.h"
> #include "igt_chamelium.h"
> #include "igt_chamelium_stream.h"
> #endif
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-05-21 7:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 18:39 [igt-dev] [PATCH i-g-t] lib/igt.h: Guard igt_alsa.h in HAVE_CHAMELIUM guard Antonio Argenziano
2019-05-21 7:10 ` Ser, Simon [this message]
2019-05-21 9:58 ` [igt-dev] ✗ Fi.CI.BAT: failure for lib/igt.h: Guard igt_alsa.h in HAVE_CHAMELIUM guard (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fada86f183e8ca15d70e2fe4a0d9af6424c75b6.camel@intel.com \
--to=simon.ser@intel.com \
--cc=antonio.argenziano@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox