On 5/8/2024 7:22 AM, Kamil Konieczny wrote:
> Hi Jagmeet,
> On 2024-05-07 at 12:23:12 -0700, Jagmeet Randhawa wrote:
>> Fix typos to follow proper format.
> While at it could you also rephrase it somewhat?
> See below, no need for sending new version, just
> reply in this thread.
>
> After agreement I could merge it with ack from Jonathan.
>
>> Cc: Jonathan Cavitt<jonathan.cavitt@intel.com>
>> Signed-off-by: Jagmeet Randhawa<jagmeet.randhawa@intel.com>
>> ---
>>   lib/xe/xe_spin.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/lib/xe/xe_spin.c b/lib/xe/xe_spin.c
>> index 381e5e950..2dbd51199 100644
>> --- a/lib/xe/xe_spin.c
>> +++ b/lib/xe/xe_spin.c
>> @@ -162,7 +162,7 @@ void xe_spin_init(struct xe_spin *spin, struct xe_spin_opts *opts)
>>    * xe_spin_started:
>>    * @spin: pointer to spinner mapped bo
>>    *
>> - * Returns: true if spinner is running, othwerwise false.
>> + * Returns: true if spinner is running, otherwise false.
>>    */
>>   bool xe_spin_started(struct xe_spin *spin)
>>   {
>> @@ -262,8 +262,8 @@ void xe_spin_sync_wait(int fd, struct igt_spin *spin)
>>    * xe_spin_free:
>>    * @spin: spin state from igt_spin_new()
>>    *
>> - * Wrapper to free spinner whhich is triggered by xe_spin_create.
>> - * which distroys vm, exec_queue and unbinds the vm which is binded to
>> + * Wrapper to free spinner which is triggered by xe_spin_create.
>> + * which destroys vm, exec_queue and unbinds the vm which is binded to
> imho better would be:
>
>   * Wrapper to free spinner created by xe_spin_create. It will
>   * destroy vm, exec_queue and unbind the vm which was binded to
>
> What you think? Jonathan? Btw 'triggered by' could stay, no strong
> opinion for 'created by'.
>
> Regards,
> Kamil
Hey Kamil, I agree with you. Your description is more clean. I think

'created by' is a better fit.  If Jonathan is in agreement, we should also

change the subject to "[PATCH i-g-t] lib/xe/xe_spin: Improve comments 
and fix typos"

as you mentioned.


>>    * the exec_queue and bo.
>>    *
>>    */
>> -- 
>> 2.25.1
>>