From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 4600689ABA for ; Thu, 10 Jan 2019 10:43:43 +0000 (UTC) Message-ID: <815f61f910f76a1ce4294aef8f1d1fc6d3348a74.camel@bootlin.com> From: Paul Kocialkowski Date: Thu, 10 Jan 2019 11:43:41 +0100 In-Reply-To: <20190108152001.5367-5-maxime.ripard@bootlin.com> References: <20190108152001.5367-5-maxime.ripard@bootlin.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v2 05/13] igt: fb: Move size computation to the common path List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Maxime Ripard , igt-dev@lists.freedesktop.org Cc: Petri Latvala , eben@raspberrypi.org, Thomas Petazzoni List-ID: SGksCgpPbiBUdWUsIDIwMTktMDEtMDggYXQgMTY6MTkgKzAxMDAsIE1heGltZSBSaXBhcmQgd3Jv dGU6Cj4gSW4gb3JkZXIgdG8gcHJvcGVybHkgc3VwcG9ydCB0aGUgWVVWIGJ1ZmZlciBvbiBub24t aTkxNSBwbGF0Zm9ybXMsIHdlIG5lZWQKPiB0byBydW4gY2FsY19mYl9zaXplIGZvciB0aGUgZHVt YiBidWZmZXJzIGFsbG9jYXRpb24gcGF0aCB0b28uIE1vdmUgaXQgb3V0Cj4gb2YgdGhlIHNwZWNp YWwgY2FzZSBhbmQgaW4gdGhlIGNvbW1vbiBjb2RlIHBhdGguCgpBY3R1YWxseSwgSSBoYXZlIG9u ZSBtaW5vciBjb21tZW50IGJlbG93LgoKPiBTaWduZWQtb2ZmLWJ5OiBNYXhpbWUgUmlwYXJkIDxt YXhpbWUucmlwYXJkQGJvb3RsaW4uY29tPgo+IC0tLQo+ICBsaWIvaWd0X2ZiLmMgfCAxMiArKysr Ky0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMo LSkKPiAKPiBkaWZmIC0tZ2l0IGEvbGliL2lndF9mYi5jIGIvbGliL2lndF9mYi5jCj4gaW5kZXgg ZDY5YzNmYjJkMzhkLi4zMWU0NGQ2MTg4ZDkgMTAwNjQ0Cj4gLS0tIGEvbGliL2lndF9mYi5jCj4g KysrIGIvbGliL2lndF9mYi5jCj4gQEAgLTUyOCwxNiArNTI4LDE0IEBAIHN0YXRpYyB2b2lkIGNs ZWFyX3l1dl9idWZmZXIoc3RydWN0IGlndF9mYiAqZmIpCj4gIC8qIGhlbHBlcnMgdG8gY3JlYXRl IG5pY2UtbG9va2luZyBmcmFtZWJ1ZmZlcnMgKi8KPiAgc3RhdGljIGludCBjcmVhdGVfYm9fZm9y X2ZiKHN0cnVjdCBpZ3RfZmIgKmZiKQo+ICB7Cj4gKwl1aW50NjRfdCBzaXplID0gY2FsY19mYl9z aXplKGZiKTsKPiAgCWludCBmZCA9IGZiLT5mZDsKPiAgCj4gKwkvKiByZXNwZWN0IHRoZSBzaXpl IHJlcXVlc3RlZCBieSB0aGUgY2FsbGVyICovCj4gKwlpZiAoZmItPnNpemUgPT0gMCkKPiArCQlm Yi0+c2l6ZSA9IHNpemU7Cj4gKwo+ICAJaWYgKGZiLT50aWxpbmcgfHwgZmItPnNpemUgfHwgZmIt PnN0cmlkZXNbMF0gfHwgaWd0X2Zvcm1hdF9pc195dXYoZmItPmRybV9mb3JtYXQpKSB7CgpDYWxs aW5nIGNhbGNfZmJfc2l6ZSB3aGVuIHRoZSBmdW5jdGlvbiBiZWdpbnMgd2lsbCBhdXRvbWF0aWNh bGx5IHNldAp0aGUgc3RyaWRlcyBpZiBpdCB3YXMgcHJldmlvdXNseSAwLCBzbyB3ZSBjYW4gZHJv cCB0aGUgInx8IGZiLQo+c3RyaWRlc1swXSIgaGVyZSAod2lsbCBuZXZlciBoYXBwZW4pLgoKR2Vu ZXJhbGx5IHNwZWFraW5nLCBJIHRoaW5rIGl0IHdvdWxkIGJlIG11Y2ggbW9yZSBzaW1wbGUgdG8g YWx3YXlzIGdvCndpdGggaTkxNSBnZW0gY3JlYXRlIGluc3RlYWQgb2YgZHVtYiBhbGxvYyBhcyBz b29uIGFzIGk5MTUgaXMgZGV0ZWN0ZWQKYW5kIGRyb3AgYWxsIHRoZXNlIGNvbmRpdGlvbnMuCgpJ IGNhbid0IHNlZSB3aHkgZHVtYiBidWZmZXIgd291bGQgYmUgcHJlZmVyYWJsZSwgYnV0IEkgbWln aHQgYmUgbWlzc2luZwpzb21ldGhpbmcgaGVyZSAoaTkxNSBkZXZlbG9wZXJzLCBmZWVsIGZyZWUg dG8gcG9pbnQgaXQgb3V0IGlmIHRoYXQncwp0aGUgY2FzZSkhCgpDaGVlcnMsCgpQYXVsCgo+IC0J CXVpbnQ2NF90IHNpemU7Cj4gLQo+IC0JCXNpemUgPSBjYWxjX2ZiX3NpemUoZmIpOwo+IC0KPiAt CQkvKiByZXNwZWN0IHRoZSBzaXplIHJlcXVlc3RlZCBieSB0aGUgY2FsbGVyICovCj4gLQkJaWYg KGZiLT5zaXplID09IDApCj4gLQkJCWZiLT5zaXplID0gc2l6ZTsKPiAgCj4gIAkJZmItPmlzX2R1 bWIgPSBmYWxzZTsKPiAgCi0tIApQYXVsIEtvY2lhbGtvd3NraSwgQm9vdGxpbgpFbWJlZGRlZCBM aW51eCBhbmQga2VybmVsIGVuZ2luZWVyaW5nCmh0dHBzOi8vYm9vdGxpbi5jb20KCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlndC1kZXYgbWFpbGluZyBs aXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgo=