From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id DBD9A10E1B2 for ; Mon, 11 Sep 2023 15:08:44 +0000 (UTC) Message-ID: <81bcf6b5-5fe9-0d44-7f14-da035bdd94d1@intel.com> Date: Mon, 11 Sep 2023 20:38:31 +0530 MIME-Version: 1.0 Content-Language: en-US To: "Modem, Bhanuprakash" , igt-dev@lists.freedesktop.org References: <20230908175039.1291593-1-swati2.sharma@intel.com> <20230908175039.1291593-3-swati2.sharma@intel.com> <75bdc363-2e93-5f1f-90de-4c99d49d85d3@intel.com> From: "Sharma, Swati2" In-Reply-To: <75bdc363-2e93-5f1f-90de-4c99d49d85d3@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [igt-dev] [PATCH i-g-t 2/5] tests/intel/kms_pm_lpsp: Add XE support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 11-Sep-23 8:14 PM, Modem, Bhanuprakash wrote: > Hi Swati, > > On Fri-08-09-2023 11:20 pm, Swati Sharma wrote: >> Add XE driver support for kms pm tests. >> >> Signed-off-by: Swati Sharma >> --- >>   tests/intel/kms_pm_lpsp.c | 6 +++--- >>   1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/tests/intel/kms_pm_lpsp.c b/tests/intel/kms_pm_lpsp.c >> index 9b5547cda..7d697b1e2 100644 >> --- a/tests/intel/kms_pm_lpsp.c >> +++ b/tests/intel/kms_pm_lpsp.c >> @@ -39,7 +39,7 @@ >>    * >>    * SUBTEST: kms-lpsp >>    * Description: This test validates lpsp on all connected outputs on >> low power PIPE_A >> - * Driver requirement: i915 >> + * Driver requirement: i915, xe >>    * Functionality: pm_lpsp >>    * Mega feature: Display Power >>    * Run type: FULL >> @@ -194,8 +194,7 @@ igt_main >>       data_t data = {}; >>       igt_fixture { >> - >> -        data.drm_fd = drm_open_driver_master(DRIVER_INTEL); >> +        data.drm_fd = drm_open_driver_master(DRIVER_INTEL | DRIVER_XE); >>           igt_require(data.drm_fd >= 0); >>           data.debugfs_fd = igt_debugfs_dir(data.drm_fd); >>           igt_require(data.debugfs_fd >= 0); >> @@ -208,6 +207,7 @@ igt_main >>       igt_describe("This test validates lpsp while all crtc are >> disabled"); >>       igt_subtest("screens-disabled") { >> +        igt_require_i915(data.drm_fd); > > Why it is i915 specific? This test has no ROI if platform supports DC states. Test requirement not met in function __igt_unique____real_main192, file ../../../usr/src/igt-gpu-tools/tests/intel/kms_pm_lpsp.c:211: Test requirement: !dmc_supported(data.debugfs_fd) DC states supported platform don't have ROI for this subtest Subtest screens-disabled: SKIP (0.000s) xe+ we have all platforms supporting dc states, so we can skip this test for xe. > > - Bhanu > >>           igt_require_f(!dmc_supported(data.debugfs_fd), >>                     "DC states supported platform don't have ROI for >> this subtest\n"); >>           screens_disabled_subtest(&data);