From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 81BF689DC7 for ; Thu, 21 Mar 2019 07:06:27 +0000 (UTC) References: <20190321010015.1317-1-andi.shyti@intel.com> <20190321010015.1317-3-andi.shyti@intel.com> From: Tvrtko Ursulin Message-ID: <81dac4f3-9dd0-fe99-7af8-69499501de20@linux.intel.com> Date: Thu, 21 Mar 2019 07:06:24 +0000 MIME-Version: 1.0 In-Reply-To: <20190321010015.1317-3-andi.shyti@intel.com> Content-Language: en-US Subject: Re: [igt-dev] [PATCH v14 2/5] lib: ioctl_wrappers: reach engines by index as well List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Andi Shyti , IGT dev Cc: Andi Shyti List-ID: Ck9uIDIxLzAzLzIwMTkgMDE6MDAsIEFuZGkgU2h5dGkgd3JvdGU6Cj4gV2l0aCB0aGUgbmV3IGVu Z2luZSBxdWVyeSBtZXRob2QgZW5naW5lcyBhcmUgcmVhY2hhYmxlIHRocm91Z2gKPiBhbiBpbmRl eCBhbmQgY29udGV4dCB0aGV5IGFyZSBjb21iaW5lZCB3aXRoLgo+IAo+IFRoZSAnZ2VtX2hhc19y aW5nKCknIGJlY29tZXMgJ2dlbV9jb250ZXh0X2hhc19lbmdpbmUoKScgdGhhdAo+IHJlcXVpcmVz IHRoZSBpbmRleCB0aGF0IHRoZSBlbmdpbmUgaXMgbWFwcGVkIHdpdGhpbiB0aGUgZHJpdmVyLgo+ IFRoZSBmdW5jdGlvbiBoYXMgYmVlbiBtb3ZlZCBmcm9tIGxpYi9pb2N0bF93YXBwZXJzIHRvCj4g bGliL2k5MTUvZ2VtX2NvbnRleHQgd2hlcmUgaXQgaXMgbW9yZSBhcHByb3ByaWF0ZS4KPiAKPiBU aGUgcHJldmlvdXMgJ2dlbV9oYXNfcmluZygpJyBmdW5jdGlvbiBiZWNvbWVzIGEgd3JhcHBlciB0 byB0aGUKPiBuZXcgJ2dlbV9jb250ZXh0X2hhc19lbmdpbmUoKScuCj4gCj4gU2lnbmVkLW9mZi1i eTogQW5kaSBTaHl0aSA8YW5kaS5zaHl0aUBpbnRlbC5jb20+Cj4gUmV2aWV3ZWQtYnk6IENocmlz IFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IC0tLQo+ICAgbGliL2k5MTUvZ2Vt X2NvbnRleHQuYyB8IDIxICsrKysrKysrKysrKysrKysrKysrKwo+ICAgbGliL2k5MTUvZ2VtX2Nv bnRleHQuaCB8ICAyICsrCj4gICBsaWIvaW9jdGxfd3JhcHBlcnMuYyAgIHwgMTkgLS0tLS0tLS0t LS0tLS0tLS0tLQo+ICAgbGliL2lvY3RsX3dyYXBwZXJzLmggICB8ICAzICsrLQo+ICAgNCBmaWxl cyBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspLCAyMCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0t Z2l0IGEvbGliL2k5MTUvZ2VtX2NvbnRleHQuYyBiL2xpYi9pOTE1L2dlbV9jb250ZXh0LmMKPiBp bmRleCAxNjAwNDY4NWU5MjAuLjVlMmUzMWU5MTM4NCAxMDA2NDQKPiAtLS0gYS9saWIvaTkxNS9n ZW1fY29udGV4dC5jCj4gKysrIGIvbGliL2k5MTUvZ2VtX2NvbnRleHQuYwo+IEBAIC0yNzUsMyAr Mjc1LDI0IEBAIHZvaWQgZ2VtX2NvbnRleHRfc2V0X3ByaW9yaXR5KGludCBmZCwgdWludDMyX3Qg Y3R4X2lkLCBpbnQgcHJpbykKPiAgIHsKPiAgIAlpZ3RfYXNzZXJ0KF9fZ2VtX2NvbnRleHRfc2V0 X3ByaW9yaXR5KGZkLCBjdHhfaWQsIHByaW8pID09IDApOwo+ICAgfQo+ICsKPiArYm9vbCBnZW1f Y29udGV4dF9oYXNfZW5naW5lKGludCBmZCwgdW5zaWduZWQgZW5naW5lLCB1bnNpZ25lZCBjdHgp CgpXaGF0IENocmlzIHNhaWQgYW5kIHVpbjMyX3QgZm9yIGN0eCBpcyB0aGUgdXN1YWwgdHlwZS4K Cj4gK3sKPiArCXN0cnVjdCBkcm1faTkxNV9nZW1fZXhlY2J1ZmZlcjIgZXhlY2J1ZjsKPiArCXN0 cnVjdCBkcm1faTkxNV9nZW1fZXhlY19vYmplY3QyIGV4ZWM7Cj4gKwo+ICsJLyogc2lsbHkgQUJJ LCB0aGUga2VybmVsIHRoaW5rcyBldmVyeW9uZSB3aG8gaGFzIEJTRCBhbHNvIGhhcyBCU0QyICov Cj4gKwlpZiAoKGVuZ2luZSAmIH4oMzw8MTMpKSA9PSBJOTE1X0VYRUNfQlNEKSB7Cj4gKwkJaWYg KGVuZ2luZSAmICgzIDw8IDEzKSAmJiAhZ2VtX2hhc19ic2QyKGZkKSkKPiArCQkJcmV0dXJuIGZh bHNlOwo+ICsJfQoKVGhpcyB3aWxsIGx1Y2tpbHkgYmUgYSBuby1vcCBvbiBlbmdpbmUgbWFwcyBk dWUgYml0cyBzbyBoaWdoIG5ldmVyIHNldCAKYnV0IEkgd29uZGVyIGlmIGF0IGxlYXN0IGEgY29t bWVudCBpcyB3YXJyYW50ZWQuCgpSZWdhcmRzLAoKVHZydGtvCgo+ICsKPiArCW1lbXNldCgmZXhl YywgMCwgc2l6ZW9mKGV4ZWMpKTsKPiArCW1lbXNldCgmZXhlY2J1ZiwgMCwgc2l6ZW9mKGV4ZWNi dWYpKTsKPiArCWV4ZWNidWYuYnVmZmVyc19wdHIgPSB0b191c2VyX3BvaW50ZXIoJmV4ZWMpOwo+ ICsJZXhlY2J1Zi5idWZmZXJfY291bnQgPSAxOwo+ICsJZXhlY2J1Zi5mbGFncyA9IGVuZ2luZTsK PiArCWV4ZWNidWYucnN2ZDEgPSBjdHg7Cj4gKwo+ICsJcmV0dXJuIF9fZ2VtX2V4ZWNidWYoZmQs ICZleGVjYnVmKSA9PSAtRU5PRU5UOwo+ICt9Cj4gZGlmZiAtLWdpdCBhL2xpYi9pOTE1L2dlbV9j b250ZXh0LmggYi9saWIvaTkxNS9nZW1fY29udGV4dC5oCj4gaW5kZXggYWVmNjhkZGE2YjI2Li5k ZDY0ZWJmMTdmYmQgMTAwNjQ0Cj4gLS0tIGEvbGliL2k5MTUvZ2VtX2NvbnRleHQuaAo+ICsrKyBi L2xpYi9pOTE1L2dlbV9jb250ZXh0LmgKPiBAQCAtNDUsNCArNDUsNiBAQCBpbnQgX19nZW1fY29u dGV4dF9nZXRfcGFyYW0oaW50IGZkLCBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX2NvbnRleHRfcGFyYW0g KnApOwo+ICAgaW50IF9fZ2VtX2NvbnRleHRfc2V0X3ByaW9yaXR5KGludCBmZCwgdWludDMyX3Qg Y3R4LCBpbnQgcHJpbyk7Cj4gICB2b2lkIGdlbV9jb250ZXh0X3NldF9wcmlvcml0eShpbnQgZmQs IHVpbnQzMl90IGN0eCwgaW50IHByaW8pOwo+ICAgCj4gK2Jvb2wgZ2VtX2NvbnRleHRfaGFzX2Vu Z2luZShpbnQgZmQsIHVuc2lnbmVkIGVuZ2luZSwgdW5zaWduZWQgY3R4KTsKPiArCj4gICAjZW5k aWYgLyogR0VNX0NPTlRFWFRfSCAqLwo+IGRpZmYgLS1naXQgYS9saWIvaW9jdGxfd3JhcHBlcnMu YyBiL2xpYi9pb2N0bF93cmFwcGVycy5jCj4gaW5kZXggYTY2ZWI0YmMwZjRmLi4zZjhmMDg3NGJj NGIgMTAwNjQ0Cj4gLS0tIGEvbGliL2lvY3RsX3dyYXBwZXJzLmMKPiArKysgYi9saWIvaW9jdGxf d3JhcHBlcnMuYwo+IEBAIC0xMjUzLDI1ICsxMjUzLDYgQEAgdm9pZCBpZ3RfcmVxdWlyZV9nZW0o aW50IGZkKQo+ICAgCWlndF9yZXF1aXJlX2YoZXJyID09IDAsICJVbnJlc3BvbnNpdmUgaTkxNS9H RU0gZGV2aWNlXG4iKTsKPiAgIH0KPiAgIAo+IC1ib29sIGdlbV9oYXNfcmluZyhpbnQgZmQsIHVu c2lnbmVkIHJpbmcpCj4gLXsKPiAtCXN0cnVjdCBkcm1faTkxNV9nZW1fZXhlY2J1ZmZlcjIgZXhl Y2J1ZjsKPiAtCXN0cnVjdCBkcm1faTkxNV9nZW1fZXhlY19vYmplY3QyIGV4ZWM7Cj4gLQo+IC0J Lyogc2lsbHkgQUJJLCB0aGUga2VybmVsIHRoaW5rcyBldmVyeW9uZSB3aG8gaGFzIEJTRCBhbHNv IGhhcyBCU0QyICovCj4gLQlpZiAoKHJpbmcgJiB+KDM8PDEzKSkgPT0gSTkxNV9FWEVDX0JTRCkg ewo+IC0JCWlmIChyaW5nICYgKDMgPDwgMTMpICYmICFnZW1faGFzX2JzZDIoZmQpKQo+IC0JCQly ZXR1cm4gZmFsc2U7Cj4gLQl9Cj4gLQo+IC0JbWVtc2V0KCZleGVjLCAwLCBzaXplb2YoZXhlYykp Owo+IC0JbWVtc2V0KCZleGVjYnVmLCAwLCBzaXplb2YoZXhlY2J1ZikpOwo+IC0JZXhlY2J1Zi5i dWZmZXJzX3B0ciA9IHRvX3VzZXJfcG9pbnRlcigmZXhlYyk7Cj4gLQlleGVjYnVmLmJ1ZmZlcl9j b3VudCA9IDE7Cj4gLQlleGVjYnVmLmZsYWdzID0gcmluZzsKPiAtCXJldHVybiBfX2dlbV9leGVj YnVmKGZkLCAmZXhlY2J1ZikgPT0gLUVOT0VOVDsKPiAtfQo+IC0KPiAgIC8qKgo+ICAgICogZ2Vt X3JlcXVpcmVfcmluZzoKPiAgICAqIEBmZDogb3BlbiBpOTE1IGRybSBmaWxlIGRlc2NyaXB0b3IK PiBkaWZmIC0tZ2l0IGEvbGliL2lvY3RsX3dyYXBwZXJzLmggYi9saWIvaW9jdGxfd3JhcHBlcnMu aAo+IGluZGV4IGFkOTNkYWZmY2ZkNS4uODc3MGU1OTFlNzkwIDEwMDY0NAo+IC0tLSBhL2xpYi9p b2N0bF93cmFwcGVycy5oCj4gKysrIGIvbGliL2lvY3RsX3dyYXBwZXJzLmgKPiBAQCAtMTQyLDEx ICsxNDIsMTIgQEAgYm9vbCBnZW1faGFzX2V4ZWNfZmVuY2UoaW50IGZkKTsKPiAgIAo+ICAgLyog Y2hlY2sgZnVuY3Rpb25zIHdoaWNoIGF1dG8tc2tpcCB0ZXN0cyBieSBjYWxsaW5nIGlndF9za2lw KCkgKi8KPiAgIHZvaWQgZ2VtX3JlcXVpcmVfY2FjaGluZyhpbnQgZmQpOwo+IC1ib29sIGdlbV9o YXNfcmluZyhpbnQgZmQsIHVuc2lnbmVkIHJpbmcpOwo+ICAgdm9pZCBnZW1fcmVxdWlyZV9yaW5n KGludCBmZCwgdW5zaWduZWQgcmluZyk7Cj4gICBib29sIGdlbV9oYXNfbW9jc19yZWdpc3RlcnMo aW50IGZkKTsKPiAgIHZvaWQgZ2VtX3JlcXVpcmVfbW9jc19yZWdpc3RlcnMoaW50IGZkKTsKPiAg IAo+ICsjZGVmaW5lIGdlbV9oYXNfcmluZyhmLCByKSBnZW1fY29udGV4dF9oYXNfZW5naW5lKGYs IHIsIDApCj4gKwo+ICAgLyogcHJpbWUgKi8KPiAgIHN0cnVjdCBsb2NhbF9kbWFfYnVmX3N5bmMg ewo+ICAgCXVpbnQ2NF90IGZsYWdzOwo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2lndC1kZXY=