public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t v2] tests/kms_crtc_background_color: overhaul for latest ABI proposal (v2)
Date: Tue, 13 Nov 2018 23:43:12 +0000	[thread overview]
Message-ID: <8275fd1b-5a61-7f48-6817-e0fdad42d0dc@intel.com> (raw)
In-Reply-To: <20181113232256.22828-1-matthew.d.roper@intel.com>

On 13/11/2018 23:22, Matt Roper wrote:
> It's worth noting that we don't seem to be able to test this feature
> with CRC's.  Originally we wanted to draw a color into a plane's FB
> (with Cairo) and then compare the CRC to turning off all planes and just
> setting the CRTC background to the same color.  However the precision
> and rounding of the color components causes the CRC's to come out
> differently, even though the end result is visually identical.  So at
> the moment this test is mainly useful for visual inspection in
> interactive mode.
Hey Matt,
Out of curiosity, are the CRCs different only when with 16bpc? Or with 
8bpc too?

Thanks,

-
Lionel



_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2018-11-13 23:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20181113232149.22753-1-matthew.d.roper@intel.com>
2018-11-13 23:22 ` [igt-dev] [PATCH i-g-t v2] tests/kms_crtc_background_color: overhaul for latest ABI proposal (v2) Matt Roper
2018-11-13 23:43   ` Lionel Landwerlin [this message]
2018-11-13 23:53     ` [igt-dev] [Intel-gfx] " Matt Roper
2018-11-14  1:34 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-11-14  4:48 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8275fd1b-5a61-7f48-6817-e0fdad42d0dc@intel.com \
    --to=lionel.g.landwerlin@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox