From: "Kahola, Mika" <mika.kahola@intel.com>
To: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>,
"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_flip_scaled_crc: skip test if no requested mode and exceed cdclk limits
Date: Tue, 30 Mar 2021 12:34:04 +0000 [thread overview]
Message-ID: <82eb1d95afcd4383ac8a15e2a2d64e48@intel.com> (raw)
In-Reply-To: <20210325171222.26283-1-juhapekka.heikkila@gmail.com>
> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Juha-
> Pekka Heikkila
> Sent: Thursday, March 25, 2021 7:12 PM
> To: igt-dev@lists.freedesktop.org
> Subject: [igt-dev] [PATCH i-g-t] tests/kms_flip_scaled_crc: skip test if no
> requested mode and exceed cdclk limits
>
> If there was no requested 640p or 1080p mode available in connector and
> flipping to scaled fb fail with einval assume cdclk limits were exceeded and
> skip test instead of failing.
>
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Reviewed-by: Mika Kahola <mika.kahola@intel.com>
> ---
> tests/kms_flip_scaled_crc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/kms_flip_scaled_crc.c b/tests/kms_flip_scaled_crc.c index
> c41709b68..35417396e 100644
> --- a/tests/kms_flip_scaled_crc.c
> +++ b/tests/kms_flip_scaled_crc.c
> @@ -204,6 +204,9 @@ static void test_flip_to_scaled(data_t *data, uint32_t
> index, enum pipe pipe,
>
> igt_require_f(ret != -ERANGE,
> "Platform scaling limits exceeded, skipping.\n");
> + igt_require_f(!(ret == -EINVAL && !modetoset),
> + "No %dp and default mode too big, cdclk limits exceeded.
> Skipping.\n",
> + data->attemptmodeheight);
> igt_assert_eq(ret, 0);
>
> igt_assert(read(data->drm_fd, &ev, sizeof(ev)) == sizeof(ev));
> --
> 2.28.0
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2021-03-30 12:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 17:12 [igt-dev] [PATCH i-g-t] tests/kms_flip_scaled_crc: skip test if no requested mode and exceed cdclk limits Juha-Pekka Heikkila
2021-03-25 18:22 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-03-25 22:48 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-03-29 12:02 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_flip_scaled_crc: skip test if no requested mode and exceed cdclk limits (rev2) Patchwork
2021-03-29 13:31 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-03-30 12:34 ` Kahola, Mika [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82eb1d95afcd4383ac8a15e2a2d64e48@intel.com \
--to=mika.kahola@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox