From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) by gabe.freedesktop.org (Postfix) with ESMTPS id 78A106E0B7 for ; Tue, 15 Jan 2019 21:20:12 +0000 (UTC) Received: by mail-qt1-f196.google.com with SMTP id y20so4671976qtm.13 for ; Tue, 15 Jan 2019 13:20:12 -0800 (PST) Message-ID: <82f5e96fbf0fe65496ffdd934f09403ce3ce8f91.camel@redhat.com> From: Lyude Paul Date: Tue, 15 Jan 2019 16:20:09 -0500 In-Reply-To: <20190111090532.19235-10-paul.kocialkowski@bootlin.com> References: <20190111090532.19235-1-paul.kocialkowski@bootlin.com> <20190111090532.19235-10-paul.kocialkowski@bootlin.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v3 09/21] lib/igt_vc4: Add helpers for converting linear to T-tiled RGB buffers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Paul Kocialkowski , igt-dev@lists.freedesktop.org Cc: Petri Latvala , Eben Upton , Thomas Petazzoni List-ID: T24gRnJpLCAyMDE5LTAxLTExIGF0IDEwOjA1ICswMTAwLCBQYXVsIEtvY2lhbGtvd3NraSB3cm90 ZToKPiBJbiBvcmRlciB0byBpbnRlZ3JhdGUgdGVzdGluZyBvZiBULXRpbGVkIGJ1ZmZlcnMsIHRo ZSBlYXNpZXN0IHBhdGggaXMgdG8KPiBnZW5lcmF0ZSBwYXR0ZXJucyAod2l0aCB0aGUgYWxyZWFk eS1leGlzdGluZyBmdW5jdGlvbnMpIGluIGxpbmVhcgo+IGJ1ZmZlcnMgYW5kIGNvbnZlcnQgdGhl bSB0byBULXRpbGVkIHN1YnNlcXVlbnRseS4KPiAKPiBBZGQgaGVscGVycyB0byBkbyB0aGF0IGNv bnZlcnNpb24sIHdpdGggYSBmaXJzdCBoZWxwZXIgdGhhdCByZXR1cm5zIHRoZQo+IG1lbW9yeSBv ZmZzZXQgZm9yIGEgZ2l2ZW4gcG9zaXRpb24gaW4gYSBULXRpbGVkIGJ1ZmZlciBhbmQgYSBzZWNv bmQKPiBoZWxwZXIgdGhhdCB1c2VzIGl0IGZvciBjb252ZXJ0aW5nIGJldHdlZW4gZnJhbWVidWZm ZXJzLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFBhdWwgS29jaWFsa293c2tpIDxwYXVsLmtvY2lhbGtv d3NraUBib290bGluLmNvbT4KPiAtLS0KPiAgbGliL2lndF92YzQuYyB8IDEzMSArKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICBsaWIvaWd0X3ZjNC5o IHwgICA0ICsrCj4gIDIgZmlsZXMgY2hhbmdlZCwgMTM1IGluc2VydGlvbnMoKykKPiAKPiBkaWZm IC0tZ2l0IGEvbGliL2lndF92YzQuYyBiL2xpYi9pZ3RfdmM0LmMKPiBpbmRleCAxNmRmZTY3YTQ0 YjEuLmI0YjljMmZjNjkxNCAxMDA2NDQKPiAtLS0gYS9saWIvaWd0X3ZjNC5jCj4gKysrIGIvbGli L2lndF92YzQuYwo+IEBAIC0zNCw2ICszNCw3IEBACj4gICNpbmNsdWRlICJkcm10ZXN0LmgiCj4g ICNpbmNsdWRlICJpZ3RfYXV4LmgiCj4gICNpbmNsdWRlICJpZ3RfY29yZS5oIgo+ICsjaW5jbHVk ZSAiaWd0X2ZiLmgiCj4gICNpbmNsdWRlICJpZ3RfdmM0LmgiCj4gICNpbmNsdWRlICJpb2N0bF93 cmFwcGVycy5oIgo+ICAjaW5jbHVkZSAiaW50ZWxfcmVnLmgiCj4gQEAgLTE3NiwzICsxNzcsMTMz IEBAIGJvb2wgaWd0X3ZjNF9wdXJnZWFibGVfYm8oaW50IGZkLCBpbnQgaGFuZGxlLCBib29sCj4g cHVyZ2VhYmxlKQo+ICAKPiAgCXJldHVybiBhcmcucmV0YWluZWQ7Cj4gIH0KPiArCj4gK3Vuc2ln bmVkIGludCBpZ3RfdmM0X2ZiX3RfdGlsZWRfY29udmVydChzdHJ1Y3QgaWd0X2ZiICpkc3QsIHN0 cnVjdCBpZ3RfZmIKPiAqc3JjKQo+ICt7Cj4gKwl1bnNpZ25lZCBpbnQgZmJfaWQ7Cj4gKwl1bnNp Z25lZCBpbnQgaSwgajsKPiArCXZvaWQgKnNyY19idWY7Cj4gKwl2b2lkICpkc3RfYnVmOwo+ICsJ c2l6ZV90IGJwcCA9IHNyYy0+cGxhbmVfYnBwWzBdOwo+ICsJc2l6ZV90IGRzdF9zdHJpZGUgPSBB TElHTihzcmMtPnN0cmlkZXNbMF0sIDEyOCk7Cj4gKwo+ICsJZmJfaWQgPSBpZ3RfY3JlYXRlX2Zi X3dpdGhfYm9fc2l6ZShzcmMtPmZkLCBzcmMtPndpZHRoLCBzcmMtPmhlaWdodCwKPiArCQkJCQkg ICBzcmMtPmRybV9mb3JtYXQsCj4gKwkJCQkJICAgRFJNX0ZPUk1BVF9NT0RfQlJPQURDT01fVkM0 X1RfVElMRUQKPiAsCj4gKwkJCQkJICAgZHN0LCAwLCBkc3Rfc3RyaWRlKTsKPiArCWlndF9hc3Nl cnQoZmJfaWQgPiAwKTsKPiArCj4gKwlzcmNfYnVmID0gaWd0X2ZiX21hcF9idWZmZXIoc3JjLT5m ZCwgc3JjKTsKPiArCWlndF9hc3NlcnQoc3JjX2J1Zik7Cj4gKwo+ICsJZHN0X2J1ZiA9IGlndF9m Yl9tYXBfYnVmZmVyKGRzdC0+ZmQsIGRzdCk7Cj4gKwlpZ3RfYXNzZXJ0KGRzdF9idWYpOwo+ICsK PiArCWZvciAoaSA9IDA7IGkgPCBzcmMtPmhlaWdodDsgaSsrKSB7Cj4gKwkJZm9yIChqID0gMDsg aiA8IHNyYy0+d2lkdGg7IGorKykgewo+ICsJCQlzaXplX3Qgc3JjX29mZnNldCA9IHNyYy0+b2Zm c2V0c1swXTsKPiArCQkJc2l6ZV90IGRzdF9vZmZzZXQgPSBkc3QtPm9mZnNldHNbMF07Cj4gKwo+ ICsJCQlzcmNfb2Zmc2V0ICs9IHNyYy0+c3RyaWRlc1swXSAqIGkgKyBqICogYnBwIC8gODsKPiAr CQkJZHN0X29mZnNldCArPSBpZ3RfdmM0X3RfdGlsZWRfb2Zmc2V0KGRzdF9zdHJpZGUsCj4gKwkJ CQkJCQkgICAgIHNyYy0+aGVpZ2h0LAo+ICsJCQkJCQkJICAgICBicHAsIGosIGkpOwo+ICsKPiAr CQkJc3dpdGNoIChicHApIHsKPiArCQkJY2FzZSAxNjoKPiArCQkJCSoodWludDE2X3QgKikoZHN0 X2J1ZiArIGRzdF9vZmZzZXQpID0KPiArCQkJCQkqKHVpbnQxNl90ICopKHNyY19idWYgKyBzcmNf b2Zmc2V0KTsKPiArCQkJCWJyZWFrOwo+ICsJCQljYXNlIDMyOgo+ICsJCQkJKih1aW50MzJfdCAq KShkc3RfYnVmICsgZHN0X29mZnNldCkgPQo+ICsJCQkJCSoodWludDMyX3QgKikoc3JjX2J1ZiAr IHNyY19vZmZzZXQpOwo+ICsJCQkJYnJlYWs7Cj4gKwkJCWRlZmF1bHQ6Ck1heWJlIHdlIHNob3Vs ZCBhbHNvIGhhdmUgdGhlIHR3byBpZ3RfZmJfdW5tYXBfYnVmZmVyKCkgY2FsbHMgYmVsb3cgdGhp cyBnZXQKaW52b2tlZCBiZWZvcmUgY2FsbGluZyBpZ3RfYXNzZXJ0KGZhbHNlKSBzbyB3ZSBkb24n dCBsZWFrIEZCcyBpZiB0aGlzIGZhaWxzCgpXaXRoIHRoYXQgZml4ZWQ6CgpBY2tlZC1ieTogTHl1 ZGUgUGF1bCA8bHl1ZGVAcmVkaGF0LmNvbT4KPiArCQkJCWlndF9hc3NlcnQoZmFsc2UpOwo+ICsJ CQl9Cj4gKwkJfQo+ICsJfQo+ICsKPiArCWlndF9mYl91bm1hcF9idWZmZXIoc3JjLCBzcmNfYnVm KTsKPiArCWlndF9mYl91bm1hcF9idWZmZXIoZHN0LCBkc3RfYnVmKTsKPiArCj4gKwlyZXR1cm4g ZmJfaWQ7Cj4gK30KPiArCj4gKy8qIENhbGN1bGF0ZSB0aGUgdC10aWxlIHdpZHRoIHNvIHRoYXQg c2l6ZSA9IHdpZHRoICogaGVpZ2h0ICogYnBwIC8gOC4gKi8KPiArI2RlZmluZSBWQzRfVF9USUxF X1coc2l6ZSwgaGVpZ2h0LCBicHApICgoc2l6ZSkgLyAoaGVpZ2h0KSAvICgoYnBwKSAvIDgpKQo+ ICsKPiArc2l6ZV90IGlndF92YzRfdF90aWxlZF9vZmZzZXQoc2l6ZV90IHN0cmlkZSwgc2l6ZV90 IGhlaWdodCwgc2l6ZV90IGJwcCwKPiArCQkJICAgICAgc2l6ZV90IHgsIHNpemVfdCB5KQo+ICt7 Cj4gKwljb25zdCBzaXplX3QgdDFrX21hcF9ldmVuW10gPSB7IDAsIDMsIDEsIDIgfTsKPiArCWNv bnN0IHNpemVfdCB0MWtfbWFwX29kZFtdID0geyAyLCAxLCAzLCAwIH07Cj4gKwljb25zdCBzaXpl X3QgdDRrX3RfaCA9IDMyOwo+ICsJY29uc3Qgc2l6ZV90IHQxa190X2ggPSAxNjsKPiArCWNvbnN0 IHNpemVfdCB0NjRfdF9oID0gNDsKPiArCXNpemVfdCBvZmZzZXQgPSAwOwo+ICsJc2l6ZV90IHQ0 a190X3csIHQ0a193LCB0NGtfeCwgdDRrX3k7Cj4gKwlzaXplX3QgdDFrX3RfdywgdDFrX3gsIHQx a195Owo+ICsJc2l6ZV90IHQ2NF90X3csIHQ2NF94LCB0NjRfeTsKPiArCXNpemVfdCBwaXhfeCwg cGl4X3k7Cj4gKwl1bnNpZ25lZCBpbnQgaW5kZXg7Cj4gKwo+ICsJLyogVC10aWxpbmcgaXMgb25s eSBzdXBwb3J0ZWQgZm9yIDE2IGFuZCAzMiBicHAuICovCj4gKwlpZ3RfYXNzZXJ0KGJwcCA9PSAx NiB8fCBicHAgPT0gMzIpOwo+ICsKPiArCS8qIFQtdGlsaW5nIHN0cmlkZSBtdXN0IGJlIGFsaWdu ZWQgdG8gdGhlIDRLIHRpbGVzIHN0cmlkZXMuICovCj4gKwlpZ3RfYXNzZXJ0KChzdHJpZGUgJSAo NDA5NiAvIHQ0a190X2gpKSA9PSAwKTsKPiArCj4gKwkvKiBDYWxjdWxhdGUgdGhlIHRpbGUgd2lk dGggZm9yIHRoZSBicHAuICovCj4gKwl0NGtfdF93ID0gVkM0X1RfVElMRV9XKDQwOTYsIHQ0a190 X2gsIGJwcCk7Cj4gKwl0MWtfdF93ID0gVkM0X1RfVElMRV9XKDEwMjQsIHQxa190X2gsIGJwcCk7 Cj4gKwl0NjRfdF93ID0gVkM0X1RfVElMRV9XKDY0LCB0NjRfdF9oLCBicHApOwo+ICsKPiArCS8q IEFsaWduZWQgdG90YWwgd2lkdGggaW4gbnVtYmVyIG9mIDRLIHRpbGVzLiAqLwo+ICsJdDRrX3cg PSAoc3RyaWRlIC8gKGJwcCAvIDgpKSAvIHQ0a190X3c7Cj4gKwo+ICsJLyogWCBhbmQgeSBjb29y ZGluYXRlcyBpbiBudW1iZXIgb2YgNEsgdGlsZXMuICovCj4gKwl0NGtfeCA9IHggLyB0NGtfdF93 Owo+ICsJdDRrX3kgPSB5IC8gdDRrX3RfaDsKPiArCj4gKwkvKiBJbmNyZWFzZSBvZmZzZXQgdG8g dGhlIGJlZ2lubmluZyBvZiB0aGUgNEsgdGlsZSByb3cuICovCj4gKwlvZmZzZXQgKz0gdDRrX3kg KiB0NGtfdyAqIDQwOTY7Cj4gKwo+ICsJLyogWCBhbmQgWSBjb29yZGluYXRlcyBpbiBudW1iZXIg b2YgMUsgdGlsZXMgd2l0aGluIHRoZSA0SyB0aWxlLiAqLwo+ICsJdDFrX3ggPSAoeCAlIHQ0a190 X3cpIC8gdDFrX3RfdzsKPiArCXQxa195ID0gKHkgJSB0NGtfdF9oKSAvIHQxa190X2g7Cj4gKwo+ ICsJLyogSW5kZXggZm9yIDFLIHRpbGUgbWFwIGxvb2t1cC4gKi8KPiArCWluZGV4ID0gMiAqIHQx a195ICsgdDFrX3g7Cj4gKwo+ICsJLyogT2RkIHJvd3Mgc3RhcnQgZnJvbSB0aGUgcmlnaHQsIGV2 ZW4gcm93cyBmcm9tIHRoZSBsZWZ0LiAqLwo+ICsJaWYgKHQ0a195ICUgMikgewo+ICsJCS8qIElu Y3JlYXNlIG9mZnNldCB0byB0aGUgNEsgdGlsZSAoc3RhcnRpbmcgZnJvbSB0aGUgcmlnaHQpLgo+ ICovCj4gKwkJb2Zmc2V0ICs9ICh0NGtfdyAtIHQ0a194IC0gMSkgKiA0MDk2Owo+ICsKPiArCQkv KiBJbmNyYXNlIG9mZnNldCB0byB0aGUgYmVnaW5uaW5nIG9mIHRoZSAob2RkKSAxSyB0aWxlLiAq Lwo+ICsJCW9mZnNldCArPSB0MWtfbWFwX29kZFtpbmRleF0gKiAxMDI0Owo+ICsJfSBlbHNlIHsK PiArCQkvKiBJbmNyZWFzZSBvZmZzZXQgdG8gdGhlIDRLIHRpbGUgKHN0YXJ0aW5nIGZyb20gdGhl IGxlZnQpLiAqLwo+ICsJCW9mZnNldCArPSB0NGtfeCAqIDQwOTY7Cj4gKwo+ICsJCS8qIEluY3Jh c2Ugb2Zmc2V0IHRvIHRoZSBiZWdpbm5pbmcgb2YgdGhlIChldmVuKSAxSyB0aWxlLiAqLwo+ICsJ CW9mZnNldCArPSB0MWtfbWFwX2V2ZW5baW5kZXhdICogMTAyNDsKPiArCX0KPiArCj4gKwkvKiBY IGFuZCBZIGNvb3JkaW5hdGVzIGluIG51bWJlciBvZiA2NCBieXRlIHRpbGVzIHdpdGhpbiB0aGUg MUsgdGlsZS4KPiAqLwo+ICsJdDY0X3ggPSAoeCAlIHQxa190X3cpIC8gdDY0X3RfdzsKPiArCXQ2 NF95ID0gKHkgJSB0MWtfdF9oKSAvIHQ2NF90X2g7Cj4gKwo+ICsJLyogSW5jcmVhc2Ugb2Zmc2V0 IHRvIHRoZSBiZWdpbm5pbmcgb2YgdGhlIDY0LWJ5dGUgdGlsZS4gKi8KPiArCW9mZnNldCArPSAo dDY0X3kgKiAodDFrX3RfdyAvIHQ2NF90X3cpICsgdDY0X3gpICogNjQ7Cj4gKwo+ICsJLyogWCBh bmQgWSBjb29yZGluYXRlcyBpbiBudW1iZXIgb2YgcGl4ZWxzIHdpdGhpbiB0aGUgNjQtYnl0ZSB0 aWxlLiAqLwo+ICsJcGl4X3ggPSB4ICUgdDY0X3RfdzsKPiArCXBpeF95ID0geSAlIHQ2NF90X2g7 Cj4gKwo+ICsJLyogSW5jcmVhc2Ugb2Zmc2V0IHRvIHRoZSBjb3JyZWN0IHBpeGVsLiAqLwo+ICsJ b2Zmc2V0ICs9IChwaXhfeSAqIHQ2NF90X3cgKyBwaXhfeCkgKiBicHAgLyA4Owo+ICsKPiArCXJl dHVybiBvZmZzZXQ7Cj4gK30KPiBkaWZmIC0tZ2l0IGEvbGliL2lndF92YzQuaCBiL2xpYi9pZ3Rf dmM0LmgKPiBpbmRleCBlYmM4YTM4ODFiNWUuLmQ1YzUyOWJiY2NkYSAxMDA2NDQKPiAtLS0gYS9s aWIvaWd0X3ZjNC5oCj4gKysrIGIvbGliL2lndF92YzQuaAo+IEBAIC0zMyw0ICszMyw4IEBAIGJv b2wgaWd0X3ZjNF9wdXJnZWFibGVfYm8oaW50IGZkLCBpbnQgaGFuZGxlLCBib29sCj4gcHVyZ2Vh YmxlKTsKPiAgdm9pZCBpZ3RfdmM0X3NldF90aWxpbmcoaW50IGZkLCB1aW50MzJfdCBoYW5kbGUs IHVpbnQ2NF90IG1vZGlmaWVyKTsKPiAgdWludDY0X3QgaWd0X3ZjNF9nZXRfdGlsaW5nKGludCBm ZCwgdWludDMyX3QgaGFuZGxlKTsKPiAgCj4gK3Vuc2lnbmVkIGludCBpZ3RfdmM0X2ZiX3RfdGls ZWRfY29udmVydChzdHJ1Y3QgaWd0X2ZiICpkc3QsIHN0cnVjdCBpZ3RfZmIKPiAqc3JjKTsKPiAr c2l6ZV90IGlndF92YzRfdF90aWxlZF9vZmZzZXQoc2l6ZV90IHN0cmlkZSwgc2l6ZV90IGhlaWdo dCwgc2l6ZV90IGJwcCwKPiArCQkJICAgICAgc2l6ZV90IHgsIHNpemVfdCB5KTsKPiArCj4gICNl bmRpZiAvKiBJR1RfVkM0X0ggKi8KLS0gCkNoZWVycywKCUx5dWRlIFBhdWwKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlndC1kZXYgbWFpbGluZyBsaXN0 CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgo=