Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Karolina Stolarek <karolina.stolarek@intel.com>
To: Vikas Srivastava <vikas.srivastava@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/i915/gem_render_copy: Skip the Y-tile test for MTL
Date: Thu, 9 Mar 2023 14:43:06 +0100	[thread overview]
Message-ID: <833b1d6a-d931-4e3e-15d5-49cf28a6db07@intel.com> (raw)
In-Reply-To: <20230307165324.506526-1-vikas.srivastava@intel.com>

On 7.03.2023 17:53, Vikas Srivastava wrote:
> All the tests for y-tile or yf-tile , neither of these tiling formats
> are supported on MTL so skipping these tests.
> 
> Signed-off-by: Vikas Srivastava <vikas.srivastava@intel.com>
> Acked-by: Sinjan Kumar <sinjan.kumar@intel.com>
> ---
>   tests/i915/gem_render_copy.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/i915/gem_render_copy.c b/tests/i915/gem_render_copy.c
> index 70b96c8f4..2c150b2b0 100644
> --- a/tests/i915/gem_render_copy.c
> +++ b/tests/i915/gem_render_copy.c
> @@ -852,7 +852,7 @@ igt_main_args("dac", NULL, help_str, opt_handler, NULL)
>   			 force_vebox_dst_copy ? "vebox-" : "",
>   			 dst_mode);
>   		igt_subtest_with_dynamic(name) {
> -			igt_skip_on(IS_DG2(data.devid) &&
> +			igt_skip_on((IS_DG2(data.devid) || IS_METEORLAKE(data.devid)) &&

Ideally, we'd use intel_cmds_info/i915_blt helpers, but we lack 
definitions for render. This patch will do for now I think:

Reviewed-by: Karolina Stolarek <karolina.stolarek@intel.com>

>   				    ((t->src_tiling == I915_TILING_Y) ||
>   				     (t->src_tiling == I915_TILING_Yf) ||
>   				     (t->dst_tiling == I915_TILING_Y) ||

      parent reply	other threads:[~2023-03-09 13:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-07 16:53 [igt-dev] [PATCH i-g-t] tests/i915/gem_render_copy: Skip the Y-tile test for MTL Vikas Srivastava
2023-03-07 17:57 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-03-08 20:44 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-03-09 13:43 ` Karolina Stolarek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=833b1d6a-d931-4e3e-15d5-49cf28a6db07@intel.com \
    --to=karolina.stolarek@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=vikas.srivastava@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox