From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: References: <20200224215650.39624-1-chris@chris-wilson.co.uk> <6ad2e8c7-f3e3-a43e-ea4c-92ab57d69b06@linux.intel.com> <158265431375.3656.10896445408963081099@skylake-alporthouse-com> From: Tvrtko Ursulin Message-ID: <836f0076-cc40-46dc-6e8f-97a70ee1c2e7@linux.intel.com> Date: Tue, 25 Feb 2020 18:18:12 +0000 MIME-Version: 1.0 In-Reply-To: <158265431375.3656.10896445408963081099@skylake-alporthouse-com> Content-Language: en-US Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] i915/gem_ctx_persistence: Check precision of hostile cancellation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: igt-dev@lists.freedesktop.org List-ID: On 25/02/2020 18:11, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2020-02-25 18:08:14) >> >> On 24/02/2020 21:56, Chris Wilson wrote: >>> Check that if we have to remove a hostile request from a non-persistent >>> context, we do so without harming any other concurrent users. >>> >>> Signed-off-by: Chris Wilson >>> --- >>> + /* All other spinners should be left unharmed */ >>> + gem_quiescent_gpu(i915); >>> + igt_assert_eq(sync_fence_wait(fence, reset_timeout_ms), 0); >>> + igt_assert_eq(sync_fence_status(fence), 1); >> >> I don't quite get this test. Why would other spinners be unharmed? They >> are non-preemptible as well. And non-persistent spinner is alone on the >> engine. So what aspect you wanted to test? > > Per-engine reset. Termination of the non-persistent context should be > clean and precise, we don't allow creation of non-persistent contexts > unless we have that level of surgical precision. Otherwise it becomes a > new attack vector. If it is just engine reset then it does what it says on the tin. Reviewed-by: Tvrtko Ursulin Regards, Tvrtko _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev