Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andrzej Hajda <andrzej.hajda@intel.com>
To: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
	igt-dev@lists.freedesktop.org
Subject: Re: [PATCH i-g-t v1 1/7] lib/drmtest: add function for retriving chipset
Date: Wed, 12 Jun 2024 09:02:39 +0200	[thread overview]
Message-ID: <838970cd-b554-4f7e-89b6-4e6fe8396cd9@intel.com> (raw)
In-Reply-To: <20240607153629.52596-2-kamil.konieczny@linux.intel.com>



On 07.06.2024 17:36, Kamil Konieczny wrote:
> A few tests uses chipset value for control and checks, so
> instead of testing it with, for example, is_intel_driver(),
> allow to retrieve it once and give it back to test.
>
> Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>

Regards
Andrzej
> ---
>   lib/drmtest.c | 21 +++++++++++++++++++++
>   lib/drmtest.h |  2 ++
>   2 files changed, 23 insertions(+)
>
> diff --git a/lib/drmtest.c b/lib/drmtest.c
> index f8810da43..8ea96ba76 100644
> --- a/lib/drmtest.c
> +++ b/lib/drmtest.c
> @@ -241,6 +241,27 @@ static void modulename_to_chipset(const char *name, unsigned int *chip)
>   	}
>   }
>   
> +/**
> + * drm_get_chipset:
> + * @fd: a drm file descriptor
> + *
> + * Returns:
> + * chipset if driver name found in modules[] array, for example: DRIVER_INTEL
> + * DRIVER_ANY if drm device name not known
> + */
> +unsigned int drm_get_chipset(int fd)
> +{
> +	unsigned int chip = DRIVER_ANY;
> +	char name[32] = "";
> +
> +	if (__get_drm_device_name(fd, name, sizeof(name) - 1))
> +		return chip;
> +
> +	modulename_to_chipset(name, &chip);
> +
> +	return chip;
> +}
> +
>   static const char *chipset_to_str(int chipset)
>   {
>   	switch (chipset) {
> diff --git a/lib/drmtest.h b/lib/drmtest.h
> index bbe5f252f..4d9b60882 100644
> --- a/lib/drmtest.h
> +++ b/lib/drmtest.h
> @@ -72,6 +72,8 @@ enum intel_driver {
>   
>   void __set_forced_driver(const char *name);
>   
> +unsigned int drm_get_chipset(int fd);
> +
>   /**
>    * ARRAY_SIZE:
>    * @arr: static array


  reply	other threads:[~2024-06-12  7:02 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-07 15:36 [PATCH i-g-t v1 0/7] tests/core_hotunplug: Make it fail in subtests Kamil Konieczny
2024-06-07 15:36 ` [PATCH i-g-t v1 1/7] lib/drmtest: add function for retriving chipset Kamil Konieczny
2024-06-12  7:02   ` Andrzej Hajda [this message]
2024-06-07 15:36 ` [PATCH i-g-t v1 2/7] tests/core_hotunplug: set known chipset before tests Kamil Konieczny
2024-06-12  7:03   ` Andrzej Hajda
2024-06-07 15:36 ` [PATCH i-g-t v1 3/7] tests/core_hotplug: Add checks to subtests Kamil Konieczny
2024-06-12  7:02   ` Andrzej Hajda
2024-06-07 15:36 ` [PATCH i-g-t v1 4/7] lib/drmtest: Allow to get drm device name Kamil Konieczny
2024-06-12  7:06   ` Andrzej Hajda
2024-06-07 15:36 ` [PATCH i-g-t v1 5/7] tests/core_hotunplug: Open the same driver Kamil Konieczny
2024-06-12  7:07   ` Andrzej Hajda
2024-06-07 15:36 ` [PATCH i-g-t v1 6/7] tests/core_hotunplug: Fix device close Kamil Konieczny
2024-06-12  7:17   ` Andrzej Hajda
2024-06-07 15:36 ` [PATCH i-g-t v1 7/7] tests/core_hotunplug: Skip if no render available Kamil Konieczny
2024-06-12  7:18   ` Andrzej Hajda
2024-06-07 22:43 ` ✓ Fi.CI.BAT: success for tests/core_hotunplug: Make it fail in subtests Patchwork
2024-06-07 23:13 ` ✓ CI.xeBAT: " Patchwork
2024-06-08 14:02 ` ✗ CI.xeFULL: failure " Patchwork
2024-06-11 15:32   ` Kamil Konieczny
2024-06-08 14:06 ` ✗ Fi.CI.IGT: " Patchwork
2024-06-11 15:35   ` Kamil Konieczny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838970cd-b554-4f7e-89b6-4e6fe8396cd9@intel.com \
    --to=andrzej.hajda@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox