From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 7B11110E48E
 for <igt-dev@lists.freedesktop.org>; Fri, 18 Aug 2023 08:37:04 +0000 (UTC)
Message-ID: <83b01198-5d24-2c15-ed2f-64fff8b8dd0b@intel.com>
Date: Fri, 18 Aug 2023 14:06:45 +0530
To: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
 <igt-dev@lists.freedesktop.org>, <badal.nilawar@intel.com>, "Gupta, Anshuman"
 <anshuman.gupta@intel.com>
References: <20230817055301.855960-1-riana.tauro@intel.com>
 <20230817055301.855960-2-riana.tauro@intel.com>
 <20230818080000.7v2tkddu3t2rmjmt@kamilkon-desk1>
Content-Language: en-US
From: Riana Tauro <riana.tauro@intel.com>
In-Reply-To: <20230818080000.7v2tkddu3t2rmjmt@kamilkon-desk1>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
Subject: Re: [igt-dev] [PATCH i-g-t 1/3] lib/igt_power: Modify igt_power
 library for xe
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
List-ID: <igt-dev@lists.freedesktop.org>


Hi Kamil

On 8/18/2023 1:30 PM, Kamil Konieczny wrote:
> Hi Riana,
> 
> On 2023-08-17 at 11:22:59 +0530, Riana Tauro wrote:
>> modify igt_pm library for xe tests. To check if a
>    ^
> Start sentence from uppercase, s/modify/Modify/
> 
>> device is dgfx the igt_power open call needs to be modified for
>> xe.
>>
>> Signed-off-by: Riana Tauro <riana.tauro@intel.com>
>> ---
>>   lib/igt_power.c | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/lib/igt_power.c b/lib/igt_power.c
>> index 3b34be406..439d49fc3 100644
>> --- a/lib/igt_power.c
>> +++ b/lib/igt_power.c
>> @@ -12,6 +12,7 @@
>>   #include "igt_power.h"
>>   #include "igt_sysfs.h"
>>   
>> +#include "xe/xe_query.h"
> 
> Add newline.

Thanks for the review. Will fix these

Thanks
Riana Tauro
> 
> With this fixed,
> Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> 
>>   static const char *rapl_domains[] = { "cpu", "gpu", "pkg", "ram" };
>>   
>>   static int rapl_parse(struct rapl *r, const char *str)
>> @@ -99,11 +100,13 @@ static inline void rapl_close(struct rapl *r)
>>   int igt_power_open(int fd, struct igt_power *p, const char *domain)
>>   {
>>   	int i;
>> +	bool is_dgfx;
>>   
>>   	p->hwmon_fd = -1;
>>   	p->rapl.fd = -1;
>>   
>> -	if (gem_has_lmem(fd)) {
>> +	is_dgfx = is_xe_device(fd) ? xe_has_vram(fd) : gem_has_lmem(fd);
>> +	if (is_dgfx) {
>>   		if (strncmp(domain, "gpu", strlen("gpu")) == 0) {
>>   			p->hwmon_fd = igt_hwmon_open(fd);
>>   			if (p->hwmon_fd >= 0)
>> -- 
>> 2.40.0
>>